Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934027AbWKTJRx (ORCPT ); Mon, 20 Nov 2006 04:17:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933064AbWKTJRx (ORCPT ); Mon, 20 Nov 2006 04:17:53 -0500 Received: from smtp.osdl.org ([65.172.181.25]:11453 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S933462AbWKTJRw (ORCPT ); Mon, 20 Nov 2006 04:17:52 -0500 Date: Mon, 20 Nov 2006 01:15:16 -0800 From: Andrew Morton To: Evgeniy Polyakov Cc: Ulrich Drepper , David Miller , netdev , Zach Brown , Christoph Hellwig , Chase Venters , Johann Borck , linux-kernel@vger.kernel.org, Jeff Garzik , Alexander Viro Subject: Re: [take24 0/6] kevent: Generic event handling mechanism. Message-Id: <20061120011516.56311f7a.akpm@osdl.org> In-Reply-To: <20061120085158.GA2816@2ka.mipt.ru> References: <11630606361046@2ka.mipt.ru> <45564EA5.6020607@redhat.com> <20061113105458.GA8182@2ka.mipt.ru> <4560F07B.10608@redhat.com> <20061120082500.GA25467@2ka.mipt.ru> <20061120004301.d1815a95.akpm@osdl.org> <20061120085158.GA2816@2ka.mipt.ru> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1646 Lines: 35 On Mon, 20 Nov 2006 11:51:59 +0300 Evgeniy Polyakov wrote: > On Mon, Nov 20, 2006 at 12:43:01AM -0800, Andrew Morton (akpm@osdl.org) wrote: > > > > >If thread calls kevent_wait() it means it has processed previous entries, > > > > >one can call kevent_wait() with $num parameter as zero, which > > > > >means that thread does not want any new events, so nothing will be > > > > >copied. > > > > > > > > This doesn't solve the problem. You could only request new events when > > > > all previously reported events are processed. Plus: how do you report > > > > events if the you don't allow get_event pass them on? > > > > > > Userspace should itself maintain order and possibility to get event in > > > this implementation, kernel just returns events which were requested. > > > > That would mean that in a multithreaded application (or multi-processes > > sharing the same MAP_SHARED ringbuffer), all threads/processes will be > > slowed down to wait for the slowest one. > > Not at all - all other threads can call kevent_get_events() with theirs > own place in the ring buffer, so while one of them is processing an > entry, others can fill next entries. eh? That's not a ringbuffer, and it sounds awfully complex. I don't know if this (new?) proposal resolves the events-gets-lost-due-to-thread-cancellation problem? Would need to see considerably more detail. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/