Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Gabriel Krisman Bertazi <krisman@collabora.com>
To:     Vijendar Mukunda <vijendar.mukunda@amd.com>
Cc:     <broonie@kernel.org>, <alsa-devel@alsa-project.org>,
        <Alexander.Deucher@amd.com>, <Sunil-kumar.Dommati@amd.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        "Jaroslav Kysela" <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        "Ravulapati Vishnu vardhan rao" <Vishnuvardhanrao.Ravulapati@amd.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 12/12] ASoC: amd: enable vangogh acp5x driver build
References: <20210716150809.21450-1-vijendar.mukunda@amd.com>
        <20210716150809.21450-13-vijendar.mukunda@amd.com>
        <87h7guduto.fsf@collabora.com>
Date:   Fri, 16 Jul 2021 14:00:26 -0400
In-Reply-To: <87h7guduto.fsf@collabora.com> (Gabriel Krisman Bertazi's message
        of "Fri, 16 Jul 2021 13:36:51 -0400")
Message-ID: <87czridtqd.fsf@collabora.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Gabriel Krisman Bertazi <krisman@collabora.com> writes:

> Hi,
>
> Vijendar Mukunda <vijendar.mukunda@amd.com> writes:
>> Vangogh ACP5x drivers can be built by selecting necessary
>> kernel config option.
>> The patch enables build support of the same.
>>
>> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
>> ---
>> v1 -> v2: remove extra line in Make file
>> ---
>>  sound/soc/amd/Kconfig          |  9 +++++++++
>>  sound/soc/amd/Makefile         |  1 +
>>  sound/soc/amd/vangogh/Makefile | 11 +++++++++++
>>  3 files changed, 21 insertions(+)
>>  create mode 100644 sound/soc/amd/vangogh/Makefile
>>
>> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
>> index ba5a85bf7412..cc48d4e5b080 100644
>> --- a/sound/soc/amd/Kconfig
>> +++ b/sound/soc/amd/Kconfig
>> @@ -52,3 +52,12 @@ config SND_SOC_AMD_RENOIR_MACH
>>  	depends on SND_SOC_AMD_RENOIR
>>  	help
>>  	 This option enables machine driver for DMIC
>> +
>> +config SND_SOC_AMD_ACP5x
>> +	tristate "AMD Audio Coprocessor-v5.x I2S support"
>> +	depends on X86 && PCI
>> +	help
>> +	 This option enables ACP v5.x support on AMD platform
>> +
>> +	 By enabling this flag build will trigger for ACP PCI driver,
>> +	 ACP DMA drvier, CPU DAI driver.
>> diff --git a/sound/soc/amd/Makefile b/sound/soc/amd/Makefile
>> index e6df2f72a2a1..07150d26f315 100644
>> --- a/sound/soc/amd/Makefile
>> +++ b/sound/soc/amd/Makefile
>> @@ -10,3 +10,4 @@ obj-$(CONFIG_SND_SOC_AMD_CZ_RT5645_MACH) += snd-soc-acp-rt5645-mach.o
>>  obj-$(CONFIG_SND_SOC_AMD_ACP3x) += raven/
>>  obj-$(CONFIG_SND_SOC_AMD_RV_RT5682_MACH) += snd-soc-acp-rt5682-mach.o
>>  obj-$(CONFIG_SND_SOC_AMD_RENOIR) += renoir/
>> +obj-$(CONFIG_SND_SOC_AMD_ACP5x) += vangogh/
>> diff --git a/sound/soc/amd/vangogh/Makefile b/sound/soc/amd/vangogh/Makefile
>> new file mode 100644
>> index 000000000000..ae2cda804e2f
>> --- /dev/null
>> +++ b/sound/soc/amd/vangogh/Makefile
>> @@ -0,0 +1,11 @@
>> +# SPDX-License-Identifier: GPL-2.0+
>> +# Vangogh platform Support
>> +snd-pci-acp5x-objs	:= pci-acp5x.o
>> +snd-acp5x-i2s-objs	:= acp5x-i2s.o
>> +snd-acp5x-pcm-dma-objs	:= acp5x-pcm-dma.o
>> +snd-soc-acp5x-mach-objs := acp5x-nu8821-cs35l41.o

[snip]

>> +
>> +obj-$(CONFIG_SND_SOC_AMD_ACP5x) += snd-pci-acp5x.o
>> +obj-$(CONFIG_SND_SOC_AMD_ACP5x)	+= snd-acp5x-i2s.o
>> +obj-$(CONFIG_SND_SOC_AMD_ACP5x) += snd-acp5x-pcm-dma.o
>> +obj-$(CONFIG_SND_SOC_AMD_VANGOGH_MACH)   += snd-soc-acp5x-mach.o
>
> Looks like CONFIG_SND_SOC_AMD_VANGOGH_MACH is not selected by another
> symbol and also not configurable in kconfig.
>
> Is it missing a kconfig entry?

Actually, acp5x-nu8821-cs35l41.o can't be generated by my tree.  Which
tree is this series based on?  Is there another series that's a
prerequisite for this?

-- 
Gabriel Krisman Bertazi