Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp1552903pxv; Fri, 16 Jul 2021 11:51:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/pqzsg8OtCxzoAsXfU76BnI0Vc0g2QNnW+Ktn6040qxkHt+jf51j9PriJfPwz6NqvFXj6 X-Received: by 2002:aa7:d352:: with SMTP id m18mr17109091edr.235.1626461506036; Fri, 16 Jul 2021 11:51:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626461506; cv=none; d=google.com; s=arc-20160816; b=N66MpukBJcbD78EKe1+rgTyoIo1qGEzZ+GJm1OT6/5fTLFJHC7k6DI6oex3hGZKr8w mmDf6AB0mu0h1syntHWPyWpRqOskh267uErcL4l+Hpe3Uxf9ODaugVR//mUmRt1ZoJPB dqpBY1R86TLOxNxSAYAulMuV06rNY371/91Oiz+IObDK0QMlr6y1lNjN/QRVRWyXDHIq UK9y1exvPOashUb1yhBIPMCpGr/whHDzJo/VTgyCCw1eLnDTA2bIqOVJPmL8M66InZ7m ZqS1hAsT4z4O0XhN53AqmDLGtJeirnY36qWKCa3PznfpgPj0hN/9mIsw6m8h2tKouTZ4 +czA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=WLcabWNJajXiIZIz8f/zVj38rA23oEZhKMpGjgEQAoo=; b=UaghZ9XOIBbdaVKpBV2cLCM5S5qg2USFz2NAE8rqu0RiwpwNObo53dQBlyYAS0Nj+6 ap/jLCdzbOdFAeLv2ihpa1k+TAeFLBJeSD8IQoIdcm9JWws8CXtA7cmnEvI/DcHnubIO bEbSW2xS5jVaWN76YRar5554v3vbAClPXP+zFDANqm0JEnE3N3crOm899wE9JIjjQtZ0 D0Q/iD5V9kNgszkTw8BJUCBB2liSVcKZBvRmpY3d+TUiyPO8XEDkQnUu1mEOROl6xGdA 2cTUtt8dDwkKSs7fPTkrh/rGVf7wwNwkKRgP1o04jGR8kxSYN/MBEZmaMgcBDzBfSIbN UwKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ePoWPz7A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v18si6406827edc.4.2021.07.16.11.51.23; Fri, 16 Jul 2021 11:51:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ePoWPz7A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232172AbhGPSxA (ORCPT + 99 others); Fri, 16 Jul 2021 14:53:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:54192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230211AbhGPSw7 (ORCPT ); Fri, 16 Jul 2021 14:52:59 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id AB843613D4; Fri, 16 Jul 2021 18:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626461404; bh=yJV5FpmgKuYyCRiBEPqE5UggKP1YUDvraHXINqKQwD0=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=ePoWPz7AyzZCam/oK+xf5sEQ/DK5HaQqb0yP3kQR/nq611ZP8s24ca7a17AIvh9N6 IajuGG6u1q3i1OEtHd9djoLF6sH6G5w28CVt4t/ib80AmraFigNbBBw5NB3X2RgdMC QU5QbJmTAkR9qBkk+xNTZsLia3+71m1mPDPRmChzYrFlmvDPLonKUdX6x916TepwhP VA7g6SPUjMn5HOw6U5B3vV7gjD3fmuMIx38D9SK/56kytb8O2M4t4ggdzNV5XXDAmG CilzVDiBcNdwweDFJy8lTor2VjGTl61JfnQ8Xy6et5sZ4jH1Vrkpqf9RSJo4Lz1ae4 0GKcebe0VRXXg== Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id 9C74B609DA; Fri, 16 Jul 2021 18:50:04 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH 1/1 v3] skbuff: Fix a potential race while recycling page_pool packets From: patchwork-bot+netdevbpf@kernel.org Message-Id: <162646140463.32424.6557928030854719030.git-patchwork-notify@kernel.org> Date: Fri, 16 Jul 2021 18:50:04 +0000 References: <20210716070222.106422-1-ilias.apalodimas@linaro.org> In-Reply-To: <20210716070222.106422-1-ilias.apalodimas@linaro.org> To: Ilias Apalodimas Cc: netdev@vger.kernel.org, linyunsheng@huawei.com, alexanderduyck@fb.com, brouer@redhat.com, davem@davemloft.net, kuba@kernel.org, alobakin@pm.me, jonathan.lemon@gmail.com, willemb@google.com, linmiaohe@huawei.com, gnault@redhat.com, cong.wang@bytedance.com, mcroce@microsoft.com, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 16 Jul 2021 10:02:18 +0300 you wrote: > As Alexander points out, when we are trying to recycle a cloned/expanded > SKB we might trigger a race. The recycling code relies on the > pp_recycle bit to trigger, which we carry over to cloned SKBs. > If that cloned SKB gets expanded or if we get references to the frags, > call skb_release_data() and overwrite skb->head, we are creating separate > instances accessing the same page frags. Since the skb_release_data() > will first try to recycle the frags, there's a potential race between > the original and cloned SKB, since both will have the pp_recycle bit set. > > [...] Here is the summary with links: - [1/1,v3] skbuff: Fix a potential race while recycling page_pool packets https://git.kernel.org/netdev/net/c/2cc3aeb5eccc You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html