Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Fri, 16 Jul 2021 15:18:33 -0400
Message-Id: <CCUT1ZDDWS1J.3CGKX5J1MNFOX@shaak>
Cc:     <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <robh+dt@kernel.org>
Subject: Re: [PATCH v5 05/10] iio: afe: rescale: add INT_PLUS_{MICRO,NANO}
 support
From:   "Liam Beguin" <liambeguin@gmail.com>
To:     "Peter Rosin" <peda@axentia.se>, <jic23@kernel.org>,
        <lars@metafoo.de>, <pmeerw@pmeerw.net>
References: <20210715031215.1534938-1-liambeguin@gmail.com>
 <20210715031215.1534938-6-liambeguin@gmail.com>
 <8417f698-eef2-3311-625a-1ceb17d3e5b2@axentia.se>
In-Reply-To: <8417f698-eef2-3311-625a-1ceb17d3e5b2@axentia.se>
Precedence: bulk

On Thu Jul 15, 2021 at 5:48 AM EDT, Peter Rosin wrote:
>
> On 2021-07-15 05:12, Liam Beguin wrote:
> > From: Liam Beguin <lvb@xiphos.com>
> >=20
> > Some ADCs use IIO_VAL_INT_PLUS_{NANO,MICRO} scale types.
> > Add support for these to allow using the iio-rescaler with them.
> >=20
> > Signed-off-by: Liam Beguin <lvb@xiphos.com>
> > ---
> >  drivers/iio/afe/iio-rescale.c | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >=20
> > diff --git a/drivers/iio/afe/iio-rescale.c b/drivers/iio/afe/iio-rescal=
e.c
> > index 4c3cfd4d5181..a2b220b5ba86 100644
> > --- a/drivers/iio/afe/iio-rescale.c
> > +++ b/drivers/iio/afe/iio-rescale.c
> > @@ -92,7 +92,22 @@ static int rescale_read_raw(struct iio_dev *indio_de=
v,
> >  			do_div(tmp, 1000000000LL);
> >  			*val =3D tmp;
> >  			return ret;
> > +		case IIO_VAL_INT_PLUS_NANO:
> > +			tmp =3D ((s64)*val * 1000000000LL + *val2) * rescale->numerator;
> > +			do_div(tmp, rescale->denominator);
> > +
> > +			*val =3D div_s64(tmp, 1000000000LL);
> > +			*val2 =3D tmp - *val * 1000000000LL;
> > +			return ret;
>
> This is too simplistic and prone to overflow. We need something like
> this
> (untested)
>
> tmp =3D (s64)*val * rescale->numerator;
> rem =3D do_div(tmp, rescale->denominator);
> *val =3D tmp;
> tmp =3D ((s64)rem * 1000000000LL + (s64)*val2) * rescale->numerator;
> do_div(tmp, rescale->denominator);
> *val2 =3D tmp;
>
> Still not very safe with numerator and denominator both "large", but
> much
> better. And then we need normalizing the fraction part after the above,
> of
> course.
>

Understood, I'll test that.

> And, of course, I'm not sure what *val =3D=3D -1 and *val2 =3D=3D 5000000=
00
> really
> means. Is that -1.5 or -0.5? The above may very well need adjusting for
> negative values...
>

I would've assumed the correct answer is -1 + 500000000e-9 =3D -0.5
but adding a test case to iio-test-format.c seems to return -1.5...

I believe that's a bug but we can work around if for now by moving the
integer part of *val2 to *val.

Liam

> Cheers,
> Peter
>
> > +		case IIO_VAL_INT_PLUS_MICRO:
> > +			tmp =3D ((s64)*val * 1000000LL + *val2) * rescale->numerator;
> > +			do_div(tmp, rescale->denominator);
> > +
> > +			*val =3D div_s64(tmp, 1000000LL);
> > +			*val2 =3D tmp - *val * 1000000LL;
> > +			return ret;
> >  		default:
> > +			dev_err(&indio_dev->dev, "unsupported type %d\n", ret);
> >  			return -EOPNOTSUPP;
> >  		}
> >  	default:
> >=20