Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756748AbWKTLRi (ORCPT ); Mon, 20 Nov 2006 06:17:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756724AbWKTLRi (ORCPT ); Mon, 20 Nov 2006 06:17:38 -0500 Received: from emailer.gwdg.de ([134.76.10.24]:27564 "EHLO emailer.gwdg.de") by vger.kernel.org with ESMTP id S1756748AbWKTLRh (ORCPT ); Mon, 20 Nov 2006 06:17:37 -0500 Date: Mon, 20 Nov 2006 12:02:12 +0100 (MET) From: Jan Engelhardt To: Chris Snook cc: Jay Cliburn , jeff@garzik.org, shemminger@osdl.org, romieu@fr.zoreil.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver In-Reply-To: <456144C1.8040809@redhat.com> Message-ID: References: <20061119203006.GC29736@osprey.hogchain.net> <456144C1.8040809@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Report: Content analysis: 0.0 points, 6.0 required _SUMMARY_ Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 884 Lines: 25 On Nov 20 2006 01:01, Chris Snook wrote: > Jan Engelhardt wrote: >> > +#define AT_READ_REG_ARRAY(a, reg, offset) ( \ >> > + readl(((a)->hw_addr + reg) + ((offset) << 2))) >> >> Possibly similarly. > > Yeah, we'll inline these as well. Would you say that level of cosmetic > cleanliness is required for merging, or should we focus solely on the > functional issues for now? Required? No I do not think so, there is worse code than this. (Don't take that as an excuse to write bad code! :-) It's just that it's easier to read if there are less parentheses. These defines are a good example of border (define vs inline) cases. -`J' -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/