Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp2150979pxv; Sat, 17 Jul 2021 05:35:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzrpfRdrjOfkp7qR/XdMsivaII+DhLMAKf6Bw6OMKZuyetdCTBeZRKD/UM5pSSaqu5G/bi X-Received: by 2002:a17:906:698a:: with SMTP id i10mr17373799ejr.499.1626525301538; Sat, 17 Jul 2021 05:35:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626525301; cv=none; d=google.com; s=arc-20160816; b=tNqBQxjFkmuKWEPi+8ZhntpQnWKKik7Etg4x24qtPQtXkQtSp57xkrXlrh1ffFfIa9 KXGnPtkaOfZ6oVcmz0lgrnA+3pwjjlhcJ2/VpQP7I6mGO2GUhea3aYjJJG9qT6soO7F8 8P/kKRbj3bzSNAg5BLIckP1DJc2x+B3OdSUCifUkuebc3l4YgzlXbsL0NtXdbRwNyY25 S2W31cqDTTTi4oLgtrv45q8LLlAEzUotLDbxJp1PcsHm06kwCnc/c9VEleQaSwCCn/kd gR85/QYjIKkwhq6z0NFghom5pqq/qjbe/YrBxViVBcp6lLHZBRNFZHucmhrvS41Nidy0 exIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=SD0R3zYxm1t/0uzxERpXDObXCsoS886xQ4oYuK4JvFQ=; b=XnS7mKhS05dA3bQeskrZiSGXwGEkh1W1QLGUsHc7QH+hZo8SGGKPSsqmPRzcX8LVHY kvNI3gDy3tSmNwMvived6iVhHFehF703EGwx1Qegb8XYlyXegWS4Oxxe9oMgjcxLw937 ZFBREdkRlxr53DHe+sSsODVz9uEr0p7K4ScKv6amjMHtB+F3kR/3fM0kSbt8VcE+6nxS 0Eu5eaBbyhrXOPzqDs71TiNV2cls0Yv9h0G+qdDH/nACg/DltmkUrzPtdmiP5rjjnTii K+klevdz68gCObcUnB/AKoOo8Yod3ucY1r/NSzosGDu1xYtrPM4JA4aFhFrwarwrfeUf g0tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@natalenko.name header.s=dkim-20170712 header.b=TUdwv1Is; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=natalenko.name Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w11si18241613ejc.221.2021.07.17.05.34.38; Sat, 17 Jul 2021 05:35:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@natalenko.name header.s=dkim-20170712 header.b=TUdwv1Is; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=natalenko.name Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233568AbhGQMgd (ORCPT + 99 others); Sat, 17 Jul 2021 08:36:33 -0400 Received: from vulcan.natalenko.name ([104.207.131.136]:55452 "EHLO vulcan.natalenko.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbhGQMgc (ORCPT ); Sat, 17 Jul 2021 08:36:32 -0400 Received: from localhost (unknown [151.237.229.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vulcan.natalenko.name (Postfix) with ESMTPSA id B5A55B3A131; Sat, 17 Jul 2021 14:33:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=natalenko.name; s=dkim-20170712; t=1626525214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=SD0R3zYxm1t/0uzxERpXDObXCsoS886xQ4oYuK4JvFQ=; b=TUdwv1Is81UuNOHvc02lrew+ITkwqXP258zdpyM4UJqjxEHo4fA/hKv987fsuqcH7uLXnf Yn36cuzPlVPYF2CFI2L1Ty74q3GF6NOBM6h4D2rZ6lQqURI6rPGFohtmUqTZoSwkwS6emy n1Hl3sVJJ/Nejvs/bMgtTAYmzEg76KM= From: Oleksandr Natalenko To: linux-kernel@vger.kernel.org Cc: linux-block@vger.kernel.org, Jens Axboe , Ming Lei , Christoph Hellwig , Laurence Oberman , Paolo Valente , David Jeffery , Bart Van Assche Subject: [PATCH] block: increase BLKCG_MAX_POLS Date: Sat, 17 Jul 2021 14:33:28 +0200 Message-Id: <20210717123328.945810-1-oleksandr@natalenko.name> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After mq-deadline learnt to deal with cgroups, the BLKCG_MAX_POLS value became too small for all the elevators to be registered properly. The following issue is seen: ``` calling bfq_init+0x0/0x8b @ 1 blkcg_policy_register: BLKCG_MAX_POLS too small initcall bfq_init+0x0/0x8b returned -28 after 507 usecs ``` and BFQ is non-functional. Increase BLKCG_MAX_POLS to allow space for everyone Link: https://lore.kernel.org/lkml/8988303.mDXGIdCtx8@natalenko.name/ Signed-off-by: Oleksandr Natalenko --- include/linux/blkdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 3177181c4326..d3afea47ade6 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -57,7 +57,7 @@ struct blk_keyslot_manager; * Maximum number of blkcg policies allowed to be registered concurrently. * Defined here to simplify include dependency. */ -#define BLKCG_MAX_POLS 5 +#define BLKCG_MAX_POLS 6 typedef void (rq_end_io_fn)(struct request *, blk_status_t); -- 2.32.0