Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v5 1/4] dt-bindings: mfd: Add bindings for Ampere Altra
 SMPro MFD driver
To:     Rob Herring <robh@kernel.org>
Cc:     Jean Delvare <jdelvare@suse.com>, linux-kernel@vger.kernel.org,
        Guenter Roeck <linux@roeck-us.net>,
        Joel Stanley <joel@jms.id.au>,
        Rob Herring <robh+dt@kernel.org>,
        Andrew Jeffery <andrew@aj.id.au>,
        Open Source Submission <patches@amperecomputing.com>,
        "Thang Q . Nguyen" <thang@os.amperecomputing.com>,
        openbmc@lists.ozlabs.org, linux-hwmon@vger.kernel.org,
        Lee Jones <lee.jones@linaro.org>, devicetree@vger.kernel.org,
        Phong Vo <phong@os.amperecomputing.com>,
        linux-doc@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
        Jonathan Corbet <corbet@lwn.net>
References: <20210713060031.31568-1-quan@os.amperecomputing.com>
 <20210713060031.31568-2-quan@os.amperecomputing.com>
 <20210716173443.GA3643583@robh.at.kernel.org>
From:   Quan Nguyen <quan@os.amperecomputing.com>
Message-ID: <ece6e0ec-4566-0371-be57-89a69d425683@os.amperecomputing.com>
Date:   Sat, 17 Jul 2021 19:51:52 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.11.0
In-Reply-To: <20210716173443.GA3643583@robh.at.kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2402:800:623c:a5ad:55f4:5d0e:4366:3aa5] (2402:800:623c:a5ad:55f4:5d0e:4366:3aa5) by HK2PR03CA0059.apcprd03.prod.outlook.com (2603:1096:202:17::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.8 via Frontend Transport; Sat, 17 Jul 2021 12:51:59 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d614883d-cfee-4c61-d911-08d94921ad14
X-MS-TrafficTypeDiagnostic: MWHPR01MB2733:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR01MB2733E217B7A1A33B4AE0EAB1F2109@MWHPR01MB2733.prod.exchangelabs.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1107;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: b2c/+JDDmP0FqlnR+CMzw0YEGUUc8PqJgWsiLdXn4TSsZa4MJN7NpVY5Fsb/i9h1Ksoz6ajhPpUrePQIWUQtDRMCg0t++pR83g4Kt8C54ucsiSBUqux6ldU/hE/AmUN3lZ5Yoh+cj8SBNVB+iHJpiuCQs1vkkq00I+fuN46F0qhTV/ABlNser0QWwAivLhxnEKbBlkeVDHa6DJPgh6OYimy/Cz9K0734YaiXrKU9Es4GR/q0Ej4fn4cBdfc79hOoqRNupH/6HQNdMTxiZVEdEdPtfdLVcQaN2+KBo1yfZOIuFTKz9lvqMqGBzu/8TgNt98rQD9i10GTtxNm7AQLkl3EWRj1O2qGW3ZtoqUXk/XzMI0i+GFD8A8meCKd0Vt0qY7MhCjvrHtrANc9bTrejPtBPKs/ZIQ8LgQ8v82aV/1hAnr7+qVCOPJOicB6rqwaI3dsyTnlZUc27Mm2l9OkDSJ1sC7fKCxE+0KqP5NqNyBGA6e64Q88j1ghCM9yG9aH4+VHT13JibKYZnjH153OuoSEO9FHqQ7YVAUxFyvnfqQ9hj2+NvyfKEgZvb6cApZJVgzWns418zQgDPXI4b9IoqPkK0TMt7iNRDKCMVLrk7/1SwwRPXV3KUOeIIfvkchJofPrI0DBgHbDpykEpIKtBigRH4hmldS6A09rJb4VPXaffAPprnaDCKID3PMrB9utz0uPVWURCB8jFiKklGwNbSQuSqE5gmZG2LfFPF/eqIgY=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR0102MB3482.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(396003)(136003)(366004)(39850400004)(478600001)(31696002)(7416002)(6916009)(5660300002)(4326008)(2616005)(6486002)(31686004)(6666004)(66556008)(66476007)(52116002)(66946007)(38100700002)(8936002)(8676002)(54906003)(53546011)(86362001)(316002)(83380400001)(186003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnZkL24rSTlaMlR1eVBMc291VE1QZ1NsZU1lOEIyOHlDdkhGOHpnNnZ1MFBY?=
 =?utf-8?B?aFF4dm82ME52M2xNTmszaUx2NndmM3dFYXZ0aDE5WW1ZMHZsamh0QnIrZWFO?=
 =?utf-8?B?ek5yemhyVHFqcW43WnoyTU4razZ4d3NjNmZmeGM0Q0lJSXA0azJrUVM1U3VU?=
 =?utf-8?B?QUJML2xKWmJKNmZpZGw4ZWZnUkZScDA1M1VzZmROZjdGTEN5RnFwMDhhZzhJ?=
 =?utf-8?B?ZG1CUmh6MmNobk1XbmhIbUpaOGJtVW9KNHQ5MFB0QnIrNW9aZ0hwbHJyaGtz?=
 =?utf-8?B?TGUxNzREWVEvcFN4eS9hSWVMTEpuZHlHTXVBWlVrTFhWZnNTWjRYMFdFRkVL?=
 =?utf-8?B?Wk4wUnA5a2RHWklHSHlEZ1lBSUJWSC9OZ0pHc0JMZW1HRHBXUGY3dVNaYWhC?=
 =?utf-8?B?M2NGV3hBL0RnMVI4MEtjQlgzUnJwVm9qaWVZWTVZUGZjaEdXc3FZZVBnMVBn?=
 =?utf-8?B?T1Z6TnVaKzBYZzZobkU4MGplcUNrb2Z6ZEl1SlFPQS9JTXUreHk4VUcrQ1k3?=
 =?utf-8?B?N1k3K3lKMVNZNk5OTnpIS1JyVWwxREl4cVE1bTYvbVJDQS9CZ2tvaHNuZUVX?=
 =?utf-8?B?dVBqY0d3ZW96Tk1wWnEwQVQwKzlwckRaNThxT0ljU2tzVWw2NzZuZnBic1Rp?=
 =?utf-8?B?cEFCKzNJKzdmWDdvZUJZdEZOSTZySExjaGxKSi9XQTcrdUo2WWQ3QkhFeWJI?=
 =?utf-8?B?YjgrYUhIYTJVclZDeDZURlBwOUFqM1NaVHZVQjlqaGR1WXNPSWtlL1NWSXpY?=
 =?utf-8?B?YjNnTWhjQXF4eHR6aFd2MDhrMW8wYXhJYmJZSy80REs1cExWaC9Yc2k4NVJn?=
 =?utf-8?B?K3VkODJibUFJRnBWMUg3bHdrNW1qUEJrTUF5REVXZXRndFlUU25ibS9OVXV6?=
 =?utf-8?B?d1JjL2c3NU95UEM3SW83elFaclJUZnZidzUrT2RYNHBKdmxqcFQ5QmpBS2Mv?=
 =?utf-8?B?SlNOTERKK0JYZXpTMnRnemFNbnBwa3BtQm9mb3F5dDVkRnBvQ2RNZTFvQ2tO?=
 =?utf-8?B?SzZxZS8rTTlaa25TQzF2b2lMNkFWMVIvNjQ5ZEpVYzJYZHYrRTkyR0NJdHRH?=
 =?utf-8?B?cjhvc2U4Z2UzdWFNNW5YZW85NzBsYTM3a0N6dWN4WnZ3WHhneWw2VlN3QzA0?=
 =?utf-8?B?MFltY3hiR0tZYzZpUk9aRmlkek5VSzFuTFoyaXBtWnNjRk1xelNxSnpNRlBs?=
 =?utf-8?B?ZS94ZnpScUJTditaZDMzRlRNNHNubjc4UUhTU0xpRGtmaDJsMkRMb1RGT3gv?=
 =?utf-8?B?ZGg3U05oYnViWlRzNzFtL2FIVno3M1dCVVRnZkVNOXUyLzl3bnEvanhqMG9t?=
 =?utf-8?B?L0ZjN1JqbGV1d0FoU0dBOHhNa3VCTERaNXFMOW1SL2dsSHNOcHY2YUMzb0Np?=
 =?utf-8?B?ajhOMThrRTBkWGVMVkFxVlNyM0Q4b21vd3Z2RXJJVlpubjB6bGtjdEhkS2sv?=
 =?utf-8?B?aTdnYnl6cXFHVGovaGt5NTNvbE5abXhUb0hLM2t0U1RkQ1ZnaVBvNkgwUnkr?=
 =?utf-8?B?aURuMU9jVG5EbjlJNXlGSnhwakZ5b3ViWUQvTkdHdVJYeWRqM3RGbSt1ZWpY?=
 =?utf-8?B?WjZvdkpUU20yMUNVSWFnZDAvWktDRDhEbU94M1JBcTBseXJlMkRRUHRVakZT?=
 =?utf-8?B?cXdUY21jNjgzdGVUL0JRQk01TVZIWVh1aWMyb2QwMlh2eC9TSHJBbFc1ZXJE?=
 =?utf-8?B?SmRTb3VzajNDWjNSRU9Ua0lkQ0hmVTRzMWZLVUlhQXZQcU5OalJ3R3o2Ykhm?=
 =?utf-8?B?Y29vM2RPM0hVd0VRRkF2Q3U2MDlCNWdQVkZERzd2S1l5M1ZDSlI0Zm16STZq?=
 =?utf-8?B?dEZCUnVRRTdVRmRGeHM2YWNpMS9idHZVeFJCdjM4YzZJajZjUTBOSXcyNk1t?=
 =?utf-8?Q?ULvKyIQzezxaw?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d614883d-cfee-4c61-d911-08d94921ad14
X-MS-Exchange-CrossTenant-AuthSource: MW2PR0102MB3482.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2021 12:52:04.2645
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cg/HBBIPf9JvNJsakvwHrIJ57xrb8KD0c/pBXadIIAou1sjkcwFu1NZeAudDzXYO4ZOLb11Xqha6WyYtHMUzmj11UEdHlWIxqGTTHfxvmtc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR01MB2733
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 17/07/2021 00:34, Rob Herring wrote:
> On Tue, 13 Jul 2021 13:00:28 +0700, Quan Nguyen wrote:
>> Adds device tree bindings for SMPro MFD driver found on the Mt.Jade
>> hardware reference platform with Ampere's Altra Processor family.
>>
>> The SMpro co-processor on Ampere Altra processor family is to monitor
>> and report various data included hwmon-related info, RAS errors, and
>> other miscellaneous information.
>>
>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
>> ---
>> Changes in v5:
>>    + Dropped ../bindings/hwmon/ampere,ac01-hwmon.yaml file [Quan]
>>    + Removed patternProperties section and child DT nodes in example
>>    section [Quan]
>>    + Revised commit message [Quan]
>>
>> Changes in v4:
>>    + Revised the commit message to clarify how the specific info will
>>      be handled commented by Rob.
>>
>> Changes in v3:
>>    + Supported list of compatible string [Rob]
>>    + Introduced reg property in DT to specify reg offset [Rob]
>>    + Updated description and other minor changes in yaml file [Rob]
>>
>> Changes in v2:
>>    + Changed "ampere,ac01-smpro" to "ampere,smpro" [Quan]
>>
>>   .../devicetree/bindings/mfd/ampere,smpro.yaml | 52 +++++++++++++++++++
>>   1 file changed, 52 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/mfd/ampere,smpro.yaml
>>
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
>

Thanks Rob for the review.
- Quan