Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp2297408pxv; Sat, 17 Jul 2021 09:28:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRtIc0r02Xt+hBemfzKgfxHS/lKOi77PAZDYwGfLyOvIbPq2JZ8ELUQBEuUyC96f8VQ3s9 X-Received: by 2002:a02:3c17:: with SMTP id m23mr13760103jaa.84.1626539334966; Sat, 17 Jul 2021 09:28:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626539334; cv=none; d=google.com; s=arc-20160816; b=ammSZhgZiXcbD1Frx2V7HhTfZHwB7/1tKqASsycmptW5KEAg0cWzJ/GQcn6DhnisC+ IF3pH0SW+NNWwJApG44onqDV3MOa2BdFaUQ2DTnuvI0o/f7uRqCZ6ClwYeeeiNTElS66 nJmpn1QZMbkDkQdu6NtohMT/qKClJJjLnJCGDQs4BZf61IyARA+HyFOt1c+qjlDxqQx5 or0sx6PK26Ha3UgElzK341M9+yNyAdqzkGVvTIn7uVqqk496wyNMJB4AvLNYXYVyg5Eq XNk9PAj007RFhLF0ZWPvz7A4YZqDVWmv4l+M/pooTGySQxdcEIt2hr+hYrf5ZsWjKItj 8GAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=hMHAVT3FIryoflpAxSYqU4AtSFOocoMnlnWbF2KwP8E=; b=bNQMf7Uva8576/9k3Ey6iI+rs2dmXv/arx80/o1NqCIiLd8sH5r10k6mUU4leqjYOy ap6NsSXyUwSroe8BLVJ7grLOdO3xJ9wMv4pPb8SfgJeV4nRIerxTYKeJWv0DEFlzrW4t pnNJXbUalQ2YSRF8QMfEVqAMnjWKMYtw7Npj7EUSuBCnkGazuTR+oZtKWv83oD6742a1 agwzlvww+kXC9AtE3bInBP3Aafg5HvOsbsSrFxccpsyZv+XNJ7ydAHQYxinFVje8mKea hTj22O+rS5QdifJpLe3Vo8KuT/TAA7XXOFSLGFNfww6DXGQfaBtuuH0XUj7g/xEIw2b6 k9Sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b=jAsb6MoT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j8si3463031ioq.34.2021.07.17.09.28.42; Sat, 17 Jul 2021 09:28:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b=jAsb6MoT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230272AbhGQQbL (ORCPT + 99 others); Sat, 17 Jul 2021 12:31:11 -0400 Received: from m15111.mail.126.com ([220.181.15.111]:46525 "EHLO m15111.mail.126.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229581AbhGQQbK (ORCPT ); Sat, 17 Jul 2021 12:31:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id; bh=hMHAVT3FIryoflpAxS YqU4AtSFOocoMnlnWbF2KwP8E=; b=jAsb6MoTPynP1oEPb5GXBKo3IkGfL6WFb4 FPFvyK5YkQ/iBJEeoROWMaNOQqQP0lZU8Iid8NjcNhmlwLhDkpTKGDYTg1ezHiiJ IhqH9PHFFnl7XZ7Wr/GCWN1M4Ndmc8/ShDhikRYIDsSGIPH4VEjc0mOfeMkhvGSl pLy2MeNww= Received: from 192.168.137.133 (unknown [112.10.74.16]) by smtp1 (Coremail) with SMTP id C8mowAB3Ol1S_fJg_DnxTA--.9273S3; Sat, 17 Jul 2021 23:55:03 +0800 (CST) From: Xianting Tian To: agk@redhat.com, snitzer@redhat.com Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org, Xianting Tian Subject: [PATCH] dm io: fix comments to align with on-stack plugging Date: Sat, 17 Jul 2021 11:54:23 -0400 Message-Id: <1626537263-8752-1-git-send-email-xianting_tian@126.com> X-Mailer: git-send-email 1.8.3.1 X-CM-TRANSID: C8mowAB3Ol1S_fJg_DnxTA--.9273S3 X-Coremail-Antispam: 1Uf129KBjvdXoWruF1UKFykZF4kZw45AFy5Jwb_yoWkAFX_Cr 90qa97Wr1YkF13Kr43Gr4avr95KrZ7uF1xWF1UKa9xWa40vws0qr9rKrnxKr1UZayxCa98 GFWkJ34rC3y09jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnKhF7UUUUU== X-Originating-IP: [112.10.74.16] X-CM-SenderInfo: h0ld03plqjs3xldqqiyswou0bp/1tbizhfSpF8RNK227wAAsh Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xianting Tian Ther is no unplugging timer now, on-stack io plugging is used: struct blk_plug plug; blk_start_plug(&plug); submit_batch_of_io(); blk_finish_plug(&plug); So remove the old comments for unplugging timer. Signed-off-by: Xianting Tian --- drivers/md/dm-io.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/md/dm-io.c b/drivers/md/dm-io.c index 2d3cda0..7dba193 100644 --- a/drivers/md/dm-io.c +++ b/drivers/md/dm-io.c @@ -528,11 +528,6 @@ static int dp_init(struct dm_io_request *io_req, struct dpages *dp, /* * New collapsed (a)synchronous interface. - * - * If the IO is asynchronous (i.e. it has notify.fn), you must either unplug - * the queue with blk_unplug() some time later or set REQ_SYNC in - * io_req->bi_opf. If you fail to do one of these, the IO will be submitted to - * the disk after q->unplug_delay, which defaults to 3ms in blk-settings.c. */ int dm_io(struct dm_io_request *io_req, unsigned num_regions, struct dm_io_region *where, unsigned long *sync_error_bits) -- 1.8.3.1