Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210716182126.4392-1-dwaipayanray1@gmail.com>
In-Reply-To: <20210716182126.4392-1-dwaipayanray1@gmail.com>
From:   Lukas Bulwahn <lukas.bulwahn@gmail.com>
Date:   Sat, 17 Jul 2021 18:32:05 +0200
Message-ID: <CAKXUXMyvOh0GvpEf4uX5iFJYOJLo43tmO16Uf34j4i6XD0vBcg@mail.gmail.com>
Subject: Re: [PATCH] checkpatch: remove obsolete check for __dev* section markers
To:     Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc:     Joe Perches <joe@perches.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andy Whitcroft <apw@canonical.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jul 16, 2021 at 8:21 PM Dwaipayan Ray <dwaipayanray1@gmail.com> wrote:
>
> Commit 54b956b90360 ("Remove __dev* markings from init.h")
> completely removed the definitions of __dev* section
> markers from init.h. They can no longer pop up in the kernel
> and hence the check for those markers is unneeded now.
>

Generally, a good idea! I like this commit of removing obsolete checks
in checkpatch. Can you identify more checks in checkpatch that are
potentially obsolete and share them with us?

I assume:
If you run checkpatch on the whole latest kernel tree and you run
checkpatch on the last 50,000 commits or so, all checks that were
never triggered on those evaluations are potentially obsolete. I
assume that only a handful of checks would qualify for that criteria,
and then we could dig deeper into the history of those checks and see
if they still serve a potential purpose or can be removed.

If you need a powerful server to run such checkpatch evaluations, just
let me know.

Just on the wording of your commit message:

The first sentence reads very strange, because you are just repeating
the commit message. So, you can probably just combine the first two
sentences and make it much shorter:

Since commit ..., the check in checkpatch for __dev* markings is obsolete.

Remove this obsolete check.

Lukas


> So remove __dev* section markers check from checkpatch.
>
> Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
> ---
>  scripts/checkpatch.pl | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 461d4221e4a4..e29c0961b25e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4023,12 +4023,6 @@ sub process {
>                              "CVS style keyword markers, these will _not_ be updated\n". $herecurr);
>                 }
>
> -# check for old HOTPLUG __dev<foo> section markings
> -               if ($line =~ /\b(__dev(init|exit)(data|const|))\b/) {
> -                       WARN("HOTPLUG_SECTION",
> -                            "Using $1 is unnecessary\n" . $herecurr);
> -               }
> -
>  # Check for potential 'bare' types
>                 my ($stat, $cond, $line_nr_next, $remain_next, $off_next,
>                     $realline_next);
> --
> 2.28.0
>