Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4 08/12] power: supply: smb347-charger: Remove caching of
 charger state
To:     Sebastian Reichel <sebastian.reichel@collabora.com>
Cc:     Thierry Reding <treding@nvidia.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Peter Chen <peter.chen@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Felipe Balbi <balbi@kernel.org>,
        David Heidelberg <david@ixit.cz>, devicetree@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
References: <20210717121112.3248-1-digetx@gmail.com>
 <20210717121112.3248-9-digetx@gmail.com>
 <20210717162006.66cqkbw2mertd6tr@earth.universe>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <0df9fbf5-26fa-5d35-46d6-5c36567d6ed2@gmail.com>
Date:   Sat, 17 Jul 2021 20:29:32 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210717162006.66cqkbw2mertd6tr@earth.universe>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

17.07.2021 19:20, Sebastian Reichel пишет:
> Hi,
> 
> On Sat, Jul 17, 2021 at 03:11:08PM +0300, Dmitry Osipenko wrote:
>> Regmap already provides us with the caching, so remove caching of charger
>> state to make code cleaner.
> 
> cache_type is not initialized in smb347's regmap config and thus
> set to 0 = REGCACHE_NONE:
> 
> static const struct regmap_config smb347_regmap = {
> 	.reg_bits	= 8,
> 	.val_bits	= 8,
> 	.max_register	= SMB347_MAX_REGISTER,
> 	.volatile_reg	= smb347_volatile_reg,
> 	.readable_reg	= smb347_readable_reg,
> };

Good catch, thank you. I'll add patch to enable caching.