Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210714042349.219199-1-masahiroy@kernel.org>
In-Reply-To: <20210714042349.219199-1-masahiroy@kernel.org>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Sun, 18 Jul 2021 22:22:28 +0900
Message-ID: <CAK7LNAS6NgAL7XQ4Hr5n+BFv8bkFiY1ttMj_p9kBXVi_MCxWsg@mail.gmail.com>
Subject: Re: [PATCH] kbuild: do not suppress Kconfig prompts for silent build
To:     Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Cc:     Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
        Michal Marek <michal.lkml@markovi.net>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jul 14, 2021 at 1:24 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> When a new CONFIG option is available, Kbuild shows a prompt to get
> the user input.
>
>   $ make
>   [ snip ]
>   Core Scheduling for SMT (SCHED_CORE) [N/y/?] (NEW)
>
> This is the only interactive place during the build process.
>
> Commit 174a1dcc9642 ("kbuild: sink stdout from cmd for silent build")
> suppressed Kconfig prompts as well because syncconfig is invoked by
> the 'cmd' macro. You cannot notice the fact that Kconfig is waiting
> for the user input.
>
> Use 'kecho' to show the equivalent short log without suppressing stdout
> from sub-make.
>
> Fixes: 174a1dcc9642 ("kbuild: sink stdout from cmd for silent build")
> Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---

Applied to linux-kbuild.


>  Makefile | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index c3f9bd191b89..6272126abe23 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -728,11 +728,9 @@ $(KCONFIG_CONFIG):
>  # This exploits the 'multi-target pattern rule' trick.
>  # The syncconfig should be executed only once to make all the targets.
>  # (Note: use the grouped target '&:' when we bump to GNU Make 4.3)
> -quiet_cmd_syncconfig = SYNC    $@
> -      cmd_syncconfig = $(MAKE) -f $(srctree)/Makefile syncconfig
> -
>  %/config/auto.conf %/config/auto.conf.cmd %/generated/autoconf.h: $(KCONFIG_CONFIG)
> -       +$(call cmd,syncconfig)
> +       $(Q)$(kecho) "  SYNC    $@"
> +       $(Q)$(MAKE) -f $(srctree)/Makefile syncconfig
>  else # !may-sync-config
>  # External modules and some install targets need include/generated/autoconf.h
>  # and include/config/auto.conf but do not care if they are up-to-date.
> --
> 2.27.0
>


-- 
Best Regards
Masahiro Yamada