Date: Mon, 20 Nov 2006 16:39:46 +0100
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Greg KH <greg@kroah.com>, linux-kernel <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@osdl.org>,
       Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [Patch -mm 1/1] driver core: Introduce device_move(): move a
 device to a new parent.
Message-ID: <20061120163946.38c878d7@gondolin.boeblingen.de.ibm.com>
In-Reply-To: <1164032103.5541.12.camel@min.off.vrfy.org>
References: <20061116154210.217f2e04@gondolin.boeblingen.de.ibm.com>
	<1163695657.7900.9.camel@min.off.vrfy.org>
	<20061117042338.GA11131@kroah.com>
	<20061120090537.6d59dbc5@gondolin.boeblingen.de.ibm.com>
	<20061120135515.38298bf5@gondolin.boeblingen.de.ibm.com>
	<1164032103.5541.12.camel@min.off.vrfy.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1287
Lines: 41

On Mon, 20 Nov 2006 15:15:03 +0100,
Kay Sievers <kay.sievers@vrfy.org> wrote:

> > +void kobject_uevent_env(struct kobject *kobj, enum kobject_action action,
> > +			int num_envp, char *envp[])
> 
> We usually use a NULL terminated array for things like this. Does
> passing the number of entries give us an advantage?

In do_kobject_uevent:

  envp = kzalloc((NUM_ENVP + num_envp) * sizeof (char *), GFP_KERNEL);

We would either need to allocate (NUM_ENVP + NUM_EXT_ENVP) or NUM_ENVP
(as before).
 
> > +{
> > +	/* Disallow dumb users. */
> > +	if (num_envp > NUM_EXT_ENVP)
> > +		return;
> 
> Why do we need such a limit? There are still thousand other ways to
> screw things up. :)

If we removed this, we could also use only NUM_ENVP in the allocation
above and kill NUM_EXT_ENVP. Hm.

> And kobject_uevent() can just call kobject_uevent_env(), there is no
> need for the indirection with do_*, right?

OK, may look nicer. I'll respin.

-- 
Cornelia Huck
Linux for zSeries Developer
Tel.: +49-7031-16-4837, Mail: cornelia.huck@de.ibm.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/