Date: Mon, 20 Nov 2006 15:47:29 +0000
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: first proposal for pci resume quirk interface
Message-ID: <20061120154729.45003599@localhost.localdomain>
In-Reply-To: <20061120152041.GA4199@ucw.cz>
References: <20061114175510.6e7c7119@localhost.localdomain>
	<20061120152041.GA4199@ucw.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1020
Lines: 28

On Mon, 20 Nov 2006 15:20:41 +0000
Pavel Machek <pavel@ucw.cz> wrote:

> Hi!
> 
> Looks okay to me.
> 
> 
> >  #define DECLARE_PCI_FIXUP_ENABLE(vendor, device, hook)			\
> >  	DECLARE_PCI_FIXUP_SECTION(.pci_fixup_enable,			\
> >  			vendor##device##hook, vendor, device, hook)
> > +#define DECLARE_PCI_FIXUP_RESUME(vendor, device, hook)			\
> > +	DECLARE_PCI_FIXUP_SECTION(.pci_fixup_resume,			\
> > +			resume##vendor##device##hook, vendor, device, hook)
> 
> Maybe having DECLARE_PCI_FIXUP_ALWAYS (meaning ENABLE+RESUME)  would reduce the code
> duplication?

There is almost no duplication if you actually look at the output of the
code. It simply generates entries into two jump/match tables. Doing a
PCI_FIXUP for both is ugly because of the ordering requirements.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/