Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3196727pxv; Sun, 18 Jul 2021 14:30:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwJF1TFaNT865rAz2jX10K8LIBtKQ0QSjTq8eAu2HZM6MMTob3X3X+bLDUWC/fX7BLQO6o X-Received: by 2002:a5d:8986:: with SMTP id m6mr16002156iol.87.1626643819731; Sun, 18 Jul 2021 14:30:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626643819; cv=none; d=google.com; s=arc-20160816; b=kcK5Myx6tVRgv78ca9c+bkgW8bJRFaqcg+QGlspATxcz9AMXtYcNLfHUMlsmkpBC35 In/wRJqZz1iQYywqOolxaa5KpGi5JYaTnB72+xwrEkFkLA1AtDuEL9/BoQ/F3Ex35bj1 lnTpPXCzFr8cSINP+wBcoG9DKK5jxRhqzpjjkefd4GFwF6zAeso7FsGb06SBchuZGneu gFL45D1K9oI9QbnDAmwKE38t3BvzinZC4fzX+u7NTqdpU0Oq+rm9A33L3cTXZLErbvtY /1r3n35Z6zeb4M0LOXmqQQXDhsg7r5AbUTYooJdwYrl6i61pxAxawql9PiV58zG7slZb eR1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RDmZbfk4umt1NTgReOWa0nlo9wbj8HPSJ0b72AWtHlI=; b=VqwkLEcLZb1ro3ZifANXi5VCYZ4FKVQYHnGBW+urktDm4kBx5pcTZAgiWTbzCXnjtN kutxF1NG/U0xb2hDuVxutzCNFeHfrpWjfmInI1IfiKDafkRk8krSMOKJ60MG9IC4RRsD KYjPCbZT9oJ7Hn1daE86u0JkAbuUgclym57CtrS1Tum2R9WnAVAupVmfOAubcoQ3gS6x Wr5ay/xqJa7gF7f9C5mEMV+SAzI6IUJS7fyvybBMtItT8rZddMSPG5oJPV3A0h+dvjTw wTObAF8yVoQ5mW70GCQdEe6o4HmTxOOnJyFrl+OWEfVzQR/l45SpJWe5A1GW3Sfixhjc puzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=m3X+8h5s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r18si18096327ile.92.2021.07.18.14.30.08; Sun, 18 Jul 2021 14:30:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=m3X+8h5s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233298AbhGRVbP (ORCPT + 99 others); Sun, 18 Jul 2021 17:31:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233231AbhGRVbM (ORCPT ); Sun, 18 Jul 2021 17:31:12 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01432C061764 for ; Sun, 18 Jul 2021 14:28:13 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id l11so7760775ljq.4 for ; Sun, 18 Jul 2021 14:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RDmZbfk4umt1NTgReOWa0nlo9wbj8HPSJ0b72AWtHlI=; b=m3X+8h5sNcmib/Jzd1hwMXGfSUSimXJ8rCCYFjWXgqdSTHMLURCciTa1Gkf8rtY8gF IncY0rxbJp7diuFaM+sFO05fUn4c92aIEMDVyrXI8pBY4anM35msGOlHF0MDM4G62Dk2 FhjzD5Th/XMP9NIJnqKS/cWnewOk8N41dGlkiPqK/TQK+uGp9PoN7en3TFzuESVIRDVe kr2/rVucVrHylll2n8fEOui5IgqOAIj4yZKDt0w5Td30AqPv6TC7MY5vZrLeh82nYqP9 3pq3j/JTjz9QWloFIbVWejNWh2rAHLrHh4gy2ZCayJtoD1AYG6AVo/w29miAlO0N3kz/ cokg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RDmZbfk4umt1NTgReOWa0nlo9wbj8HPSJ0b72AWtHlI=; b=oC+MdJKK/QNq7mnCF4urJ2spf1yYkDmJaKeWWhoWrKpMuHBuvHCDIf3FdQZ2vL1dj3 Fp4nlNDxhg6FazjnjN+k6zhf9I/wOdqlCbJNsiu/GrOagwXihyAo4LlPbJ5aztXAK3dj aIKRnxiGxRsncKAQ0hj1Ye9oIcbzBQIBJU4icy5puVzns1ydqPMVBqtUblQ+QZdNH/xk ssUsmU+5dvih4oFIYydaUZiMj7A5tqv82yZ/VMcByBq6w+pIWNDrRua0UCLaTly+cZK3 ZjEX4UL+ouwAvmtytRdjFGjzLcWHGA5zBk+v8xu8XgjWvhp1AzH2c5EPf/k0RrKGoYsr b6xQ== X-Gm-Message-State: AOAM5326ikrXkgiAxWlEKTKrg001Femj+GEEFEHleL5vNqFkzZSMZq8B qJeyAPrebzSiTx6ChfBOUccBVw== X-Received: by 2002:a2e:3506:: with SMTP id z6mr20511573ljz.238.1626643691394; Sun, 18 Jul 2021 14:28:11 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id z13sm1232704lfb.40.2021.07.18.14.28.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jul 2021 14:28:10 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 6C5B610260F; Mon, 19 Jul 2021 00:28:14 +0300 (+03) Date: Mon, 19 Jul 2021 00:28:14 +0300 From: "Kirill A. Shutemov" To: Qi Zheng Cc: akpm@linux-foundation.org, tglx@linutronix.de, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, songmuchun@bytedance.com Subject: Re: [PATCH 1/7] mm: fix the deadlock in finish_fault() Message-ID: <20210718212814.suvziikndiyezi6m@box.shutemov.name> References: <20210718043034.76431-1-zhengqi.arch@bytedance.com> <20210718043034.76431-2-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210718043034.76431-2-zhengqi.arch@bytedance.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 18, 2021 at 12:30:27PM +0800, Qi Zheng wrote: > The commit 63f3655f9501(mm, memcg: fix reclaim deadlock with writeback) > fix a deadlock bug by pre-allocating the pte page table outside of the > page lock, the commit f9ce0be71d1f(mm: Cleanup faultaround and > finish_fault() codepaths) rework the relevant code but ignore this race, > fix it. > > Fixes: f9ce0be71d1f(mm: Cleanup faultaround and finish_fault() codepaths) > Signed-off-by: Qi Zheng Acked-by: Kirill A. Shutemov and add stable@, please. -- Kirill A. Shutemov