Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 18 Jul 2021 23:38:48 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 5/5] perf tools: Add pipe_test.sh to verify pipe
 operations
Message-ID: <YPSfaEIKydevKLpi@krava>
References: <20210714003442.1111502-1-namhyung@kernel.org>
 <20210714003442.1111502-6-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210714003442.1111502-6-namhyung@kernel.org>
Precedence: bulk

On Tue, Jul 13, 2021 at 05:34:42PM -0700, Namhyung Kim wrote:

SNIP

> diff --git a/tools/perf/tests/shell/pipe_test.sh b/tools/perf/tests/shell/pipe_test.sh
> new file mode 100755
> index 000000000000..b6a89c6896c3
> --- /dev/null
> +++ b/tools/perf/tests/shell/pipe_test.sh
> @@ -0,0 +1,69 @@
> +#!/bin/sh
> +# perf pipe recording and injection test
> +# SPDX-License-Identifier: GPL-2.0
> +
> +# skip if there's no compiler
> +if ! [ -x "$(command -v cc)" ]; then
> +	echo "failed: no compiler, install gcc"
> +	exit 2
> +fi
> +
> +file=$(mktemp /tmp/test.file.XXXXXX)
> +data=$(mktemp /tmp/perf.data.XXXXXX)
> +
> +cat <<EOF | cc -o ${file} -x c -
> +#include <signal.h>
> +#include <stdlib.h>
> +#include <unistd.h>
> +
> +volatile int done;
> +
> +void sigalrm(int sig) {
> +	done = 1;
> +}
> +
> +__attribute__((noinline)) void noploop(void) {
> +	while (!done)
> +		continue;
> +}
> +
> +int main(int argc, char *argv[]) {
> +	int sec = 1;
> +
> +	if (argc > 1)
> +		sec = atoi(argv[1]);
> +
> +	signal(SIGALRM, sigalrm);
> +	alarm(sec);
> +
> +	noploop();
> +	return 0;
> +}
> +EOF
> +
> +
> +if ! perf record -e cycles:u -o - ${file} | perf report -i - --task | grep test.file; then

hi,
cycles:u will fail in virtual machine, could you use
cpu-clock instead or skip the test?

jirka

> +	echo "cannot find the test file in the perf report"
> +	exit 1
> +fi
> +
> +if ! perf record -e cycles:u -o - ${file} | perf inject -b | perf report -i - | grep noploop; then
> +	echo "cannot find noploop function in pipe #1"
> +	exit 1
> +fi
> +
> +perf record -e cycles:u -o - ${file} | perf inject -b -o ${data}
> +if ! perf report -i ${data} | grep noploop; then
> +	echo "cannot find noploop function in pipe #2"
> +	exit 1
> +fi
> +
> +perf record -e cycles:u -o ${data} ${file}
> +if ! perf inject -b -i ${data} | perf report -i - | grep noploop; then
> +	echo "cannot find noploop function in pipe #3"
> +	exit 1
> +fi
> +
> +
> +rm -f ${file} ${data} ${data}.old
> +exit 0
> -- 
> 2.32.0.93.g670b81a890-goog
>