Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3227718pxv; Sun, 18 Jul 2021 15:41:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQiP8q7gVZmnfzM9BxzpLnC0tpBLwuyoJCsPt+13MhUwBLbqc/kkS7j+QkFDP3ohUqsbUa X-Received: by 2002:a17:906:40a:: with SMTP id d10mr23778788eja.491.1626648068446; Sun, 18 Jul 2021 15:41:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626648068; cv=none; d=google.com; s=arc-20160816; b=eqhZX3/7Um16QbZ3NkXmMGcys59bYcEFV+FLkij/ylphQAiOClOoAozdPhSyWCOz9l 2ckeroJnbk7HRcJvB0zCuNvApqODE5yMckDAIkj1jWzzPUYRWjKzOhzXiq+MCOar6ntv RRi8TvdoSfHaODNRIra7glDdi5j/AVhFcB2DD17Szd+n8Ki6kwiUsyrreB5Hn+LtuoDd AxVYdp/3UYj32VotRCCtgOj+fF8pZQffxrdRb8HLHNIZytyNurBkEtvCQ8NA5rMkldtm wanhPOFLtdnnkjvDEUwSVDMCJXqcoAmlfM41EqoPwm4Yv+X4DjqnQ3bJNu1UAYwlLER7 BYgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Xw04fnowKtYXTdFS14xZoGGNfz6dHcqSTKXhXZyTGCQ=; b=rYFcNQ6WuxkCr8earWdahsyNLROvML20dp0NtVTLz8WV4idYw7Bys9RJ9mnWRD7Dox X945LwC1SmZ3t5tmmHfs31hOsD8ob3tu8EmAf9Xnz3lWr/oV96i/ay0JcOftELecJ1ct nthLG+NyvDOQWcZzg/XGAtGO4QjLnE5/K4KsxKhudJlX+WR+31jlwSqkvZ/wLs9TL80W GfEueKWbdUKTNmqU60LfHvInlv4B/2Z1YTHaimTCQikRCJCatcKxiT2FEMjV0Jxr6wGy ix77aZB9V1lXyQ6taZuSSGfT/hGwC0Bc84iWnJsX5G1YZTOkxeCwUliKUNKpS81mbfyl Brkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TNNL4X0W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q1si173470ejn.480.2021.07.18.15.40.46; Sun, 18 Jul 2021 15:41:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TNNL4X0W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233532AbhGRWmt (ORCPT + 99 others); Sun, 18 Jul 2021 18:42:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59255 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232582AbhGRWmp (ORCPT ); Sun, 18 Jul 2021 18:42:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626647985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Xw04fnowKtYXTdFS14xZoGGNfz6dHcqSTKXhXZyTGCQ=; b=TNNL4X0WojSlKlZSeTM22tzPO5jt0Nbwf8FMVLgj1OOsO3HkBBlaGAqTl4qhd0B3+igFwH vQ6Vh31k/1WsN98XzjqKKJSfMs7SrWKWcYMvJLc8s0Z0bdGH5NNYHP3q/+QXWyjtHf8OrI OQkiGjsRis9/sB3UIUlzXvlwfFUQs2A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-39-IWr29uZINSe0b-sNmwXLkw-1; Sun, 18 Jul 2021 18:39:42 -0400 X-MC-Unique: IWr29uZINSe0b-sNmwXLkw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8D984100C609; Sun, 18 Jul 2021 22:39:40 +0000 (UTC) Received: from max.com (unknown [10.40.195.75]) by smtp.corp.redhat.com (Postfix) with ESMTP id D8BC460C0F; Sun, 18 Jul 2021 22:39:34 +0000 (UTC) From: Andreas Gruenbacher To: Linus Torvalds Cc: Alexander Viro , Jan Kara , Matthew Wilcox , Christoph Hellwig , cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, Andreas Gruenbacher Subject: [PATCH v2 0/6] gfs2: Fix mmap + page fault deadlocks Date: Mon, 19 Jul 2021 00:39:26 +0200 Message-Id: <20210718223932.2703330-1-agruenba@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus et al., here's an update to the gfs2 mmap + page faults fix that implements Linus's suggestion of disabling page faults while we're holding the inode glock. This passes fstests except for test generic/095, which fails due to an independent bug in the iov_iter code. I'm currently trying to get initial feedback from Al and Christoph on that. Any feedback would be welcome. Thanks a lot, Andreas Andreas Gruenbacher (6): iov_iter: Introduce fault_in_iov_iter helper iomap: Fix iomap_dio_rw return value for page faults gfs2: Add wrapper for iomap_file_buffered_write gfs2: Fix mmap + page fault deadlocks for buffered I/O iov_iter: Introduce ITER_FLAG_FAST_ONLY flag gfs2: Fix mmap + page fault deadlocks for direct I/O fs/gfs2/file.c | 79 ++++++++++++++++++++++++++++++++++++++++---- fs/iomap/direct-io.c | 2 ++ include/linux/mm.h | 3 ++ include/linux/uio.h | 16 +++++++-- lib/iov_iter.c | 62 +++++++++++++++++++++++++++++++--- mm/gup.c | 68 ++++++++++++++++++++++++++++++++++++++ 6 files changed, 215 insertions(+), 15 deletions(-) -- 2.26.3