Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3232220pxv; Sun, 18 Jul 2021 15:53:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwLfp27JU3Rf+lM7V05J0DHHOfgGxhRQfCNFveunsGXZtl+Le4rpB9mfmBXwi/rnalHaVH X-Received: by 2002:a17:906:af91:: with SMTP id mj17mr24437091ejb.76.1626648830525; Sun, 18 Jul 2021 15:53:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626648830; cv=none; d=google.com; s=arc-20160816; b=oF3kUGSsrbVK90wp+A8LrdYAFDWDlslxDHD3/DZ0+/loeWJev6GER2kmZH4E6tuQo7 491rRN+8zSr9wq8cUpvNmKB5PHOTB/QS3DrYlR9PBj7QbNXMLYeq/M8Uj+2hBcJj+0Rk NdbM3N4pC3aY+ss5QzH/kvX5egisaJ/bJkiRQhRFBeOnjN+Nsfeb5+57wGAv80BfhIZ6 RWGzan+XhDTGrPbg6WtvfVGVMrV8HrDRvSiFG7EKHhke25JFa5tvg78/XH0/0zvzwTJB ijxCpWTTpb5BVWTNqhBSgJ49ksGH+YCm3ZMR5jBm2RoaAQ6OH47XZl1qxyGNx8c6nduO H6Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RHSK5EGB6FHr3oxPvJZpzufbw3Ms9NA52kVasTcg4p4=; b=oL1ATFK3cScQKW+eq8fjHCl3lclaPfjKap81cqgRq6Ows906QglDl4k8IOR7kWnQTL cyqzTbllIQTbhVaJPnQwiOlZG3yD2bSr9YqszyJ7RRCwFSdT4HrDcg0yBhiEGNHKVKbi X9kNTsG2rGoEJYaJXsOrNio0W5I6Qepr0SWT768PXTeC7j2fCpEA4/BupivIr9jjAlVP RyJVx1OcTojBhxEZGBCKlTLlbNK8rDcAhJLVkUWID0uquGObQXsQVvwyJCswPBcBaCwm VUUMj/e1C9MPRPWFji3s5TELHy9QHxMFlW1c2jZ/Z5bQZzHZn31bxbPJ8EkBZavL8xIA UvRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=EO8B14wp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lh26si18693000ejb.187.2021.07.18.15.53.27; Sun, 18 Jul 2021 15:53:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=EO8B14wp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233379AbhGRWza (ORCPT + 99 others); Sun, 18 Jul 2021 18:55:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231846AbhGRWz3 (ORCPT ); Sun, 18 Jul 2021 18:55:29 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCF2BC061762; Sun, 18 Jul 2021 15:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RHSK5EGB6FHr3oxPvJZpzufbw3Ms9NA52kVasTcg4p4=; b=EO8B14wpWTQwqTdTHNRIsPGLqT wOvfRyDsX9UOviGYwZ6BLIZSOb8CNAH48qsNPi0CRJ6xSG9tFMXwvUCP3tM3OEK2nQvhOArtaBSfE bXaA5NbN5MMB/fpIg1U7PR4ROUcddLqQa5S9BKCm0ibaKVzDluRcku6kRN5Dk+pF2ksqzAFAAxU2b H/FePW411Q6kY2HM9g8JIVC6oD3kfulR9lETb8rwxMswGtNvjxDxFWTWyASrLxZi0KZjN4m0B9LPf 6P7FfzVWDYjvBOlG/ZWNOFdyMVJDTz0tx0KYghGMOprXcwYI96BFG97OYG17pLT87GvlOJ09Ko38/ WlThaU3w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5FdI-006MEM-As; Sun, 18 Jul 2021 22:51:56 +0000 Date: Sun, 18 Jul 2021 23:51:36 +0100 From: Matthew Wilcox To: "Paul E. McKenney" Cc: Oleksandr Natalenko , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Chris Clayton , Chris Rankin , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , rcu@vger.kernel.org, Andrew Morton , linux-mm@kvack.org Subject: Re: linux-5.13.2: warning from kernel/rcu/tree_plugin.h:359 Message-ID: References: <2245518.LNIG0phfVR@natalenko.name> <6698965.kvI7vG0SvZ@natalenko.name> <20210718215914.GQ4397@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210718215914.GQ4397@paulmck-ThinkPad-P17-Gen-1> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 18, 2021 at 02:59:14PM -0700, Paul E. McKenney wrote: > > > https://lore.kernel.org/lkml/CAK2bqVK0Q9YcpakE7_Rc6nr-E4e2GnMOgi5jJj=_Eh_1k > > > EHLHA@mail.gmail.com/ > > But this one does show this warning in v5.12.17: > > WARN_ON_ONCE(!preempt && rcu_preempt_depth() > 0); > > This is in rcu_note_context_switch(), and could be caused by something > like a schedule() within an RCU read-side critical section. This would > of course be RCU-usage bugs, given that you are not permitted to block > within an RCU read-side critical section. > > I suggest checking the functions in the stack trace to see where the > rcu_read_lock() is hiding. CONFIG_PROVE_LOCKING might also be helpful. I'm not sure I see it in this stack trace. Is it possible that there's something taking the rcu read lock in an interrupt handler, then returning from the interrupt handler without releasing the rcu lock? Do we have debugging that would fire if somebody did this?