Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210717043159.12566-1-rdunlap@infradead.org>
In-Reply-To: <20210717043159.12566-1-rdunlap@infradead.org>
From:   Dongjiu Geng <gengdongjiu1@gmail.com>
Date:   Mon, 19 Jul 2021 10:55:36 +0800
Message-ID: <CABSBigROX2sYdcOOt=L45_hhdz9reff3t1rD-6M2vDLQ35LcOQ@mail.gmail.com>
Subject: Re: [PATCH] clk: hisilicon: hi3559a: select RESET_HISI
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
        Dongjiu Geng <gengdongjiu@huawei.com>,
        Stephen Boyd <sboyd@kernel.org>, stable@vger.kernel.org,
        linux-clk@vger.kernel.org,
        Michael Turquette <mturquette@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Randy Dunlap <rdunlap@infradead.org> =E4=BA=8E2021=E5=B9=B47=E6=9C=8817=E6=
=97=A5=E5=91=A8=E5=85=AD =E4=B8=8B=E5=8D=8812:34=E5=86=99=E9=81=93=EF=BC=9A
>
> The clk-hi3559a driver uses functions from reset.c so it should
> select RESET_HISI to avoid build errors.
>
> Fixes these build errors:
> aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi355=
9av100_crg_remove':
> clk-hi3559a.c:(.text+0x158): undefined reference to `hisi_reset_exit'
> aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi355=
9av100_crg_probe':
> clk-hi3559a.c:(.text+0x1f4): undefined reference to `hisi_reset_init'
> aarch64-linux-ld: clk-hi3559a.c:(.text+0x238): undefined reference to `hi=
si_reset_exit'
>
> Fixes: 6c81966107dc ("clk: hisilicon: Add clock driver for hi3559A SoC")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Dongjiu Geng <gengdongjiu@huawei.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: stable@vger.kernel.org
> Cc: linux-clk@vger.kernel.org
> Cc: Michael Turquette <mturquette@baylibre.com>
> ---
>  drivers/clk/hisilicon/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20210716.orig/drivers/clk/hisilicon/Kconfig
> +++ linux-next-20210716/drivers/clk/hisilicon/Kconfig
> @@ -18,6 +18,7 @@ config COMMON_CLK_HI3519
>  config COMMON_CLK_HI3559A
>         bool "Hi3559A Clock Driver"
>         depends on ARCH_HISI || COMPILE_TEST
> +       select RESET_HISI
>         default ARCH_HISI
>         help
>           Build the clock driver for hi3559a.

Reviewed-by: Dongjiu Geng <gengdongjiu1@gmail.com>