Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 19 Jul 2021 08:37:47 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Len Baker <len.baker@gmx.com>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Pavel Skripkin <paskripkin@gmail.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/rtl8712: Remove all strcpy() uses in favor of
 strscpy()
Message-ID: <20210719053747.GN1931@kadam>
References: <20210717155145.15041-1-len.baker@gmx.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210717155145.15041-1-len.baker@gmx.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (102.222.70.252) by JNAP275CA0033.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Mon, 19 Jul 2021 05:38:03 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 42c77fe7-b5d7-4dab-f345-08d94a77640e
X-MS-TrafficTypeDiagnostic: MWHPR1001MB2397:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR1001MB2397569E48FA02AD4D27DE1C8EE19@MWHPR1001MB2397.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: yt6P/vV1KWjzpLExoytEXIMuzo6yt6skLaWdvBuIiMiJiiP+AtADIASbziSliuzHalOKib6FFqOm2q8N+n1e8qnPWs/Ocv96RsSsqGelCijO8X5VdltW3fzR7pBaSr1hjzp2sAloI9Mvy4SHley6LFAc+ebaDqqaivP+rFdOGrp84nJAnUxNsTCKoA0PMVzc+eFFxiJpylj7FZ56ZmnZhrZFj6bbCzYI3p9Nz8tnis76Yq7RwhK5QuKLmbasP5jckrvzWYK0k0jlwWEawJGzZYA76OJA4FQUx70Bn1X3GEeoyVzYrCAlmX7UDp/o6skLntP9G3FByX3PotTEzahSWutbIGghVyz8KaNBAfPcFV4+Mkgm0yj/CaXEtx9jS6BE3jpfeuFhCwq6+chlSJ2LDxOHPRojmeQWYCuXnTroxiMLAePaOgfX+n/nMdO3wH8XhBvJccnX26stJFmcYM8Y51z4NHB8IjfKGNFClopa9edG8ObJQOwd/qAqha22HT3f8Cx7Sa0HWzRlFbVz5+uUS1NpY4RWuglS9xLI6P4ZFgdUPqmgs18c2eObxaFk8zBXEWz2WOP8ctJEJYSeC+xgSHRJin97V2i7qtI0fBDoeCsaV94+D3cSBlLo0IN7vecJX+0JcLX43epetPiJJ2tZyrO5h/oKMFW0cBxE6x6vNlWI6vTOe47v9uybiYheT/uA+gq5WcX4wCVrCKL/suzNgme49e+jqyEdnNtQa9VW2fE=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(136003)(39860400002)(376002)(366004)(346002)(5660300002)(9576002)(478600001)(52116002)(316002)(4326008)(6916009)(83380400001)(8936002)(9686003)(2906002)(66946007)(66476007)(55016002)(6666004)(86362001)(33656002)(8676002)(33716001)(26005)(1076003)(956004)(66556008)(44832011)(54906003)(186003)(38100700002)(6496006)(38350700002)(518174003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tx+0wdzpouWuz/QSkVa7dMxtNcwKWpD19zpZ3byec5UGBQxn6YdBiPMws49J?=
 =?us-ascii?Q?8cz+SJCV29yYV7ZQpJSjojxVvWI4jK37K3wY/xEPpgR+PfmSy7AFby9pNIbI?=
 =?us-ascii?Q?LfrRsBrOFlLlo54wb4qZ7ar1zt7w9rE6QTm6THvtbKAEwxd6KMqtgcD1a6sC?=
 =?us-ascii?Q?bxLrxaHDn+O6OcE8jLRtq5fsGKw1+OigtAqWLZ/sGMwEMQ4ggypnEGrEuUuq?=
 =?us-ascii?Q?1pk+/VoYlRvPlPJpuDgxUz6FHwNarw0QzPe10hEauPACo18cPyDNdgKu43tG?=
 =?us-ascii?Q?sONPo7P8jd989RLjhu3WenntucEutIjAylJxysVy0czlYLrZ0pzM3IejlJ88?=
 =?us-ascii?Q?XbDwvapyJGisN5gQ4/tOlUYbq9GTsM2UrElfx9LwmCiaIkt7Fw4GFDnkEdtm?=
 =?us-ascii?Q?3RNx3BXsYbAWofOeszAKeq6OskdElcd6GkqcQOTQCpouFjaOEuIh0N2R5ch6?=
 =?us-ascii?Q?NuQebLLp0VAE0WvzbmDn0kQprrZaw7kFUs29zAqd2qsk16hKc0gk9pfUYjr5?=
 =?us-ascii?Q?VQPFX7NOqM35EruriVYVOGEdhHR6okHH6rCAfuyk8JR41IMjwqbGhcg+wmWk?=
 =?us-ascii?Q?XXnXVOSfEDKrbzASFteBuQ1OD+FrsyKrSv/64yoqw3FUcmYae2g2Fj5fWTfY?=
 =?us-ascii?Q?neSx0jp3uZb4qMH+hAtPnwEN9icCHN4CzOMwJLzDKp64Rj+TKw/nDFDoLpTA?=
 =?us-ascii?Q?+PJJkBuZz/8dd4QHO63LgwBJvH9CGci/8FlDgTg9PBGwLhxxuxRKztTFvwDX?=
 =?us-ascii?Q?M5C33VXbfpCr49j30nYgFyhzcfHjRUIoThXk9WOn/kPrU+GaUuNZSNYHrIDx?=
 =?us-ascii?Q?HWPQquV87EGsML/LIjB2Hrh8ow+6QZidCO3volLE0mYp6wSq6tHeXuW3cm+z?=
 =?us-ascii?Q?/Do7qX02C76HfUkZawMueafJxY8iX2hM2K1bk5KXBOwXFrYNt4RrCx1szHBm?=
 =?us-ascii?Q?bkoTf3qV5dpf9Sw5avW43ZFDAhqrM2lO0NSndZxO7KNLPARvRcgRMae76ti6?=
 =?us-ascii?Q?z4JJu5aHqdoeuoli/Y7nVS/t1DWxxjncPpLsyoSPgVDZUwriN0hjXn7rHKAN?=
 =?us-ascii?Q?MGzw7T3Lv0gtj3ZBKHEjUMWHVKDeWBtPtInHlOUCPFbAdXJuaU8XSRwArn5c?=
 =?us-ascii?Q?lbF3iCUPsKPnczjytnHQsz9SZ/a3XwZ2b4MhuprGQ9ySL+W3NXWom+/ZRfnb?=
 =?us-ascii?Q?skvEWQH/eX67neQ9BLY71xC8R36VZ4d9sJEWaLasbX+G/X2a8QsuhNM2QkWx?=
 =?us-ascii?Q?T+RUIQ8TEagFQcuH6cMJkLfNcfITl4/CHjFo0143zcuMCNImj3MWLbNQNOkA?=
 =?us-ascii?Q?0rEykI24g0httAXM7jFiQ9Ce?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42c77fe7-b5d7-4dab-f345-08d94a77640e
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2021 05:38:09.4288
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /SE2O81vTtpOtJBIeVDzeHEOlKJejmya/Xj2h2aU2Uh7/4i32zJKlaTtcX/Q9yqDHI9Bj/vf6YJRq5mdMt4MVQA+oFOrdxpTTXTI9fijFXw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2397
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10049 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0
 mlxlogscore=999 suspectscore=0 bulkscore=0 spamscore=0 phishscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2107190032
X-Proofpoint-ORIG-GUID: QwQoNHk696k_X9Ln3JY-lO-9QO5HSxZy
X-Proofpoint-GUID: QwQoNHk696k_X9Ln3JY-lO-9QO5HSxZy
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jul 17, 2021 at 05:51:45PM +0200, Len Baker wrote:
> strcpy() performs no bounds checking on the destination buffer. This
> could result in linear overflows beyond the end of the buffer, leading
> to all kinds of misbehaviors. The safe replacement is strscpy().
> 
> Signed-off-by: Len Baker <len.baker@gmx.com>
> ---
>  drivers/staging/rtl8712/os_intfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
> index 2214aca09730..9502f6aa5306 100644
> --- a/drivers/staging/rtl8712/os_intfs.c
> +++ b/drivers/staging/rtl8712/os_intfs.c
> @@ -203,7 +203,7 @@ struct net_device *r8712_init_netdev(void)
>  	if (!pnetdev)
>  		return NULL;
>  	if (dev_alloc_name(pnetdev, ifname) < 0) {
> -		strcpy(ifname, "wlan%d");
> +		strscpy(ifname, "wlan%d", sizeof(ifname));
>  		dev_alloc_name(pnetdev, ifname);

Not related to your patch but this code is bad.  What it does is the
"ifname" can be set as a module parameter.  So instead of testing if it
has been set, it uses the checking inside dev_alloc_name() to see if we
can allocate what the user requested.  If not then set it to "wlan%d".
If we cannot allocate what the user wants then we should return an
error.

It should do:

	if (ifname[0] == '\0')
		strscpy(ifname, "wlan%d", sizeof(ifname));

	ret = dev_alloc_name(pnetdev, ifname);
	if (ret < 0) {
		dev_err(pnetdev, "allocating device name failed.\n");
		return NULL;
	}

regards,
dan carpenter