Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3419207pxv; Sun, 18 Jul 2021 22:43:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzybL5dbl+0HMdBBIc/BREfoqHGM9IpVtWcsVXLLy0ye25NFclxQIULuqnfQ316ML6cgKOq X-Received: by 2002:a17:907:20ef:: with SMTP id rh15mr25758177ejb.369.1626673427828; Sun, 18 Jul 2021 22:43:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626673427; cv=none; d=google.com; s=arc-20160816; b=qPDutzgTEQAw0hnUqT4cEebf0ay16/KHwvevWKdEdOzNfVNSvrBlK75M2yaR3ZP4y+ DEXYW35+2TZFD1hVkoGXjI636HI/LJ3ZNlmaLRDP9cZXMRuHa5fqf2Oz2AUOdxlD0FQ8 Jzdr2Jsd0YUMF7BDlYQo45yVmkN/E4LuxV+tO0NIH856hDN0ALbOGAMuN/YSWZHkslM6 A16+x656slNPVRfduwQZ2HgETEKmkEZkl61OSeeHjCmeDZlkBZn9OLdhTuKVgxhszjRy BGHkF9EjzRGYolbzb0NYb2Hksv0AQ9M0CInBUnZ9QA1jY+3X/S894Vcn/Pe4NB7Rd+zZ lKPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=k8vrwGfi4buaNEKiEDx9yVcWKxB1hoROC6N2FWsbEvQ=; b=GSppL8inu+ou+tluTXU3sqRH8fqTuBTh7S1QL3e76Wq6vOwB4W+I/aqLi087w6uHw5 EBSG1F9tYGlHDAgwLEfG5WqhI6+2Vcsj8DAzvMO7Z8vJNEP5rFGojoYFCSrSDuTG2dLh cNd2VxbVgXBcWnHdejsVFxWvu5j67cfJqxhk8Ew9HCxSJg0J8mNczfss6r3UsKtTxJ1I 6qxfsR8knFf7vo73Y/sGXoSqKwpS6eMDS/KtXdue03mKVmP9Xehj3/7IGhtXyLHP8H8d xIyNifM6E/88kHn3PDtR3vLTdw299/5e3z0pa4a+pJgBjmrV/wUYgIaKoAnaQToBfArV UIzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CsI7TQ8Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d15si21229477ejc.258.2021.07.18.22.43.25; Sun, 18 Jul 2021 22:43:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CsI7TQ8Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233348AbhGSFo3 (ORCPT + 99 others); Mon, 19 Jul 2021 01:44:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:28791 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229777AbhGSFo2 (ORCPT ); Mon, 19 Jul 2021 01:44:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626673289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=k8vrwGfi4buaNEKiEDx9yVcWKxB1hoROC6N2FWsbEvQ=; b=CsI7TQ8Zrq/e4jO69rKVEX1ahOWGXdSz/XUkoBxGLu+LXyTAFM8/3DiTtThyalX0l0BBbL PQDZCRkY+C+e651OlMmRPv7BkTx3yp2hDKLquEuXXMZU1h2Fmm7TXQbLiQON34VxCzJ2/y IeXEQFLo0r8FCkqitpwFV56UORZ1s9c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-480-t-2HJhyMM0SvCUaAJKJ_3w-1; Mon, 19 Jul 2021 01:41:27 -0400 X-MC-Unique: t-2HJhyMM0SvCUaAJKJ_3w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A1648362F8; Mon, 19 Jul 2021 05:41:26 +0000 (UTC) Received: from gshan.redhat.com (vpn2-54-195.bne.redhat.com [10.64.54.195]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D5E4869CB4; Mon, 19 Jul 2021 05:41:23 +0000 (UTC) From: Gavin Shan To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, anshuman.khandual@arm.com, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, chuhu@redhat.com, shan.gavin@gmail.com Subject: [PATCH v2 00/12] mm/debug_vm_pgtable: Enhancements Date: Mon, 19 Jul 2021 13:41:26 +0800 Message-Id: <20210719054138.198373-1-gshan@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are couple of issues with current implementations and this series tries to resolve the issues: (a) All needed information are scattered in variables, passed to various test functions. The code is organized in pretty much relaxed fashion. (b) The page isn't allocated from buddy during page table entry modifying tests. The page can be invalid, conflicting to the implementations of set_xxx_at() on ARM64. The target page is accessed so that the iCache can be flushed when execution permission is given on ARM64. Besides, the target page can be unmapped and access to it causes kernel crash. "struct pgtable_debug_args" is introduced to address issue (a). For issue (b), the used page is allocated from buddy in page table entry modifying tests. The corresponding tets will be skipped if we fail to allocate the (huge) page. For other test cases, the original page around to kernel symbol (@start_kernel) is still used. The patches are organized as below. PATCH[2-10] could be combined to one patch, but it will make the review harder: PATCH[1] introduces "struct pgtable_debug_args" as place holder of all needed information. With it, the old and new implementation can coexist. PATCH[2-10] uses "struct pgtable_debug_args" in various test functions. PATCH[11] removes the old implementation. PATCH[12] fixes the issue of corrupted page flag for ARM64 Changelog ========= v2: * Rename struct vm_pgtable_debug to struct pgtable_debug_args. The parameter name to various test functions are renamed to "@args" (Anshuman) * Code changes as suggested by Anshuman (Anshuman) Gavin Shan (12): mm/debug_vm_pgtable: Introduce struct pgtable_debug_args mm/debug_vm_pgtable: Use struct pgtable_debug_args in basic tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in leaf and savewrite tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in protnone and devmap tests mm/vm_debug_pgtable: Use struct pgtable_debug_args in soft_dirty and swap tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in migration and thp tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in PTE modifying tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in PMD mm/vm_debug_pgtable: Use struct pgtable_debug_args in PUD modifying tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in PGD and P4D modifying tests mm/debug_vm_pgtable: Remove unused code mm/debug_vm_pgtable: Fix corrupted page flag mm/debug_vm_pgtable.c | 849 ++++++++++++++++++++++++------------------ 1 file changed, 479 insertions(+), 370 deletions(-) -- 2.23.0