Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Oleksandr Natalenko <oleksandr@natalenko.name>
To:     Ming Lei <ming.lei@redhat.com>
Cc:     linux-kernel@vger.kernel.org, Jens Axboe <axboe@fb.com>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        linux-nvme@lists.infradead.org,
        David Jeffery <djeffery@redhat.com>,
        Laurence Oberman <loberman@redhat.com>,
        Paolo Valente <paolo.valente@linaro.org>,
        Jan Kara <jack@suse.cz>, Sasha Levin <sashal@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Keith Busch <kbusch@kernel.org>
Subject: Re: New warning in nvme_setup_discard
Date:   Mon, 19 Jul 2021 08:27:29 +0200
Message-ID: <2407736.Le3fEKZpXq@natalenko.name>
In-Reply-To: <YPTYGD1zeae1x7Yp@T590>
References: <4729812.CpyZKHjjVO@natalenko.name> <3383530.3bVf3B8HMu@natalenko.name> <YPTYGD1zeae1x7Yp@T590>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hello.

On pond=C4=9Bl=C3=AD 19. =C4=8Dervence 2021 3:40:40 CEST Ming Lei wrote:
> On Sat, Jul 17, 2021 at 02:35:14PM +0200, Oleksandr Natalenko wrote:
> > On sobota 17. =C4=8Dervence 2021 14:19:59 CEST Oleksandr Natalenko wrot=
e:
> > > On sobota 17. =C4=8Dervence 2021 14:11:05 CEST Oleksandr Natalenko wr=
ote:
> > > > On sobota 17. =C4=8Dervence 2021 11:35:32 CEST Ming Lei wrote:
> > > > > Maybe you need to check if the build is OK, I can't reproduce it =
in
> > > > > my
> > > > > VM, and BFQ is still builtin:
> > > > >=20
> > > > > [root@ktest-01 ~]# uname -a
> > > > > Linux ktest-01 5.14.0-rc1+ #52 SMP Fri Jul 16 18:56:36 CST 2021
> > > > > x86_64
> > > > > x86_64 x86_64 GNU/Linux [root@ktest-01 ~]# cat
> > > > > /sys/block/nvme0n1/queue/scheduler
> > > > > [none] mq-deadline kyber bfq
> > > >=20
> > > > I don't think this is an issue with the build=E2=80=A6 BTW, with
> > > > `initcall_debug`:
> > > >=20
> > > > ```
> > > > [    0.902555] calling  bfq_init+0x0/0x8b @ 1
> > > > [    0.903448] initcall bfq_init+0x0/0x8b returned -28 after 507 us=
ecs
> > > > ```
> > > >=20
> > > > -ENOSPC? Why? Also re-tested with the latest git tip, same result :=
(.
> > >=20
> > > OK, one extra pr_info, and I see this:
> > >=20
> > > ```
> > > [    0.871180] blkcg_policy_register: BLKCG_MAX_POLS too small
> > > [    0.871612] blkcg_policy_register: -28
> > > ```
> > >=20
> > > What does it mean please :)? The value seems to be hard-coded:
> > >=20
> > > ```
> > > include/linux/blkdev.h
> > > 60:#define BLKCG_MAX_POLS               5
> > > ```
> >=20
> > OK, after increasing this to 6 I've got my BFQ back. Please see [1].
> >=20
> > [1]
> > https://lore.kernel.org/linux-block/20210717123328.945810-1-oleksandr@n=
at
> > alenko.name/
> OK, after you fixed the issue in blkcg_policy_register(), can you
> reproduce the discard issue on v5.14-rc1 with BFQ applied? If yes,
> can you test the patch I posted previously?

Yes, the issue is reproducible with both v5.13.2 and v5.14-rc1. I haven't=20
managed to reproduce it with v5.13.2+your patch. Now I will build v5.14-
rc2+your patch and test further.

Thanks.

=2D-=20
Oleksandr Natalenko (post-factum)