Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Anand Ashok Dumbre <ANANDASH@xilinx.com>
To:     Jonathan Cameron <Jonathan.Cameron@Huawei.com>
CC:     Jonathan Cameron <jic23@kernel.org>,
        "lars@metafoo.de" <lars@metafoo.de>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        Michal Simek <michals@xilinx.com>,
        "pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Manish Narani <MNARANI@xilinx.com>, git <git@xilinx.com>
Subject: RE: [PATCH v6 2/4] iio: adc: Add Xilinx AMS driver
Thread-Topic: [PATCH v6 2/4] iio: adc: Add Xilinx AMS driver
Thread-Index: AQHXaSbtDGFAxFZ6nESrsiS8rtP1uaszMzUAgBCU7UCAAFYQgIAF9HeQ
Date:   Mon, 19 Jul 2021 07:49:35 +0000
Message-ID: <BY5PR02MB6916EE8DDB6EBDFDAF50DD41A9E19@BY5PR02MB6916.namprd02.prod.outlook.com>
References: <20210624182939.12881-1-anand.ashok.dumbre@xilinx.com>
        <20210624182939.12881-3-anand.ashok.dumbre@xilinx.com>
        <20210704193108.20e19692@jic23-huawei>
        <BY5PR02MB69165A85F14243048187870BA9129@BY5PR02MB6916.namprd02.prod.outlook.com>
 <20210715135221.00001d4f@Huawei.com>
In-Reply-To: <20210715135221.00001d4f@Huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zo2u0eM1DB9oy7mwsO+XA8lRXUgYqCFBUxPTHozQHF1bqUxJ6le2k0atf0kT?=
 =?us-ascii?Q?RGIbZMi4apUcJkP2s75SHmd4BPpSnz2ki0rVjNz29ToAcbHHSfhiD4ZwKtF7?=
 =?us-ascii?Q?yeInv0gLNRVl2ACF8atQ3vfKuIG6h1P/0Pc6+oFzMq4iIKxWaNItPBWt43cX?=
 =?us-ascii?Q?YI6sxO9nyqD32RDxfuGTGFCg+DMN5XptBnTS3ngYRAj1AsN9rngjAB7ekEFj?=
 =?us-ascii?Q?KYbBhbzw8eqPBcoO2MUUbaWcHkmulUiLTBtiXArMM0nqHt/TqRfXr7WhPaNY?=
 =?us-ascii?Q?C1ZPqiJuqdeCEHj9peTo/ZG9VSk8/gpUfhmsW5oHFjqcSoPDBebQ3teLR8x7?=
 =?us-ascii?Q?jW/WunwvdjKSQjNcmOC4r1/RrV1Nu8JekI/OyU6wql8pS8BDzoO7uK1/Sxh6?=
 =?us-ascii?Q?t0pVCb+MjcdAPI0NectsQhWON+5IkcXu3ZnjqNuLxt1ahMfIKpgSLJGJVOBK?=
 =?us-ascii?Q?Z2B9zBtxU9fyp5C8OEIRN1E40QZOC9rjwzUsaHxCKAGqHH9SoXLg8v7uKfc0?=
 =?us-ascii?Q?8kfOD+lK2kcOdtlwKBKfHbW0a1MiK245+p4OyVqH3wx+90iGc7kVknyWq/k2?=
 =?us-ascii?Q?3Dv2y6QyfattlHVfzGW85seMTQO6XHFrCgbxyy6u+ojcMj+2jcaoTym7NOsB?=
 =?us-ascii?Q?IJJsSVhPsMR4RNzsCmLIYXCYwf5CUQb4zH1mle+N8p5jEOPw181PqlyzduvC?=
 =?us-ascii?Q?iN5msGp/zYRMw52f4pM3a10HXEmkVi9gMPNWFTpqsYnKZ+uh87eszc093D0W?=
 =?us-ascii?Q?8TdM3qxRDRBDuxxsM+YZDcXjNZR0P+k/EphAqO6YShxY82zWrnQWjAX+N9nS?=
 =?us-ascii?Q?utesTeHs8KhZ25yafkp7uTndNEoCts4k2/6dHLf+LLKE3Pp3qRX/zSwF+CLt?=
 =?us-ascii?Q?9M0KPcRcwMD7R9oEUuASogz8jUf1KFzg6Y8jgvqFmxXgXLb5JMv9ILeY9cXI?=
 =?us-ascii?Q?bvN0ULf/XzLQZeUCbGH+FvqLLj/cHhHoJiIVNSjWGzLoTW5C7aybrRCiX58M?=
 =?us-ascii?Q?X5YSwvJTUcFztn1aUNMzGHMlMuNeDDu0cxEVRSx3ZIpDOnXoPAAn9x5n4uj8?=
 =?us-ascii?Q?pJpSLBrJf33Wd9IFK4j0fBFA1hwFl0paBdEd0LctVpNXU3akQZna1zoJ4eEv?=
 =?us-ascii?Q?wztFs4fXeF7Uq+KgLMi28eEOs26KbbvelUrBAUTk12ofBhH3Q0FOeOd11I1i?=
 =?us-ascii?Q?F8kMURNmkY4mzSFJeMmBo+jWztMtxLdhE1oZFMHXx/P0gJcCTSt99LyLFfUB?=
 =?us-ascii?Q?MAPnqcIBXaqw/fdmGg6OVtH79603+Zvj2FBzm88IQCRkfgP50jfgx8hfObRL?=
 =?us-ascii?Q?bSgZkSAKCN3zSX4Q0yRAywWv?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR02MB6916.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad999126-709d-443e-9392-08d94a89c0cd
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2021 07:49:35.4144
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pOvSoVvLR3Jm2M6MBIcroUwrlZQNYYmzJAod2R0f9q78u1e861lXjBtR+NzPCVNlyGWrQMhJ1SZ6K3K+ePL0kA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7518
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
> Sent: Thursday 15 July 2021 1:52 PM
> To: Anand Ashok Dumbre <ANANDASH@xilinx.com>
> Cc: Jonathan Cameron <jic23@kernel.org>; lars@metafoo.de; linux-
> iio@vger.kernel.org; git-dev <git-dev@xilinx.com>; Michal Simek
> <michals@xilinx.com>; pmeerw@pmeerw.net; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; Manish Narani <MNARANI@xilinx.com>
> Subject: Re: [PATCH v6 2/4] iio: adc: Add Xilinx AMS driver
>=20
> ...
>=20
> > >
> > > > +	if (IS_ERR(ams->base))
> > > > +		return PTR_ERR(ams->base);
> > > > +
> > > > +	ams->clk =3D devm_clk_get(&pdev->dev, NULL);
> > > > +	if (IS_ERR(ams->clk))
> > > > +		return PTR_ERR(ams->clk);
> > > > +	clk_prepare_enable(ams->clk);
> > > > +	devm_add_action_or_reset(&pdev->dev, (void
> > > *)clk_disable_unprepare,
> > > > +				 ams->clk);
> > > > +
> > > > +	INIT_DELAYED_WORK(&ams->ams_unmask_work,
> > > ams_unmask_worker);
> > > > +	devm_add_action_or_reset(&pdev->dev, (void
> > > *)cancel_delayed_work,
> > >
> > > I'm not keen on casting away the function pointer type.  Normally
> > > we'd just wrap it in a local function, to make it clear it was
> > > deliberate and avoid potential nasty problems if the signature of the
> function ever changes.
> > >
> > > It's 3 lines of boilerplate, but will give me warm fuzzy feelings!
> > > Same for the other case above.  The fact this isn't done in exising
> > > kernel code make this particularly risky.
> >
> > Makes sense. I will revert the code back to its original and handle
> > the cases using goto and inside remove()
> Ah.  Not what I meant.  I was suggesting you add a little function locall=
y that
> has the right type and in turn calls cancel_delayed_work().
>=20
> As that directly exposes the actual function calls, any signature change =
in
> future will cause compile breakage (or be picked up any automated tools
> doing that refactor).

Now I understand.
Will fix it in the next series.

>=20
> >
> > >
> > > > +				 &ams->ams_unmask_work);
> > > > +
> > > > +	ret =3D ams_init_device(ams);
> > > > +	if (ret) {
> > > > +		dev_err(&pdev->dev, "failed to initialize AMS\n");
> > > > +		return ret;
> > > > +	}
> > > > +
> > > > +	ret =3D ams_parse_dt(indio_dev, pdev);
> > > > +	if (ret) {
> > > > +		dev_err(&pdev->dev, "failure in parsing DT\n");
> > > > +		return ret;
> > > > +	}
> > > > +
> > > > +	ams_enable_channel_sequence(indio_dev);
> > > > +
> > > > +	ams->irq =3D platform_get_irq(pdev, 0);
> > >
> > > platform_get_irq () can return errors, in particular -EPROBE_DEFER
> > > so I'd check that and return before you call devm_request_irq() I'm
> > > not sure
> > > devm_request_irq() will not eat that error code.
> > >
> >
> > Will fix this in next series.
> >
> > >
> > > > +	ret =3D devm_request_irq(&pdev->dev, ams->irq, &ams_irq, 0, "ams-
> > > irq",
> > > > +			       indio_dev);
> > > > +	if (ret < 0) {
> > > > +		dev_err(&pdev->dev, "failed to register interrupt\n");
> > > > +		return ret;
> > > > +	}
> > > > +
> > > > +	platform_set_drvdata(pdev, indio_dev);
> > > > +
> > > > +	return iio_device_register(indio_dev); }
> > > > +
> > > > +static int ams_remove(struct platform_device *pdev) {
> > > > +	struct iio_dev *indio_dev =3D platform_get_drvdata(pdev);
> > > > +
> > > > +	iio_device_unregister(indio_dev);
> > >
> > > If this is all you have in remove, then you can use
> > > devm_iio_device_register() in probe() and not need an remove() callba=
ck
> at all.
> >
> > I think remove will have more functions since I am getting rid of
> > devm_add_action_or_reset()
>=20
> See above.
>=20
> J
>=20
> >
> > >
> > > > +
> > > > +	return 0;
> > > > +}
> > > > +
> > >
> > > ...

Thanks,
Anand