Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3483229pxv; Mon, 19 Jul 2021 00:54:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymgCIyA+N1JhgvgQD1w8p6NHCmy6TWeRXyoQZDn5qW2wCjlVZvP7iSvaLbqkTS0/4IgweQ X-Received: by 2002:a17:907:70c6:: with SMTP id yk6mr25282798ejb.42.1626681265410; Mon, 19 Jul 2021 00:54:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626681265; cv=none; d=google.com; s=arc-20160816; b=ayYDmpVkE1CNT8P5NBC0qu5SqoOyqAUH/ptj3fd0cfZa9EBDiHdt6G+tpv9MY1XEd1 0R2pwF/UBi8j1G+Dnlr2W4arCMMCZaxuqCAVZZRcfMmpYZ0rp/TCmWaLcdOCaQpU2seH H7lXKqYYEXIXdKzfzKb5kyipudUdh3JFIgCQvQzn1xHRd66Xxf07ELzU6Q0+e1huxS7k fvZNHYImBg4BhKr++31a3xIVXwgWcUKD4f1G5I/lkkK60c8apew6Q+Cqhs5r6f+dEKDd i6BQh2zY+ddJjYyZ+Kfmxf+2KoMdyn4ERXIzSqfqk1PhRJEkP0BOG1lo8c10tnGAdE8b dXXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=jeu3nkFnbfwdZPAlR8MjoCESf9iWjRA/DMVfIK3NsVA=; b=Oh3K/Tcy66R8a8MImWX/ppNV8cA4KZ6gyutvpZiq/BdS3WbZdESqmXH6h+OHdHkBw6 Cip+VDNdBaazV1mwk3Yv9hiEKlnTTuT07QkYXGLJztxYQ1ax43xMtzlGRsfZNpvqw9ry l9lBCDGDNI/rrpd4S1yqNzoPrmQBm6o99qw3iFY+0xxPtPTgR5t7zPb+YV4BLDogbE6D 88XTRTHoKJQFxSkLLI3KeYMIvsZ5tEPHxyTZdqbSkQSCfO7Prvt2saRin4+3zFEu9Ir9 zWMO19pkL2rFKCbfO2KCSBT0tNZADG/pDBh0AXZTyzq8cK/U0ydK4w835VHR9Rpy1S6r Rbtw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r26si18098966ejz.423.2021.07.19.00.54.03; Mon, 19 Jul 2021 00:54:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235101AbhGSHzQ (ORCPT + 99 others); Mon, 19 Jul 2021 03:55:16 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:46486 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S235071AbhGSHzO (ORCPT ); Mon, 19 Jul 2021 03:55:14 -0400 X-UUID: 4c3ecf37000447c2b17e0d2ce9640b75-20210719 X-UUID: 4c3ecf37000447c2b17e0d2ce9640b75-20210719 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1834079245; Mon, 19 Jul 2021 15:52:11 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 19 Jul 2021 15:52:09 +0800 Received: from localhost.localdomain (10.17.3.153) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 19 Jul 2021 15:52:08 +0800 From: Yongqiang Niu To: Chun-Kuang Hu CC: Rob Herring , Matthias Brugger , Philipp Zabel , David Airlie , Daniel Vetter , Jassi Brar , Yongqiang Niu , Fabien Parent , Dennis YC Hsieh , , , , , , , Hsin-Yi Wang Subject: [PATCH v1] drm/mediatek: add dither 6 setting Date: Mon, 19 Jul 2021 15:52:06 +0800 Message-ID: <1626681126-29270-2-git-send-email-yongqiang.niu@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty In-Reply-To: <1626681126-29270-1-git-send-email-yongqiang.niu@mediatek.com> References: <1626681126-29270-1-git-send-email-yongqiang.niu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org in the first version dither patch https://patchwork.kernel.org/project/linux-mediatek/patch/1553667561-25447-13-git-send-email-yongqiang.niu@mediatek.com/ dither 6 setting is included in that patch bit 1 is lfsr_en( "Enables LFSR-type dithering"), need enable bit 2 is rdither_en(Enables running order dithering), need disable in this issue https://partnerissuetracker.corp.google.com/issues/190643544 dither 6 setting missed in set dither common patch https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c?h=next-20210430&id=a6b7c98afdcad0f149010ae028b24f2d0dc24cdb Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 ++ 1 file changed, 2 insertions(+) mode change 100644 => 100755 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c old mode 100644 new mode 100755 index 99cbf44..7dd8e05 --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c @@ -26,6 +26,7 @@ #define DISP_OD_CFG 0x0020 #define DISP_OD_SIZE 0x0030 #define DISP_DITHER_5 0x0114 +#define DISP_DITHER_6 0x0118 #define DISP_DITHER_7 0x011c #define DISP_DITHER_15 0x013c #define DISP_DITHER_16 0x0140 @@ -135,6 +136,7 @@ void mtk_dither_set_common(void __iomem *regs, struct cmdq_client_reg *cmdq_reg, if (bpc >= MTK_MIN_BPC) { mtk_ddp_write(cmdq_pkt, 0, cmdq_reg, regs, DISP_DITHER_5); + mtk_ddp_write(cmdq_pkt, 0x3002, cmdq_reg, regs, DISP_DITHER_6); mtk_ddp_write(cmdq_pkt, 0, cmdq_reg, regs, DISP_DITHER_7); mtk_ddp_write(cmdq_pkt, DITHER_LSB_ERR_SHIFT_R(MTK_MAX_BPC - bpc) | -- 1.8.1.1.dirty