Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3514903pxv; Mon, 19 Jul 2021 02:01:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoZyMNJb9A27VrDI7Lk5TVZJYtr3iU5qaKk1o5+dfX8gdiozp3lEMX2nzYwtCtKDLhtXWY X-Received: by 2002:a05:6e02:1947:: with SMTP id x7mr16697014ilu.85.1626685273385; Mon, 19 Jul 2021 02:01:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626685273; cv=none; d=google.com; s=arc-20160816; b=z6kzTWNdx3KT/w/nliWohKjiZR+sau34b4upNkTOJroTLNEM7g0BzOdNbjL+DwJu5x jRJnLatvOw937TSrGwIG9Y148WN6EM/Q/NllCXdaAQ0lre587Qg7EdCA04pv3h7SpDHM Kzx6kZHfRK+pzkY96FZ4t1XmX9gycjmV62XM8uMyMv4/YAMGUpmprYDNEu5AkHu0rsQw zIU54kJjebL1gZdak6awrtbQEaAB/JS35d6nIS1DRCLK13l4tf1ZE3B/y1Od0IkY1Tfk 1vKNM8xsSqeItJW/3YP4U4zdEMr2/iUxPfio5BA2iZ5P9hGJ+GRKHEQ+P1ExlBSZKXaC FE2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=4Le9djHlx0BC++7zIW7Se8YXXmMFVw9ilEn0gmwAMC8=; b=aiylYA2vPvNmrbqXNTz6Tpqnsmhxy21gOoi0afECeAqz2CGvX6vJvj6FuUrZfxihGQ QQoMFQ1JP8QvSgfENTnKfmZt4LS+peWwjwYTP/yn0eqfkdOIXEOMwHwdRDRsbkbHieB/ XzOopntot1SVPfWJVIbhMb2VboJ5RFXncoXkXFipZpeXfOcMh4v1MxhLJvOEWHiloHKc 06SepkDbPUoiYQ689n+ScXaUxCBd2OczXymwkhllnC278aJgwNCXWnw4CKe2S4RYiMAP ngmoeCoFNjHAy/a/0Hj9Srt3TRBT6xeFhWXDEJtQoAukPwGewiyTTvo4ldeeLTugM817 UiNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k7si21041549ilh.42.2021.07.19.02.01.01; Mon, 19 Jul 2021 02:01:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235315AbhGSIT2 (ORCPT + 99 others); Mon, 19 Jul 2021 04:19:28 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:56046 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S235658AbhGSITX (ORCPT ); Mon, 19 Jul 2021 04:19:23 -0400 X-UUID: aae2e18161884d439af3e0e736ba2a0f-20210719 X-UUID: aae2e18161884d439af3e0e736ba2a0f-20210719 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 164044496; Mon, 19 Jul 2021 16:24:47 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 19 Jul 2021 16:24:45 +0800 Received: from localhost.localdomain (10.17.3.153) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 19 Jul 2021 16:24:44 +0800 From: Yongqiang Niu To: Chun-Kuang Hu CC: Rob Herring , Matthias Brugger , Philipp Zabel , David Airlie , Daniel Vetter , Jassi Brar , Yongqiang Niu , Fabien Parent , Dennis YC Hsieh , , , , , , , Hsin-Yi Wang Subject: [PATCH v2] drm/mediatek: add dither 6 setting Date: Mon, 19 Jul 2021 16:24:42 +0800 Message-ID: <1626683082-29570-2-git-send-email-yongqiang.niu@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty In-Reply-To: <1626683082-29570-1-git-send-email-yongqiang.niu@mediatek.com> References: <1626683082-29570-1-git-send-email-yongqiang.niu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org in the first version dither patch https://patchwork.kernel.org/project/linux-mediatek/patch/1553667561-25447-13-git-send-email-yongqiang.niu@mediatek.com/ dither 6 setting is included in that patch bit 1 is lfsr_en( "Enables LFSR-type dithering"), need enable bit 2 is rdither_en(Enables running order dithering), need disable in this issue https://partnerissuetracker.corp.google.com/issues/190643544 dither 6 setting missed in set dither common patch https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c?h=next-20210430&id=a6b7c98afdcad0f149010ae028b24f2d0dc24cdb Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index 99cbf44..7dd8e05 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c @@ -26,6 +26,7 @@ #define DISP_OD_CFG 0x0020 #define DISP_OD_SIZE 0x0030 #define DISP_DITHER_5 0x0114 +#define DISP_DITHER_6 0x0118 #define DISP_DITHER_7 0x011c #define DISP_DITHER_15 0x013c #define DISP_DITHER_16 0x0140 @@ -135,6 +136,7 @@ void mtk_dither_set_common(void __iomem *regs, struct cmdq_client_reg *cmdq_reg, if (bpc >= MTK_MIN_BPC) { mtk_ddp_write(cmdq_pkt, 0, cmdq_reg, regs, DISP_DITHER_5); + mtk_ddp_write(cmdq_pkt, 0x3002, cmdq_reg, regs, DISP_DITHER_6); mtk_ddp_write(cmdq_pkt, 0, cmdq_reg, regs, DISP_DITHER_7); mtk_ddp_write(cmdq_pkt, DITHER_LSB_ERR_SHIFT_R(MTK_MAX_BPC - bpc) | -- 1.8.1.1.dirty