Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3546777pxv; Mon, 19 Jul 2021 02:57:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrH9vuzNxNnA4pBZ7q3JJexKDkYzi1ijlaM/DxwUyOXKdLVTjFEff5yKzeOcfKKx9+2YtH X-Received: by 2002:aa7:c412:: with SMTP id j18mr32404160edq.119.1626688651509; Mon, 19 Jul 2021 02:57:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626688651; cv=none; d=google.com; s=arc-20160816; b=IhZI8hxNxCCmYiRi1yIZM6W96Csy4/2y7MKhzoZWUkWtVAzn05l+QshVDd1HtAg2PM grpXk3/2wAyZsF/JYGdTfOSP5qCrQl48rEX1MB9oa+fdcVXvatkIRfNndof0u9JHB0kV yf/0tWTt0X58PgLQK+puWEDB93slWah8jbaUt5f/76vYY/G8Zf6J0t7WBaEP9+JoFSiG 7K0JL7PRYYn1zq6ZQ2Rnmp+HUgHksTPme6Fm+wgKV6Uhme/9iii7/OkQt6dRn44KjgQf 3rQPS4dMk4ZoHvBOw7jiqCd2Xq4nBobYUp1PsW72HwPz4elrx7hEj3rx1BoEkUaosdFw CzGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4vk7KIdJCRC7TIVcjpvWczPZx7IvBjnY0IqBnPn8DYo=; b=Di8dbTNiQ+hCtPjetaM/Mnn3OVh4S7WuiWbIuxMMn0jxW0Cl9RrrqVbUtQBzODVDfg k53jQbR1jnvDW2MAuK5W5WxivxD6iNauel/d4vS7nTN8QqmqfrGKCRPtfCoHCR9Zi4wg yEhR812ljqm4tUPcAP5S8ny470yXnvB0KEClVMi43ZU7oH0NNqII9spSxX/lyWQL7Eow XHUXeNPaUDao/cMbvkPEnB1fHH3sVMSJjOq0vYZYZP3cAz9KKahOA7k5N2srJexsVqIK fYlWODJaAMoIlwXfR55qTFJaMNE+tQRY8oJ61p2Kuqt+SS4a6S6sBtmrSwfB48vbYMkQ U1Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=m5vWPRSW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bd4si13766696edb.531.2021.07.19.02.57.09; Mon, 19 Jul 2021 02:57:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=m5vWPRSW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235893AbhGSJPD (ORCPT + 99 others); Mon, 19 Jul 2021 05:15:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231928AbhGSJPC (ORCPT ); Mon, 19 Jul 2021 05:15:02 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC45AC061574; Mon, 19 Jul 2021 01:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4vk7KIdJCRC7TIVcjpvWczPZx7IvBjnY0IqBnPn8DYo=; b=m5vWPRSWx2lZkD8Ledo+GwIjEG q0b/4cwhoLB/6JL8e9Haz+iFOIkyYLYBFtl1v8DReF9xXOQuUmjAkuv+irsynbFlXMy3oL3/SKH01 7HQcFLHfYRmPSat80LHGZ4Nj+niD8kRJxqX40CCZqKyCkaJ1syM65KWUbEsTOtyhFrDP2JcAxyn+A UqJyCBCeJwk2kbWgQN0a+Shb8RpJ2nj+xcSCREv7i1gvJTVz5k8KxzdBntveDRa1B5S2ZsU83d2t7 uPze/t+W73PlyxyhdOpJVkZDXtg/DhgLsXI4jlO2lHgZeTviJuF9D6/4xWmwVDBH/lwZmUVsSbspr Xsb3gQ6A==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5PxI-006igt-Jq; Mon, 19 Jul 2021 09:53:07 +0000 Date: Mon, 19 Jul 2021 10:52:56 +0100 From: Christoph Hellwig To: Luis Chamberlain Cc: axboe@kernel.dk, hare@suse.de, bvanassche@acm.org, ming.lei@redhat.com, hch@infradead.org, jack@suse.cz, osandov@fb.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 1/6] genhd: update docs for GENHD_FL_UP Message-ID: References: <20210715202341.2016612-1-mcgrof@kernel.org> <20210715202341.2016612-2-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715202341.2016612-2-mcgrof@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 15, 2021 at 01:23:36PM -0700, Luis Chamberlain wrote: > The GENHD_FL_UP is used internally so we can know when we can add and > remove partitions, so just clarify that. Right now it has this 1980's > description comparing it to network drivers "ifconfig up" idea, and > that can easily lead to invalid uses. GENHD_FL_UP actually is pretty horrible - it uses a value used for something that should be mostly read only at device runtime for state an does so badly. I actually have a patch to kill it, as we can just check if the inode for the whole device blockdev is hashed instead.