Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3552788pxv; Mon, 19 Jul 2021 03:06:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUmTXezACvKJUq2/o1O3EMrGTbeVGgkgOt/x4uc7Yycjsz5RICMc2hOUPcmFXQz7tfEE8o X-Received: by 2002:a5e:930e:: with SMTP id k14mr18252970iom.136.1626689212900; Mon, 19 Jul 2021 03:06:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626689212; cv=none; d=google.com; s=arc-20160816; b=GQwlVVmkoXk8IiZOT3AWphZE4oWqhxPVKui0M5kkLDFz0FFn0vPfc7aPvQsxV6z5bd 61nXnyei5P5w/jix7Necz311dZY0llW/GjZ/kzBkF2ZmBCrjQ7ectjiUNmv9/zFzaoqS 6UGPj5Q5AYnR2aPfgGi3Fe3Q3M3XUQ5SvF2OcQo0nFmHnJwg5MS/iE7hEXVSrgCG/VHP DAYWgc66HbuaLHHyRPgE4Qo+zizKMN1xUHF00t5pDFhkUsWSDhJ8o+X4TEItzKguolTi SF2LwLTMOW3c5DEme5R9FVspOGdSOsx5hCjE4xehXDYVPpD2GZDOeK5+78rQHFFVgPiZ CJ+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=2clRhsTXbVF5GFFw3oK01iHT0Jgt2ge2kuoVOop/12M=; b=S2PswahrUTCrIHggag4BiRgVDPV9VJwDEjW+J0heu/Hg0mb48R2psD0tn+kLts40bq DRu4Va6zhFFNOkRhiFwr3qXTAGs0OMQWr8bdRqK8KL6+qXvF3Rhw4OsNlThqcowO2fm6 URMVE2S0P/jskd2r5EAAMWvfu/fgUndMJjxfV88CBHh/UT7+TJCLLRprV5qOuWZy4XN4 1W4dg1l77rVi3ykNLUoQGD3ZcbpFH/6yRoZi6yZ9YBYQySsSkajiX89cf68wo7nAyUYl jqIzEcLfU57CB8DH7ns6mlCAgvTCXXeojicCc9OTdDX8CmlIWHj02eu836LdYqA9s/KT NmGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qVYPhN33; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f11si20719316jav.53.2021.07.19.03.06.41; Mon, 19 Jul 2021 03:06:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qVYPhN33; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235976AbhGSJZJ (ORCPT + 99 others); Mon, 19 Jul 2021 05:25:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:37904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235676AbhGSJZI (ORCPT ); Mon, 19 Jul 2021 05:25:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 390B9610FB; Mon, 19 Jul 2021 10:05:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626689148; bh=elq9AwtXUXxwMlcmvki583LUA+hdla6CBUE7hm+4Oh8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qVYPhN33f05z2J82OSgEZ9dkcOewkhvON70Rd1k+FZZAUr9DnVGp9oCl+pUAVXf4K sZLbBWVb3w51VvIpLNZFsiOVtMKcp9NFbnKb7YnMiV9ATGF+nRRhHYVmLC8Tf/80hN NT18uS20a42oauGNoY5Af7rqWU2wD/22gtuxCBzvdeTLtlH+65vhfBQQo/8zXqqXgN FRoXltH2QExRuZbt+SlPg51/t7w4w4/YMf9MYb9XJ4Fczrl5lb0UcBlauNaX38SlKp s67f2TLanfXt1wR+mEjPouh75lERlwLQLLe+u0FDkCQYlJ1yyIZQ79q0yUyUTfEidt H/IUNC6WyjuGA== Date: Mon, 19 Jul 2021 12:05:41 +0200 From: Jakub Kicinski To: Pavel Skripkin Cc: davem@davemloft.net, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+13ad608e190b5f8ad8a8@syzkaller.appspotmail.com Subject: Re: [PATCH] net: 802: fix memory leak in garp_uninit_applicant Message-ID: <20210719120541.7262fc70@cakuba> In-Reply-To: <20210718210006.26212-1-paskripkin@gmail.com> References: <20210718210006.26212-1-paskripkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Jul 2021 00:00:06 +0300, Pavel Skripkin wrote: > Syzbot reported memory leak in garp_uninit_applicant(). The problem was > in missing clean up function in garp_uninit_applicant(). Looks like it's fixed in net by commit 42ca63f98084 ("net/802/garp: fix memleak in garp_request_join()"), would you mind double checking that fix and closing the syzbot report manually? Similar with your MRP patch and commit 996af62167d0 ("net/802/mrp: fix memleak in mrp_request_join()").