Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3565620pxv; Mon, 19 Jul 2021 03:30:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwhUmqPtw+GKvGnCrScH6FmnGFNI+KeMsfZ/XcQHd5fs3Ag9xDFjZOLC6p7aN/EE7yg3LA7 X-Received: by 2002:a5d:840c:: with SMTP id i12mr17930435ion.185.1626690610653; Mon, 19 Jul 2021 03:30:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626690610; cv=none; d=google.com; s=arc-20160816; b=onmq71AvViq37vhTeeEP1RjdHcMCqAKHiIJZNcoKDCiyVc2AQAk153G/fiz0qS5GY6 ORd3HAd/AVlDMyPd5Z2wb0bVFFzEHbRi9H16Lk5Tna0iwWr1MLdCBMwCVFJE4VvzoFrB xBI58mGVaTInfXWzB3JUJCXO+6MlrGhvGnqbQEMqPmoFFPJUL3STw6nQfqq69RPGq3xu DdY716iOQdG0q0qqtKhAKRncuo9d9oIv5OlfZOem6OTr6ToL+7wPUPvecoNyHeRqe9d1 U0kwWE3BT8sBlKyzzsSj8Qf/RKjtNdld4l+OTs8TEFnSdnx1wQncfdJVJpsENsSfNfGr zGRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=j9gP2F+YGBN0qB5vck/z1iGx6N0mtdgkTdRUqd67V0g=; b=VRRfA6W8/HnULtLZ23fxuZH7EmqSPU/6kYbeEQ+rG4jF6L2gJZsELo0CAQc10QdgB9 qw5xvQYsV4hxzYqsZe0B8mz+sFzOT4AVfy7Zaih5jZY8NuQZMIIqp+SYG6xgRgEZNr1C 92mAtFeTLyIoPHLYtCj3TQKNo1obLXlUB8LXRwJpcqB+HadyvbCJW/PHMRlFVhPrBqGI h4jY/KixzIwm3nuePXxIMxXZJG3nyvM5Oskf55tlB+HA6LGE4a1Q8BcypGHCpgu0eUn+ Ocmmk7RUsafLs5aphLoFpIiQJ/+gR8npRpK13pJ6lr3my9Vd1gaW1up1QJOGKaP++0WA mSVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uzrDuYDU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f17si19247933ion.28.2021.07.19.03.29.58; Mon, 19 Jul 2021 03:30:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uzrDuYDU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236213AbhGSJsw (ORCPT + 99 others); Mon, 19 Jul 2021 05:48:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235172AbhGSJsv (ORCPT ); Mon, 19 Jul 2021 05:48:51 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29F4CC061574; Mon, 19 Jul 2021 02:35:54 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id ee25so23232829edb.5; Mon, 19 Jul 2021 03:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j9gP2F+YGBN0qB5vck/z1iGx6N0mtdgkTdRUqd67V0g=; b=uzrDuYDUd+RfvoZDiB91XqYOGOCSEReAGKLoVF1VROGbS1obAwYnMBR2Yl0gCQr7YS A81JmUioX4IwTAM/eDnGuST9n6Ef1wWN2ilZgn5msqwKjUKtz44s6zWM2e2ouvbNdqji uiApX+59EkT+UY2wOrbkFW75TIXXnQRZuR8lkKyp7J9HPV06BVylS9EhawHTS8/CYpRG EXJ/viD2ev3qTZMZQK03Mj+CDSg+6AtOTg2yHf5eJ+StHBPfhmZhM4zQisTVoyv4ZQln 0gJidaGL/KkGqlJ5YMzo4rHRJBEbfa8xSf8lpJDcJYJICi2o7w6p8nJO5zJk4rR/rdaq uV4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j9gP2F+YGBN0qB5vck/z1iGx6N0mtdgkTdRUqd67V0g=; b=UWwlsoFk8vcV+CzjMjQ5Qk+jDYpZQYXT85IxAa8qGW99roXoQ2275lUbO4qzl+fZRC VjBBG5j8ms4bklKJwZKr7C1qZgLX+B33Py0DYSHpPURAp6D+N2skxVuDULdZCxhLWV88 QSGhrnZXLccPT72ZGir4S8nltW68DctKikyZBoCWBsM2EJsAVXVlsXvUTr64CrPm0bdE 8+LRwO+ygdnQOt5DrSA+dnKMw7fKmqcbjI1jBPTSuXLXJgfCpxzFy/A+w1QGiiTxKbv5 4jkSswlTkIu5mLylClfO9xaLJXEvBHIiHwLBREakJx3NLUFP6EcKhUNy68M66fAnldj3 GgPA== X-Gm-Message-State: AOAM533y3ws4g+f1DX+UPd99tdwbfZJSM+ib838uWqhIYkh8kvvPBgO4 rlw7mgfivL0DValt6O1Y5NY= X-Received: by 2002:a05:6402:3507:: with SMTP id b7mr34063732edd.254.1626690569374; Mon, 19 Jul 2021 03:29:29 -0700 (PDT) Received: from localhost.localdomain ([176.30.236.194]) by smtp.gmail.com with ESMTPSA id d9sm5767029eje.34.2021.07.19.03.29.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jul 2021 03:29:29 -0700 (PDT) Date: Mon, 19 Jul 2021 13:29:24 +0300 From: Pavel Skripkin To: Jakub Kicinski Cc: davem@davemloft.net, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+13ad608e190b5f8ad8a8@syzkaller.appspotmail.com Subject: Re: [PATCH] net: 802: fix memory leak in garp_uninit_applicant Message-ID: <20210719132924.13c9f063@gmail.com> In-Reply-To: <20210719120541.7262fc70@cakuba> References: <20210718210006.26212-1-paskripkin@gmail.com> <20210719120541.7262fc70@cakuba> X-Mailer: Claws Mail 3.17.8git77 (GTK+ 2.24.33; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Jul 2021 12:05:41 +0200 Jakub Kicinski wrote: > On Mon, 19 Jul 2021 00:00:06 +0300, Pavel Skripkin wrote: > > Syzbot reported memory leak in garp_uninit_applicant(). The problem > > was in missing clean up function in garp_uninit_applicant(). > > Looks like it's fixed in net by commit 42ca63f98084 ("net/802/garp: > fix memleak in garp_request_join()"), would you mind double checking > that fix and closing the syzbot report manually? > > Similar with your MRP patch and commit 996af62167d0 ("net/802/mrp: fix > memleak in mrp_request_join()"). Hi, Jakub. Yes, these patches are identical, so I will close the syzbot bugs manually. Thank you for pointing it out. With regards, Pavel Skripkin