Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CALOAHbAS26LP2p9Fe7m6xynZmazYENmx_HfTV4LebwPWr7XLmA@mail.gmail.com>
 <87tukxm66r.mognet@arm.com>
In-Reply-To: <87tukxm66r.mognet@arm.com>
From:   Yafang Shao <laoar.shao@gmail.com>
Date:   Mon, 19 Jul 2021 20:03:50 +0800
Message-ID: <CALOAHbDkV3WmvcK=EuMbv4qSvJm1e=GvZhuVm=Ra6iOjaasE8g@mail.gmail.com>
Subject: Re: [RFC PATCH 1/1] sched: do active load balance in balance callback
To:     Valentin Schneider <valentin.schneider@arm.com>
Cc:     Vincent Guittot <vincent.guittot@linaro.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Benjamin Segall <bsegall@google.com>,
        Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jul 14, 2021 at 8:27 PM Valentin Schneider
<valentin.schneider@arm.com> wrote:
>
> On 11/07/21 15:40, Yafang Shao wrote:
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > index 4ca80df205ce..a0a90a37e746 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -8208,6 +8208,7 @@ void __init sched_init(void)
> >                 rq->cpu_capacity = rq->cpu_capacity_orig = SCHED_CAPACITY_SCALE;
> >                 rq->balance_callback = &balance_push_callback;
> >                 rq->active_balance = 0;
> > +               rq->active_balance_target = NULL;
> >                 rq->next_balance = jiffies;
> >                 rq->push_cpu = 0;
> >                 rq->cpu = i;
> > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> > index 23663318fb81..9aaa75250cdc 100644
> > --- a/kernel/sched/fair.c
> > +++ b/kernel/sched/fair.c
> > @@ -7751,36 +7751,6 @@ static void detach_task(struct task_struct *p,
> > struct lb_env *env)
>
> Your mail client is breaking lines which pretty much wrecks the
> patch. Please use git send-email to submit patches, or look at
> Documentation/process/email-clients.rst to figure out how to tweak your
> client.

My mail client is broken.
I will fix it and resend.

-- 
Thanks
Yafang