Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3662293pxv; Mon, 19 Jul 2021 05:58:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyS1WIaFZSivsjlyf89DFy3vwUylA9dilas2nYRLxAdFlvUj8JBzDooB+JbrNjPDpxlxjTj X-Received: by 2002:a02:2a88:: with SMTP id w130mr21517052jaw.60.1626699482927; Mon, 19 Jul 2021 05:58:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626699482; cv=none; d=google.com; s=arc-20160816; b=TPvoIhB410uvV5mPHY9LfFVDTI6WmmVhkGclL0AUoCIOFsUHDJhff2X/Ad7NRk4DDu qccPL9F4CqdNjlJXDWT/jM4ARAea6gy0iHbqiUeEb5YFP4YeQALTMrPKa8/AzstbwTpr BXrm4P6gzt+5AN8EJww7CqNLc/aKGNScnh5mltcLAWFX20hx3vF3d3S/eIuJ6+ZFNy56 UltA49dRAUP8VckR6f6WLbtsM707YMsMRD+xJa9zVYNjcsRu2gO4xUS8u5n59aSjpM7n RsjZ2i3ffsznmw5IHm/X5OxoXMBXhJ3yxMalNMlfTzhyZAo7pw7LVcQL4gMIvj8/MNgE r7Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=PAGuIGpUulUwDTXBsFARVHW8678r4cIXzCHGw/DlfEk=; b=ephr+taT7RiSTcvM7pDSChicUn54AEbeCMlKKa3H4vSGSh6QwoW4UhFoH71rTQXaC4 iOQrTMstlqo64aRX1avH9WalWHJs/ZCLS4sNH27T/4p/HebhAG7NuD88py/lgCDDd7k2 78mD/Q+tUa+6kNllm/ZKHDAdWVUAFnSTT2FvshunUKsaoddI/CUJJwstFqYsOtItUTxJ JiDiDxHCoD50nkI1Wz6YUEG+cryfD1A9usIEuXi521k54SOnhHUvRr1P9Zgm4dbjVZfs pxpZNG/Vnt/2Q2qe3nN+xYRqmD+Fw+Wv/U7eE5pKwTqSteEB+XpPFpzPwaQ79/yxSrCR UQMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 16si19631640iln.76.2021.07.19.05.57.51; Mon, 19 Jul 2021 05:58:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237076AbhGSMQc (ORCPT + 99 others); Mon, 19 Jul 2021 08:16:32 -0400 Received: from mga17.intel.com ([192.55.52.151]:37178 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236935AbhGSMQb (ORCPT ); Mon, 19 Jul 2021 08:16:31 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10049"; a="191328838" X-IronPort-AV: E=Sophos;i="5.84,252,1620716400"; d="scan'208";a="191328838" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2021 05:57:11 -0700 X-IronPort-AV: E=Sophos;i="5.84,252,1620716400"; d="scan'208";a="656832866" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2021 05:57:10 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1m5SpT-00FWIJ-VE; Mon, 19 Jul 2021 15:57:03 +0300 Date: Mon, 19 Jul 2021 15:57:03 +0300 From: Andy Shevchenko To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH v1 1/1] mm/util: Rephrase documentation for kmemdup_nul() to clarify input Message-ID: References: <20210719122002.41334-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 19, 2021 at 01:44:22PM +0100, Matthew Wilcox wrote: > On Mon, Jul 19, 2021 at 03:20:02PM +0300, Andy Shevchenko wrote: > > kmemdup_nul() strictly speaking is not related to the string API, > > while being quite useful for it. Rephrase documentation to make it > > clear that input data can be anything (any data, which may contain > > any bytes, including 0x00). > > That's not a useful thing to do, though. This rephrasing you've > done is more confusing than the original. Okay, then drop it. Sorry for the noise. -- With Best Regards, Andy Shevchenko