Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?ISO-8859-1?Q?R=E9mi?= Denis-Courmont <remi@remlab.net>
To:     courmisch@gmail.com, Yajun Deng <yajun.deng@linux.dev>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] net: Adjustment parameters in rtnl_notify()
Date:   Mon, 19 Jul 2021 17:36:06 +0300
Message-ID: <5299846.uZDWVASI8p@basile.remlab.net>
Organization: Remlab
In-Reply-To: <20210719122506.5414-1-yajun.deng@linux.dev>
References: <20210719122506.5414-1-yajun.deng@linux.dev>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

 Hi,

Le maanantaina 19. heinäkuuta 2021, 15.25.06 EEST Yajun Deng a écrit :
> The fifth parameter alread modify from 'struct nlmsghdr *nlh' to
> 'int report', just adjustment them.

I can't see that anywhere in the patch.

> Add the case the nlh variable is NULL in nlmsg_report().
> 
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>

> diff --git a/net/phonet/pn_netlink.c b/net/phonet/pn_netlink.c
> index 59aebe296890..03e04d0b8453 100644
> --- a/net/phonet/pn_netlink.c
> +++ b/net/phonet/pn_netlink.c
> @@ -38,7 +38,7 @@ void phonet_address_notify(int event, struct net_device
> *dev, u8 addr) goto errout;
>  	}
>  	rtnl_notify(skb, dev_net(dev), 0,
> -		    RTNLGRP_PHONET_IFADDR, NULL, GFP_KERNEL);
> +		    RTNLGRP_PHONET_IFADDR, 0, GFP_KERNEL);
>  	return;
>  errout:
>  	rtnl_set_sk_err(dev_net(dev), RTNLGRP_PHONET_IFADDR, err);
> @@ -204,7 +204,7 @@ void rtm_phonet_notify(int event, struct net_device
> *dev, u8 dst) goto errout;
>  	}
>  	rtnl_notify(skb, dev_net(dev), 0,
> -			  RTNLGRP_PHONET_ROUTE, NULL, GFP_KERNEL);
> +			  RTNLGRP_PHONET_ROUTE, 0, GFP_KERNEL);
>  	return;
>  errout:
>  	rtnl_set_sk_err(dev_net(dev), RTNLGRP_PHONET_ROUTE, err);

Sorry but I don't like to replace explicit NULL pointers with implicitly 
converted zeroes.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/