Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3757799pxv; Mon, 19 Jul 2021 08:05:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8Z84eiMlR8kRaQz6d4QX658w/Z1hzf1w3P9Y8tjCEp7S+4+6P86epNlq7j7BCHiwcuo3g X-Received: by 2002:a05:6402:4413:: with SMTP id y19mr31275548eda.142.1626707123344; Mon, 19 Jul 2021 08:05:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626707123; cv=none; d=google.com; s=arc-20160816; b=CGD+1RKkHXT52+6oCiEmDJxayISLRpLOZti+E3fDZRZ1r5h8NFJiAekAPN3XervY7y 2EQh8k8VLUB1dNlYx3hfR88FDJeWxoS08sISKpP90nkZfvds1mqxqhU/TENy0qX4Hnyn XG7FTxzVYKGeOk6cfSb73fxIevnhYA48fwLMy4q0w5QZjtg9QABJsURi+XktzNN4HbDT TLDVzrNYs2W84dKInvSy63O6VzahzklpsqYf7rmz2R7garHu1mFGPbIQoQaL6sNaRDfO dOGLyVfp/Sn127EcRFnvpDCSRGYvmR6m6cODcVqXxMeILCYmpjw5KGZuXGd/jQHzZHRF pxXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=PWVvF6lvNv5gvHIcWqMMQuzGQYWIoOLzLx2aq2Ik5Ic=; b=LBuJ9qf/D6bBnJJX2z8mR0wL156BBc9n8ivdzLKFelE7nl7m9X/yh3sjHZJYP3XmP6 px0+4ULVWx52BXx1vr2SQBZWcaqgUz/L/fymtr+3sBRv/VR7own45p/e1xi2EwPrRbY4 0oEastgUGhXCroLQe/g3loiZfUQF9UvOMpxa1zouAoYJo25EgjatYhMn7vGXJzrKF+ax KqWAEHQJ7XEY9u27Wwc722Dw/hFIRf350LW5/krhua8iGU/Y9enNtEBkmyuNi6/DCunj chRG3Yf0gwMpMBmqo5/JkCMk42hqC1QHjQMxgYpvmShGV601ZrnxUiuwE29WKrPPiVrz Qgsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OYQoZMv3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f2si23524440edl.338.2021.07.19.08.04.38; Mon, 19 Jul 2021 08:05:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OYQoZMv3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242250AbhGSOUr (ORCPT + 99 others); Mon, 19 Jul 2021 10:20:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:54020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242264AbhGSOT1 (ORCPT ); Mon, 19 Jul 2021 10:19:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2640A61073; Mon, 19 Jul 2021 15:00:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626706806; bh=WAQuxWIlNPd2b0uqYifXkaNozvCoZsBxDPZ2UQs77LI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OYQoZMv3NatXyUbETGc0aynTQ6SWTz4Le48HCKAg3icNJVqm1vR0sG3Fv28ftlbq2 nObHyYNGEdIhgbNgFfkoeNLUEEVfmUqpxdHeQyHSUke/YazRN++PWKq0kQAhpkPmW7 gPI1BdSJR4qboF4nX6O0svmhFEcUsct6NZMp7lT8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Abaci Robot , Jiapeng Chong , Jason Gunthorpe , Sasha Levin Subject: [PATCH 4.4 105/188] RDMA/cxgb4: Fix missing error code in create_qp() Date: Mon, 19 Jul 2021 16:51:29 +0200 Message-Id: <20210719144937.583603836@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144913.076563739@linuxfoundation.org> References: <20210719144913.076563739@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiapeng Chong [ Upstream commit aeb27bb76ad8197eb47890b1ff470d5faf8ec9a5 ] The error code is missing in this code scenario so 0 will be returned. Add the error code '-EINVAL' to the return value 'ret'. Eliminates the follow smatch warning: drivers/infiniband/hw/cxgb4/qp.c:298 create_qp() warn: missing error code 'ret'. Link: https://lore.kernel.org/r/1622545669-20625-1-git-send-email-jiapeng.chong@linux.alibaba.com Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/cxgb4/qp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c index 07579e31168c..67e4002bd776 100644 --- a/drivers/infiniband/hw/cxgb4/qp.c +++ b/drivers/infiniband/hw/cxgb4/qp.c @@ -277,6 +277,7 @@ static int create_qp(struct c4iw_rdev *rdev, struct t4_wq *wq, if (user && (!wq->sq.bar2_pa || !wq->rq.bar2_pa)) { pr_warn(MOD "%s: sqid %u or rqid %u not in BAR2 range.\n", pci_name(rdev->lldi.pdev), wq->sq.qid, wq->rq.qid); + ret = -EINVAL; goto free_dma; } -- 2.30.2