Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3760140pxv; Mon, 19 Jul 2021 08:08:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDS5aSrZtzpF03l/LQwp4iBEUruRRWoOeTMPveRl6TW/4W8M0j6PrkZ0Oj6JnM81GwPosM X-Received: by 2002:a92:6805:: with SMTP id d5mr16858747ilc.286.1626707292849; Mon, 19 Jul 2021 08:08:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626707292; cv=none; d=google.com; s=arc-20160816; b=WTBdGjL0eySpOOTyJqQ4qfWDD/puU/BSNiulzujjmSvD63q/FsvWjb4MsBdCwrt8w/ C0ZIGBitLGFLcQSU94bHX1EqbzONMJ/U5Vny2FAAXsBX+LusFPcUDExJLaVttzzccNj8 vCrrBc7UojM9PQm4bMBHgWJyka1jY2Bv2Iu5sIJueRY+KWX9Q9dS6redBZS/Gomx07b4 rOjEzjm3/pDuSX41hcsPP3JkMgLOZ+HO1sFLB+X7wKkXRDFeqiYOAlkiDzih4JmCMOm1 yE7HTn0f/Zggxsz0thZv5WoH++hrmpQRtl7TlBXZ3bTcPHH9mgIc4k7I7kXppAcr5S4j HgNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qHIfCKzIB0sDAwGF8ZnoeIQ7sXUR31EPgg+/Etephrc=; b=jb47nkNmem8VcczCz+dPJVKTb6BtvNr/KgyWjn4p3QRc8oIrJFZXPPY6Z+vCRGzK6x 7gjo7ao2dq0xcmPm0b03kSqSbEwIeQvmUzdJIrKCn3XKY9/JqUyydpmjdD0ncpMHTNCA ivhvWzDDwrG5QjBlLV+KOFNyE2TZNMUXTdBJuvl2y7aR2qhnsaBW2QynY4MnstaIgOSA cXY8MhYn0oCBtxI+2MTgirVrjLmJFWOMHiLtUl+epPiygKqWfwC6WbHOkWMQwyM6OX9X NP78knPx6TDTWu55hGLSLdip3A7YexGwCZJg2IwEROnrugsN0m3SlpnIP0uevWhtubLc Hzow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=cxPJvplq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w25si9690239iot.26.2021.07.19.08.08.01; Mon, 19 Jul 2021 08:08:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=cxPJvplq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242941AbhGSO0Y (ORCPT + 99 others); Mon, 19 Jul 2021 10:26:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:58284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243550AbhGSOYI (ORCPT ); Mon, 19 Jul 2021 10:24:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 44A206120C; Mon, 19 Jul 2021 15:03:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626707031; bh=+hnt326u6KahrNWR5EAQqr78GZbHzAxkOOoZn0JySks=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cxPJvplqsUNoREXdLDQ8eZYsF4/bvsTLY85zZSDvmHJkh0sxLbttxDHN5EGAmXg/T lFoECk9V+nYsjGpIstIhC9O2lxGqMUWM32khq3tPhU+s3Q/M8T2qLthbuVrUqKtRld /dUZbu+OdX/lq0unudRhqRy/7ZsExV3yLcJmjGOs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.4 186/188] scsi: be2iscsi: Fix an error handling path in beiscsi_dev_probe() Date: Mon, 19 Jul 2021 16:52:50 +0200 Message-Id: <20210719144942.577641024@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144913.076563739@linuxfoundation.org> References: <20210719144913.076563739@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 030e4138d11fced3b831c2761e4cecf347bae99c ] If an error occurs after a pci_enable_pcie_error_reporting() call, it must be undone by a corresponding pci_disable_pcie_error_reporting() call, as already done in the remove function. Link: https://lore.kernel.org/r/77adb02cfea7f1364e5603ecf3930d8597ae356e.1623482155.git.christophe.jaillet@wanadoo.fr Fixes: 3567f36a09d1 ("[SCSI] be2iscsi: Fix AER handling in driver") Signed-off-by: Christophe JAILLET Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/be2iscsi/be_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 758f76e88704..c89aab5e0ef8 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -5812,6 +5812,7 @@ hba_free: pci_disable_msix(phba->pcidev); pci_dev_put(phba->pcidev); iscsi_host_free(phba->shost); + pci_disable_pcie_error_reporting(pcidev); pci_set_drvdata(pcidev, NULL); disable_pci: pci_release_regions(pcidev); -- 2.30.2