Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3764392pxv; Mon, 19 Jul 2021 08:13:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOKmGs4xBEhtYhRuaaJNrK9re7P8nDXPLRmIoTnfb4wLCJSRfWK64GDciirDBcfzd7P40E X-Received: by 2002:adf:df12:: with SMTP id y18mr31045133wrl.189.1626707587872; Mon, 19 Jul 2021 08:13:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626707587; cv=none; d=google.com; s=arc-20160816; b=RWKvRePMooExb7f9jkKmUdsgAX8oT9etWPGrWlYbeqlHA3SyMyhAQKHcT3H66Cd5j3 w0LoQXTfnG4FV4aM7ktZUE+5S/uBGHFfWnPaMoQVIMCf0xLQ6YTQs912bqpxTHJvfQA0 WUDj1Sqky07AkUX3LRI0zU4PlGrFT7SinxPBg87Yh40FGNu6GMqPgEXebli15RidqkWK +PVWNoB/Z7uYQY84wiGhJpXWf29ktRdCfVoIw340pOQWw9CjLHm1YUcqFmg6k/AXf7OU ZvOS89R5HojbXJGMtlLXnukT0OzJAqApW35Whx8A4ORTvpegP+Glzxg7/+fqyeVJiC9w IWUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Xgowx8XRrFYr5Y0aKwux2islqhVD5h+RkxUJmhfzy84=; b=PHZcL33y+nqRq3gLhMw3qn3rJGE3ZQUjJrAqruSKNytCrpplGDkHhpVbYr64q8oTpf uwulotbR358tyFAXOeQdB66qRNvN7fvqEeQcBAgWSqsap1k0id+NXIgf7tBsNrKv8jLY JGJs+n5CNzVK+4ApQmKfoSVBP1dm+Mh0RioGnUvZs47QrojGqE1AOxO8BEfEdQ1CpjLi vNI+dFfSwQWDNNCe6MLcyWd4dHEF8Sbjc+DwgzE5ChdVQW2lL8QUWeMDNhcwhsBnXxhF Rktrn9DqmYBIepBnYpils9UaF4WUGs+jozM2hiEC57YHDVtng75jkprpdpMHYs3m9x0x URJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="N/4Fj9zC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bz24si20557964ejc.249.2021.07.19.08.12.45; Mon, 19 Jul 2021 08:13:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="N/4Fj9zC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242683AbhGSOah (ORCPT + 99 others); Mon, 19 Jul 2021 10:30:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:38198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242840AbhGSOZZ (ORCPT ); Mon, 19 Jul 2021 10:25:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8ED3D610A5; Mon, 19 Jul 2021 15:06:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626707164; bh=I3izLJNUmoAdfeCBSK9qtUKZYViYQap6iNtnK9J94ug=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N/4Fj9zC5BZFcXOTJHcxyhtw7mgzAVgqul28jSXMTd3D5/du2o6lZ3lTsvqapGv2N dBJB0MYQskYMcpeqeQTj6iEkCnfBpMXM8k+wvaEcAeZy4Gl7G2hPX7aQ6uKmACgYVL 7oi7BwxFhA3r0LhLvwzGjimceZKcgAp5sipnvweg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hanjun Guo , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 4.9 053/245] ACPI: bus: Call kobject_put() in acpi_init() error path Date: Mon, 19 Jul 2021 16:49:55 +0200 Message-Id: <20210719144942.113474563@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144940.288257948@linuxfoundation.org> References: <20210719144940.288257948@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hanjun Guo [ Upstream commit 4ac7a817f1992103d4e68e9837304f860b5e7300 ] Although the system will not be in a good condition or it will not boot if acpi_bus_init() fails, it is still necessary to put the kobject in the error path before returning to avoid leaking memory. Signed-off-by: Hanjun Guo [ rjw: Subject and changelog edits ] Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/bus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 6b2c9d68d810..1c13e5fe10d9 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c @@ -1184,6 +1184,7 @@ static int __init acpi_init(void) init_acpi_device_notify(); result = acpi_bus_init(); if (result) { + kobject_put(acpi_kobj); disable_acpi(); return result; } -- 2.30.2