Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3777655pxv; Mon, 19 Jul 2021 08:31:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEPJYqehk5DfThRV75Xfc/1VreBvxJPGetOL+wM17mNUmZa5uIcvsrsFLeqlj89X6kuI8q X-Received: by 2002:aa7:c74e:: with SMTP id c14mr35064927eds.40.1626708663028; Mon, 19 Jul 2021 08:31:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626708663; cv=none; d=google.com; s=arc-20160816; b=zXSiYRHysX7JYSGrht7LXF/aipQ9ZXWPSsUuGrDu2/WqRJc12Z9CboXLEj7onSPmdl UvPy0JMzzqKV0VnV0CmPcfl7BVSXKAjG2Ym3udHdYODQvl3SJF3VyLUV7XrNMelsr/gD ktmXuYJlFpMzpWRDJdqvi3IPZ/FxsFq1yI84ND52alNYS5IhkAxjHJaQ3HEcBRqZ+TmQ 5eqg3EWYWRb8iP3x80tDJUMGd7FBI6ipecNpEatvYHribIurF9oE9e5vplmECOvAUDWR sTk3KCkU7nhXZtXjzYbGvVsBfNtV7Kb3q31mXlpZTQQwu5+VrWJyElmcev0eVJRLfZ7+ iaTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+CagBgxvp2kEcghbwQl4wKloqB7ADw/Or+UxQLvxBe0=; b=YGlWnqYwhYzRGK+8KdOt/+72GbJj0KXBRWevi9Y1rK24jif8RDzQ7MG51PynINyCyQ IgwIEaU2ORSpv4RnLyj4CFyhWtJWUytLbM1Yw1s4NeFoBZ3lgoKZ1uxX55VdYgfXjNyt 1twYq65qvpg/RVnIXDwuEQWbNDI6UENByycNWLUVj+GxseMBANuCl+NLi3l6mE5YhvWX RtuNyTNpcbkWCIkulpEeqskCdCunF4TQM5ev1Yu5brCsxxSiycJPcbGDo5CpbmuZaNEn XW1BKzrqp+uQL0hIhPZMoou1kGgU6LJkdDN4xsYdDMekdCggt2U6BtLtBJ0NCZAY1w0M Xs3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="mZvoY4/6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lc20si20696415ejc.538.2021.07.19.08.30.40; Mon, 19 Jul 2021 08:31:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="mZvoY4/6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245648AbhGSOm2 (ORCPT + 99 others); Mon, 19 Jul 2021 10:42:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:47206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244301AbhGSObG (ORCPT ); Mon, 19 Jul 2021 10:31:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 510D96113E; Mon, 19 Jul 2021 15:11:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626707505; bh=8erM4yy4DXfOGEcPzvo2oM60PZSoFIAWrTWHF0PB67E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mZvoY4/673q6WAORDm9WgksfJBoReudaUdA6JSxk9JhHOTAmv2CHemDFdLf/1kNBN 8rsRrKPRyA/k/51ahbMdOFTYH47IpHSeew5b770WEqbW/WdC/6ZyLFzof0v0n0MFay csd8aL3dJc23ilddLtUBknHpSe+AQWfQjhHo3LuE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+af4fa391ef18efdd5f69@syzkaller.appspotmail.com, Pavel Skripkin , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH 4.9 174/245] media: zr364xx: fix memory leak in zr364xx_start_readpipe Date: Mon, 19 Jul 2021 16:51:56 +0200 Message-Id: <20210719144946.019024555@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144940.288257948@linuxfoundation.org> References: <20210719144940.288257948@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pavel Skripkin commit 0a045eac8d0427b64577a24d74bb8347c905ac65 upstream. syzbot reported memory leak in zr364xx driver. The problem was in non-freed urb in case of usb_submit_urb() fail. backtrace: [] kmalloc include/linux/slab.h:561 [inline] [] usb_alloc_urb+0x66/0xe0 drivers/usb/core/urb.c:74 [] zr364xx_start_readpipe+0x78/0x130 drivers/media/usb/zr364xx/zr364xx.c:1022 [] zr364xx_board_init drivers/media/usb/zr364xx/zr364xx.c:1383 [inline] [] zr364xx_probe+0x6a3/0x851 drivers/media/usb/zr364xx/zr364xx.c:1516 [] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396 [] really_probe+0x159/0x500 drivers/base/dd.c:576 Fixes: ccbf035ae5de ("V4L/DVB (12278): zr364xx: implement V4L2_CAP_STREAMING") Cc: stable@vger.kernel.org Reported-by: syzbot+af4fa391ef18efdd5f69@syzkaller.appspotmail.com Signed-off-by: Pavel Skripkin Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/zr364xx/zr364xx.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/media/usb/zr364xx/zr364xx.c +++ b/drivers/media/usb/zr364xx/zr364xx.c @@ -1066,6 +1066,7 @@ static int zr364xx_start_readpipe(struct DBG("submitting URB %p\n", pipe_info->stream_urb); retval = usb_submit_urb(pipe_info->stream_urb, GFP_KERNEL); if (retval) { + usb_free_urb(pipe_info->stream_urb); printk(KERN_ERR KBUILD_MODNAME ": start read pipe failed\n"); return retval; }