Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3778986pxv; Mon, 19 Jul 2021 08:32:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySPen1ZNhaChY/pFYwyZMAHeFF7d8+LMHJJFNT8mXp3N3Cz4YuDgHzrQH1K3gSH7ML1kEM X-Received: by 2002:a5d:93d3:: with SMTP id j19mr19073355ioo.184.1626708760721; Mon, 19 Jul 2021 08:32:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626708760; cv=none; d=google.com; s=arc-20160816; b=JT0LHLyyzqYGd9EhXSBiaK5TtzkObh09uqKHJvcUfofELdRYLvolVmBv3rs63MEZxK Mqi9XAf9cmsKEnU3ABuEgWy9z+jzWTsS8KQDjWGbhTasLmkX7bTsglDiTonzuu6bXRqo xV2EgqHeSaCF/AZRzDDcBfmsU0j76+ZG/64gae6fiItZ60D2PQq+XihA3nibX/XG8qNw yRwGjjO+nM3yNymUEXlqJ+l3GKa45kW3UFJALFDf3BMfrLZZDoQVpUzsWwJCgGPwEqSj oDNvb7fUXtBdRCkx3W8u+1pLaqafIBp5MpbabcDYIdfr1OOLxPAMITEOb9ft4Nvmca3p LXPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DIEhhugK364vlZ75jvgEdR+6mrdCurVf95srKVPogIQ=; b=MT7kCVmctMRJkBY6IJXpRqCN0wXXHZ+NgyTU6djDDPgOYrkknJxZPhjfWqLScPS14Y pdP/0kD3oM+/MFJZErBExKtTyIc4EhbPn4ojUpriy/PGMq7XWkp3pBmcWlSi4/2sQm1F Fg7Gp7JjYnGlq16ZAk+MjrB/aBMkgYdtzE65GUmcs5kcP1BoKeh1UKmCn8n4dJTCPFa4 IFgiBJnjZ5oJNBH+RGmaJyZTZRy309k+iYuJWqvn18KkXDnrYal+gUA9wXNEroQiD+lI 2e97B9EDv95sQfh+H35D0QozFSX+3b2SzTzMDdKl52iygOPF1PhykkYIpvtjttrBdntg WOOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bxuKd4E3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r7si10571419ill.122.2021.07.19.08.32.27; Mon, 19 Jul 2021 08:32:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bxuKd4E3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343988AbhGSOsh (ORCPT + 99 others); Mon, 19 Jul 2021 10:48:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:47966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243749AbhGSOdB (ORCPT ); Mon, 19 Jul 2021 10:33:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 78C22610D2; Mon, 19 Jul 2021 15:13:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626707582; bh=qe3Gf6gXUqjrNfTGZ+MpZXhbBEVK9NZ5viLV5Q8xl/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bxuKd4E3fk3QKFDPdFj0GI7BaSCGlgutlDzhSwpDf4Wc/iVedbx2c6tX2Q1ZzZElr D5ORmKLsYhcmIM+uxWzNsIMX/sjsx30J2bRYqufIn3nZ+UlrpfbZ4MQlfNE1Zlgflc zaDEKXtCZBbOwpsu8pLDxUxzsolZ3Avu94rgOu50= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Xie Yongji , Jason Wang , "Michael S. Tsirkin" , Sasha Levin Subject: [PATCH 4.9 222/245] virtio-blk: Fix memory leak among suspend/resume procedure Date: Mon, 19 Jul 2021 16:52:44 +0200 Message-Id: <20210719144947.558265762@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144940.288257948@linuxfoundation.org> References: <20210719144940.288257948@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xie Yongji [ Upstream commit b71ba22e7c6c6b279c66f53ee7818709774efa1f ] The vblk->vqs should be freed before we call init_vqs() in virtblk_restore(). Signed-off-by: Xie Yongji Link: https://lore.kernel.org/r/20210517084332.280-1-xieyongji@bytedance.com Acked-by: Jason Wang Signed-off-by: Michael S. Tsirkin Signed-off-by: Sasha Levin --- drivers/block/virtio_blk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index e57a1f6e39d5..302260e9002c 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -800,6 +800,8 @@ static int virtblk_freeze(struct virtio_device *vdev) blk_mq_stop_hw_queues(vblk->disk->queue); vdev->config->del_vqs(vdev); + kfree(vblk->vqs); + return 0; } -- 2.30.2