Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3789031pxv; Mon, 19 Jul 2021 08:47:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJN+e+4ANsEvw0csYcH+7DHTX9bLH3nemIOd7FZAK0+unChKRRYE8rnvnhoBKu6yAEQXyg X-Received: by 2002:a92:c206:: with SMTP id j6mr12965093ilo.152.1626709626489; Mon, 19 Jul 2021 08:47:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626709626; cv=none; d=google.com; s=arc-20160816; b=l9Q3LLd5eMLbB1mb1MqAlI8JPEz40/ywZdQsn6hb69mLdNFDvR7A03Po4fmQ1jjDXe 3j5Jxkdq7mhzXU3ed7mHHp/XAyzbp7XOYKy4of6PKmcUjsqeO1qq5I56BHfWSoruimcP bBFYQMGRiiGN2KONMPZUoMXPhzIK4sMdmWgFvRp/GY/Tl62HtfPZbI2VCKeFHNv/hDt7 brohfBwtA6iif3K2TzLluQe5ruUkTG6br4HzGbi5+GHVVsAwnNL9114T92bFtFvFIdoP qqSEF5CVbR6lhVU4c+G5F5Tnsuwe4WVepMt8u5RE5smYmT5n6DFgF9/wOLMfpYMTOfeV Urvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=XZtPRjtP5AtRmIBM4cTpwZURqVgSjpRX89R7IQfv4ts=; b=EIqISldXVvxO8R2rLba5uWaxeojtopyHUU5tzERLQBD3mQ8L8/nO4uBgwM2EwWOgw5 uauKsLlMlc54jq79bSYHKbdcGQ76IgzvrkmXJ94zBftMZlsLE+aMtwhI7iFQzCrAvfxF u6cYdjVRdL+kBHyNqLhKWJRimH/PF5byJw5wiWBB1Z9x+wRCmVVywy/yzQgcJVeWs7o3 hHCTyeHKUCSNTFnqDWn+NNrvtx7//TClE8XdRp2bMevWdhKrfyf9CQ7vsvxzfcEyh2gM fr6oMuv72bNqv6gecn0QsWcFnAn5vD5BHbpACp+G0G8SJAwVuV2DjcGPpNKWiZfFL1z9 KmQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wXnOU7qL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j3si16162468ilu.69.2021.07.19.08.46.54; Mon, 19 Jul 2021 08:47:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wXnOU7qL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344115AbhGSPEM (ORCPT + 99 others); Mon, 19 Jul 2021 11:04:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:34614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245084AbhGSOlm (ORCPT ); Mon, 19 Jul 2021 10:41:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4740B61222; Mon, 19 Jul 2021 15:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626708092; bh=XVELak/A53j3wbXPO7smMGauYy+KwP/a/wsJCFJNp/g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wXnOU7qL5yX3K0Bd5VavJKEZV2JA9QH3ERnk4gfXpAPfZbGsk+LaeRTInkSfTsVcv E87IDA/lITNn0WLTM+tt5FaHXCo/6pvKdeupf+yrPq9jDtDLrY/fFKOz1DzyrfP2sD ZXL2pbmR8pev7p9AlzwBoeXXhZVuOf1pwEH06lQM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Abaci Robot , Jiapeng Chong , Jason Gunthorpe , Sasha Levin Subject: [PATCH 4.14 176/315] RDMA/cxgb4: Fix missing error code in create_qp() Date: Mon, 19 Jul 2021 16:51:05 +0200 Message-Id: <20210719144948.678494534@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144942.861561397@linuxfoundation.org> References: <20210719144942.861561397@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiapeng Chong [ Upstream commit aeb27bb76ad8197eb47890b1ff470d5faf8ec9a5 ] The error code is missing in this code scenario so 0 will be returned. Add the error code '-EINVAL' to the return value 'ret'. Eliminates the follow smatch warning: drivers/infiniband/hw/cxgb4/qp.c:298 create_qp() warn: missing error code 'ret'. Link: https://lore.kernel.org/r/1622545669-20625-1-git-send-email-jiapeng.chong@linux.alibaba.com Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/cxgb4/qp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c index 15a867d62d02..325561580729 100644 --- a/drivers/infiniband/hw/cxgb4/qp.c +++ b/drivers/infiniband/hw/cxgb4/qp.c @@ -277,6 +277,7 @@ static int create_qp(struct c4iw_rdev *rdev, struct t4_wq *wq, if (user && (!wq->sq.bar2_pa || !wq->rq.bar2_pa)) { pr_warn("%s: sqid %u or rqid %u not in BAR2 range\n", pci_name(rdev->lldi.pdev), wq->sq.qid, wq->rq.qid); + ret = -EINVAL; goto free_dma; } -- 2.30.2