Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3792814pxv; Mon, 19 Jul 2021 08:53:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzV5C269iP/wAztOu6q928YaTyH6YDmWnM6fZ3keHjJcjrvZUOZSpqygGfpbMHvj6PiON9h X-Received: by 2002:a02:7348:: with SMTP id a8mr22284538jae.116.1626709983394; Mon, 19 Jul 2021 08:53:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626709983; cv=none; d=google.com; s=arc-20160816; b=VB/lU3JV/Ph9cjqNhvWcVhAAaLd/IiekRZa2CUS/LdLgTI3plzNRy+I24yk1kcB5Y0 SBJHCag9Pi6Pl4ZIY0T7RziwsDtwhQSa779vQOo3s+xuL97mAEOtBgNopBbhh7xYyDGR B5Fah9e5i/cpBRDFIY1cFHDYhZbsHofJFSP90MVC0udX5Ma8yEnlIuDXh+uvOoBr5qC/ 8hVmNQzdoho5ZV9sFjt290OFSJxRNtE8AwaEdxwubqZtMTxEV6By3l3UQQa65su/LVtS ZxLmtYIeqGmYXcguCk0Nt4b9B2Od0pyRIS2YdrJjaNMVYv3pD01XZBHvS2ITTu/QwGeX mBiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YLChZoO88CjbN2okUOfQX7aW4VNo2txfCXMsWp4jDzM=; b=ktmOyztpD2GvORNyubOtZNaqAqtx7wa/PQXR0TRDECyJnwelnKbpTvLK3QYR1hqyNs OWiAEotQzHXFSM0FrCsnIkyAIKi2AOwCAqSOCTuGqiqiGXrC1S/wWsIo/Q7c3AHrkiC3 7f2k97UMegeU9Xr4fM5e3nr8Z0O/A9ubZjsCDXJwKg58F8jDs5QrQIwakuohj5sr9gul nYeQm4lLrxorA5Ft1a0Vu8mgjTenb4Pcz5Ys2z467/2vPpnTyztYQhfRAs+2C0mzqwJL yByUF8PQWdvnLM7rsoCfUAvnd4QvVKdyVnQRV2mBcRipoOcYkUMtN5RWDBm1rp2FPcBy E78g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=cT5lrmCi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 5si10017194iof.82.2021.07.19.08.52.51; Mon, 19 Jul 2021 08:53:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=cT5lrmCi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345771AbhGSPJh (ORCPT + 99 others); Mon, 19 Jul 2021 11:09:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:60916 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237790AbhGSOoY (ORCPT ); Mon, 19 Jul 2021 10:44:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4E1CF60720; Mon, 19 Jul 2021 15:22:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626708170; bh=8J9kJJ9EHtGeWJREWRcr1mgVhUFSE4cN98tN2qZFEYo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cT5lrmCih4sCZMd0Rw7vEDBBbbwHugeoTLBdoMmfBiM+zswKCCZjswOJqSLzB6I2c SPHJFRGXCcmTMlfaHh3n1+66kZjptu5TpLDiwkGf/MZjR0pCAN87KFDl3U1dvYAaQE t+o+ynhcHTbMbQytzemH7i+NyhV2BALGoX/L29LI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Christian=20K=C3=B6nig?= , Jing Xiangfeng , Alex Deucher Subject: [PATCH 4.14 208/315] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create() Date: Mon, 19 Jul 2021 16:51:37 +0200 Message-Id: <20210719144950.266326857@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144942.861561397@linuxfoundation.org> References: <20210719144942.861561397@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jing Xiangfeng commit 9ba85914c36c8fed9bf3e8b69c0782908c1247b7 upstream. radeon_user_framebuffer_create() misses to call drm_gem_object_put() in an error path. Add the missed function call to fix it. Reviewed-by: Christian König Signed-off-by: Jing Xiangfeng Signed-off-by: Alex Deucher Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/radeon/radeon_display.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -1347,6 +1347,7 @@ radeon_user_framebuffer_create(struct dr /* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */ if (obj->import_attach) { DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n"); + drm_gem_object_put(obj); return ERR_PTR(-EINVAL); }