Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3795915pxv; Mon, 19 Jul 2021 08:57:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJww2kk81w7SXuB7cjoyURqAbcFAySS0Tt08hUuz4M77D4ZMVU9lX0XKqpDuYtw4wDz7JkQb X-Received: by 2002:a92:c504:: with SMTP id r4mr17155909ilg.131.1626710261496; Mon, 19 Jul 2021 08:57:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626710261; cv=none; d=google.com; s=arc-20160816; b=iQMw0ak4B+L74b8bL8t3oYFFE5QIa7C1rTdWAp+MUkJrnZqQw2rxfdLFhHirCQF/sB 1Op1BoI1GEyYaRqe0tDXZ2yWPQMh3HtUP5NS4DlCa9Cuhfqp7rAjpyYz+uQcWWvF0Nw+ EJUzSW1EvmZrv0VlhUVS1850ul4dMD3/ur8mop8JqDCC4okqwFw2HPQT0+egnZo5gM49 mxgD9wjQ1Fmt6HcBusjxQv6RqdXN1F0shtcKmBUJ11o69KNQUAI9p6bK4wpEQ92aFaxu x0A/DAE3tTtuL7PmgDtsbrNrexdZ3/m9YEDBUfNEg2stCqa7uwTTXl1incw7hVXZKSwo qG/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BgezM8zu2MHi1ttWjObt/EzzoJTb3t3vJ21Hd1ONBPg=; b=dyM4nfOqWN94Ac/eoSnpANHbfo9/AxY4Ncm48PNIR69OW3VZ2ynINQGruKrpC4KyQe MxL+o8R9mb+XMIQ8di9IBSPcHgJwS7F0RcZcaE0yyUFV3R/d6fGOA0w3C8wNW7BdE9qN 2XEg10kL0eLIk4lMVFcoQIPo34L3gJLQtjS5+cPR8Q/wcHv62SrWH4JzfmziGc4wMve9 8hU4BsOvmoMsiYk1sZi7QFXlABa0RdoYG3l0qCR/XyT6WGmlrAUF1zttBlOU0OibMrxH cB9HcNoh9csGN3opPN+wSCBoXEpnWXrTa1eku7i1KfvBc10N36Cysrfz8a2K0nom/h0d o7Cg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=U5f4DABM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x5si726794ilq.85.2021.07.19.08.57.28; Mon, 19 Jul 2021 08:57:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=U5f4DABM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243877AbhGSPOF (ORCPT + 99 others); Mon, 19 Jul 2021 11:14:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:40458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344235AbhGSOsn (ORCPT ); Mon, 19 Jul 2021 10:48:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9FD9460720; Mon, 19 Jul 2021 15:27:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626708440; bh=i+G2kUEBmi+G1M3L2rdcYPgBks09r0PBN1osL1oZ6HI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U5f4DABMY82GRLdMLauahlZGyk7/HH3TQkYM4GRt4bPEWPEgD81DQ60zANk4Qnms5 5Df6i5ZXUrvQTT50eAsxVF5AANddz+McpUs2l2wDIgTGMd55eeTCshg3vXEY95YKOp wNOLnG6WyL0eDZ+Cw/DcR089QPfdxvilJdt+bC1k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.14 311/315] scsi: be2iscsi: Fix an error handling path in beiscsi_dev_probe() Date: Mon, 19 Jul 2021 16:53:20 +0200 Message-Id: <20210719144953.709293484@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144942.861561397@linuxfoundation.org> References: <20210719144942.861561397@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 030e4138d11fced3b831c2761e4cecf347bae99c ] If an error occurs after a pci_enable_pcie_error_reporting() call, it must be undone by a corresponding pci_disable_pcie_error_reporting() call, as already done in the remove function. Link: https://lore.kernel.org/r/77adb02cfea7f1364e5603ecf3930d8597ae356e.1623482155.git.christophe.jaillet@wanadoo.fr Fixes: 3567f36a09d1 ("[SCSI] be2iscsi: Fix AER handling in driver") Signed-off-by: Christophe JAILLET Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/be2iscsi/be_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index d7ed1ec02f5e..a1fd8a7fa48c 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -5737,6 +5737,7 @@ hba_free: pci_disable_msix(phba->pcidev); pci_dev_put(phba->pcidev); iscsi_host_free(phba->shost); + pci_disable_pcie_error_reporting(pcidev); pci_set_drvdata(pcidev, NULL); disable_pci: pci_release_regions(pcidev); -- 2.30.2