Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3841255pxv; Mon, 19 Jul 2021 10:01:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwl6CJX8Bwkiz0NrzOXDlY3F14fF+d4U9Pdx6nU2FUre5G0T2gNwU42PyMvfCUhHj6WjyCA X-Received: by 2002:a92:a013:: with SMTP id e19mr17479290ili.206.1626714104126; Mon, 19 Jul 2021 10:01:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626714104; cv=none; d=google.com; s=arc-20160816; b=MhIVC7NuMuQgdkOxhSvpI6vbS6X2wiawBjwg/MJu7YQJlKB2XAEWk2cDT8A2EgENkV ksXH+Zv85ZWb9FiFtTTyP+DrlqHmjjNrKmXmXGNuRomF4eCFmV3MUSYtdEpHN7Baxd2y PIPVcGEUPQcOuOP2mGFNApzCi6xomkFrXcXE6jte5Dd2sipzV1Y9p83jDHtsTGVjoJ2m 4iW46Cky+tXeTmJcI/EPuVHZjnYWIEoPrSo6lk3DPSpFN3Idk6ONFVgS/HoEGOefsn5+ 9l1jgRPpzqbqcaTYMvG5VgM3Rb5OKbkOafDdszzg62Gc8HlsbPrK3XLdDCVgpO3Ef+Cm WX8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=GieD9EHc/+qI46erZHKQmUfeWuAPa21My6PUTuS8pWg=; b=dmdq0UKNi8qtnLwA2GZEZlVvdM7G3fAXOw3DFBBiI76/Q0jbJ/1k8tiA9IYbbfhoVx Q3wGUlH68jignJSunGibxNscPerWE4jLCQOvxJiRG6FBfcTPESfNbA5+TM/Sk4v8ljx6 tYxW/uH0aneKzSuf7Cvyju9Ad0ejxN+3/bGQ32/9uQASUSh95/ZVaJPON3OombtDZ3HH hIYmaIz2I+6z+7sT4UZWdsFAXwRJM2b3ORdJkRzw7Ydtk5ll0GqTiysVKZMDYO1rVVqn igkeUOdw+nCc+G08Cl+RrhA/4HIyTW6fIeMSpmyV+FCmBeVXPzZ/BoyyX2GVlDJrwTOh 611w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wSbx1pJx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a6si4686206ilv.81.2021.07.19.10.01.32; Mon, 19 Jul 2021 10:01:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wSbx1pJx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352047AbhGSQRW (ORCPT + 99 others); Mon, 19 Jul 2021 12:17:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:47744 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245158AbhGSPKu (ORCPT ); Mon, 19 Jul 2021 11:10:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1D3F46127C; Mon, 19 Jul 2021 15:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626709889; bh=Fry/1E8mbPD6UCOOJj7TJfsf86Evh8iAMVEoW9evQ7Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wSbx1pJxCdeEP743X0HSl4xPVY2mcf+vK4KOwJQr/fArt99R5zZbwO31QS7a97mYq Dqz7HqfIKJzKl0HDceiCRyzxd584BMoHCkqI4+l1L9qGCodW4CRYlz5hYf81y+TtPx c8CZ3obNO2JCNWKQnPHuRznW8DFSsFGNFU+2XzD8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yoshihiro Shimoda , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Geert Uytterhoeven , Daniel Lezcano , Sasha Levin Subject: [PATCH 5.4 139/149] thermal/drivers/rcar_gen3_thermal: Fix coefficient calculations Date: Mon, 19 Jul 2021 16:54:07 +0200 Message-Id: <20210719144934.246491005@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144901.370365147@linuxfoundation.org> References: <20210719144901.370365147@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Niklas Söderlund [ Upstream commit 8946187ab57ffd02088e50256c73dd31f49db06d ] The fixed value of 157 used in the calculations are only correct for M3-W, on other Gen3 SoC it should be 167. The constant can be derived correctly from the static TJ_3 constant and the SoC specific TJ_1 value. Update the calculation be correct on all Gen3 SoCs. Fixes: 4eb39f79ef44 ("thermal: rcar_gen3_thermal: Update value of Tj_1") Reported-by: Yoshihiro Shimoda Signed-off-by: Niklas Söderlund Reviewed-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven Signed-off-by: Daniel Lezcano Link: https://lore.kernel.org/r/20210605085211.564909-1-niklas.soderlund+renesas@ragnatech.se Signed-off-by: Sasha Levin --- drivers/thermal/rcar_gen3_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c index 1ab2ffff4e7c..a0673059bd4a 100644 --- a/drivers/thermal/rcar_gen3_thermal.c +++ b/drivers/thermal/rcar_gen3_thermal.c @@ -143,7 +143,7 @@ static void rcar_gen3_thermal_calc_coefs(struct rcar_gen3_thermal_tsc *tsc, * Division is not scaled in BSP and if scaled it might overflow * the dividend (4095 * 4095 << 14 > INT_MAX) so keep it unscaled */ - tsc->tj_t = (FIXPT_INT((ptat[1] - ptat[2]) * 157) + tsc->tj_t = (FIXPT_INT((ptat[1] - ptat[2]) * (ths_tj_1 - TJ_3)) / (ptat[0] - ptat[2])) + FIXPT_INT(TJ_3); tsc->coef.a1 = FIXPT_DIV(FIXPT_INT(thcode[1] - thcode[2]), -- 2.30.2