Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030538AbWKTXsM (ORCPT ); Mon, 20 Nov 2006 18:48:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030542AbWKTXsM (ORCPT ); Mon, 20 Nov 2006 18:48:12 -0500 Received: from mx1.redhat.com ([66.187.233.31]:40676 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1030538AbWKTXsL (ORCPT ); Mon, 20 Nov 2006 18:48:11 -0500 Date: Mon, 20 Nov 2006 18:45:35 -0500 From: Dave Jones To: Chris Wright Cc: linux-kernel@vger.kernel.org, stable@kernel.org, Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Chuck Wolber , Chris Wedgwood , Michael Krufky , torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk, Jan Beulich , Metathronius Galabant , Michael Buesch , Greg Kroah-Hartman Subject: Re: [PATCH 46/61] fix Intel RNG detection Message-ID: <20061120234535.GD17736@redhat.com> Mail-Followup-To: Dave Jones , Chris Wright , linux-kernel@vger.kernel.org, stable@kernel.org, Justin Forbes , Zwane Mwaikambo , Theodore Ts'o , Randy Dunlap , Chuck Wolber , Chris Wedgwood , Michael Krufky , torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk, Jan Beulich , Metathronius Galabant , Michael Buesch , Greg Kroah-Hartman References: <20061101053340.305569000@sous-sol.org> <20061101054343.623157000@sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061101054343.623157000@sous-sol.org> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1682 Lines: 39 On Tue, Oct 31, 2006 at 09:34:26PM -0800, Chris Wright wrote: > From: Jan Beulich > > [PATCH] fix Intel RNG detection > > Previously, since determination whether there was an Intel random number > generator was based on a single bit, on systems with a matching bridge > device but without a firmware hub, there was a 50% chance that the code > would incorrectly decide that the system had an RNG. This patch adds > detection of the firmware hub to better qualify the existence of an RNG. > > There is one issue with the patch: I was unable to determine the LPC > equivalent for the PCI bridge 8086:2430 (since the old code didn't care > about which of the many devices provided by the ICH/ESB it was chose to use > the PCI bridge device, but the FWH settings live in the LPC device, so the > device list needed to be changed). > > Signed-off-by: Jan Beulich > Signed-off-by: Michael Buesch > Signed-off-by: Andrew Morton > Signed-off-by: Linus Torvalds > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Chris Wright Since I pushed an update to our Fedora users based on 2.6.18.2, a few people have reported they no longer have their RNG's detected. Here's one report: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215144 Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/