Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3889624pxv; Mon, 19 Jul 2021 11:12:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYMPECFUz7dg8MZmKsl0LKAvuXyBoSTFD2YdScAfdT6yi+v9RnnX49GnbYAokVM4atCHaf X-Received: by 2002:aa7:d353:: with SMTP id m19mr37100443edr.162.1626718349274; Mon, 19 Jul 2021 11:12:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626718349; cv=none; d=google.com; s=arc-20160816; b=gm80QKwvfdjIEKbulJ08D5/cownCvHveVLooZiuY0j9VgOL+LGi08MOMWAEFIsWCoC pxyYnBs7hRejzcDQPAx9FLJKSvwinOCtIrppPBoOarbuKt+GH6eqEa5cJk+RZdXPSoiK 4nDF67VoDi+TrGzc9ys2NAGkEphpvN+JLb5ogX91HrP36AnePevGUKdbGtjrwnaeNS5x FftQDPwgxrfeD0c5dXxtbrU1hgwjqI1KA7QK50xe5iaU3X5InWwSb3w6HyvKsyfD35ih WeiXlSYPEqMpDAp/1iHj3nxL90HHZf/fl0oTJf5/B23OiS1fyHkpjTKvwHWLTEN9j6C8 HDag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=e2fL5KtFXjuWNfdrNP5q44ypGtzeBDgp0pnMGqIGuEo=; b=WpJSLlppkouOiziIr2PCkrbkVC8HVoPIue7pgdiyTYobg07J/H3DOi0VkXN5TjX3TN xCU4YeVH4xPQkeLSgIZQE7osPSe2lIx705jnh41QakLZCj5Igj/2w4SZeYINPzUmLVdj qemh1S01MGSytKmm/nBh+ieif0AUry8XI1WtVafUmGM61BeC8AatCDNDrMQja5ijZOi4 5lZuhZj+RVllivICQsZMarWjbQk4xw60MzmDYbYmLAAUspyQh4gY9TCdesMSn0iVpprs N8cQct3UW8Hi7vH+Cpsbnp9tyVXrBqTBj6sJmqgLk7vbmBFX7cb2vgkmf5QHUQhv+xHI l/aA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qVi3jE2d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v9si17986465ejk.222.2021.07.19.11.12.03; Mon, 19 Jul 2021 11:12:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qVi3jE2d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378834AbhGSR0V (ORCPT + 99 others); Mon, 19 Jul 2021 13:26:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:46890 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350201AbhGSPpn (ORCPT ); Mon, 19 Jul 2021 11:45:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 95AAE61166; Mon, 19 Jul 2021 16:26:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626711981; bh=mcTb9YtVPkdlUK0sxT/Pyc5bw4su8gIpZz+V9Lk3fTk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qVi3jE2drPNrM7VdtIOcqqTryC1Lk4tcD0QB+8E2VjiSOkAQKGHe6jmG5hhsTHef8 H7lQ7ZjN+zGXBIgUQlmVCxT+0ckG0Ak09BSrU4oKJMECYsQCBnqvMUL6t2KlO7b311 KN8mcQUTflxY53Mhy/3rvYjBGtRShVEp7eTvQ/24= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Martin Blumenstingl , Lorenzo Pieralisi , Bjorn Helgaas , Rahul Tanwar , Sasha Levin Subject: [PATCH 5.12 205/292] PCI: intel-gw: Fix INTx enable Date: Mon, 19 Jul 2021 16:54:27 +0200 Message-Id: <20210719144949.243113037@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144942.514164272@linuxfoundation.org> References: <20210719144942.514164272@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Martin Blumenstingl [ Upstream commit 655832d12f2251e04031294f547c86935a0a126d ] The legacy PCI interrupt lines need to be enabled using PCIE_APP_IRNEN bits 13 (INTA), 14 (INTB), 15 (INTC) and 16 (INTD). The old code however was taking (for example) "13" as raw value instead of taking BIT(13). Define the legacy PCI interrupt bits using the BIT() macro and then use these in PCIE_APP_IRN_INT. Link: https://lore.kernel.org/r/20210106135540.48420-1-martin.blumenstingl@googlemail.com Fixes: ed22aaaede44 ("PCI: dwc: intel: PCIe RC controller driver") Signed-off-by: Martin Blumenstingl Signed-off-by: Lorenzo Pieralisi Signed-off-by: Bjorn Helgaas Acked-by: Rahul Tanwar Signed-off-by: Sasha Levin --- drivers/pci/controller/dwc/pcie-intel-gw.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/controller/dwc/pcie-intel-gw.c index 0cedd1f95f37..ae96bfbb6c83 100644 --- a/drivers/pci/controller/dwc/pcie-intel-gw.c +++ b/drivers/pci/controller/dwc/pcie-intel-gw.c @@ -39,6 +39,10 @@ #define PCIE_APP_IRN_PM_TO_ACK BIT(9) #define PCIE_APP_IRN_LINK_AUTO_BW_STAT BIT(11) #define PCIE_APP_IRN_BW_MGT BIT(12) +#define PCIE_APP_IRN_INTA BIT(13) +#define PCIE_APP_IRN_INTB BIT(14) +#define PCIE_APP_IRN_INTC BIT(15) +#define PCIE_APP_IRN_INTD BIT(16) #define PCIE_APP_IRN_MSG_LTR BIT(18) #define PCIE_APP_IRN_SYS_ERR_RC BIT(29) #define PCIE_APP_INTX_OFST 12 @@ -48,10 +52,8 @@ PCIE_APP_IRN_RX_VDM_MSG | PCIE_APP_IRN_SYS_ERR_RC | \ PCIE_APP_IRN_PM_TO_ACK | PCIE_APP_IRN_MSG_LTR | \ PCIE_APP_IRN_BW_MGT | PCIE_APP_IRN_LINK_AUTO_BW_STAT | \ - (PCIE_APP_INTX_OFST + PCI_INTERRUPT_INTA) | \ - (PCIE_APP_INTX_OFST + PCI_INTERRUPT_INTB) | \ - (PCIE_APP_INTX_OFST + PCI_INTERRUPT_INTC) | \ - (PCIE_APP_INTX_OFST + PCI_INTERRUPT_INTD)) + PCIE_APP_IRN_INTA | PCIE_APP_IRN_INTB | \ + PCIE_APP_IRN_INTC | PCIE_APP_IRN_INTD) #define BUS_IATU_OFFSET SZ_256M #define RESET_INTERVAL_MS 100 -- 2.30.2