Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3890163pxv; Mon, 19 Jul 2021 11:13:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLGkbEncgAIakilJm3l1DYHlpVaaDsLWPFNKR3ul/HqO2r+dyHSyKHxLk5ss9vlzaRrS59 X-Received: by 2002:a50:9355:: with SMTP id n21mr35658191eda.76.1626718392772; Mon, 19 Jul 2021 11:13:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626718392; cv=none; d=google.com; s=arc-20160816; b=kC012PdXfcFygakd8xs8dregDabIIP4bCk/VepDKjN3L42cf3y8MFgkuD71Wuv4qdl jwAw40EU7sjogNNPP8qWGxNh3E+1rtySF8wwt/saRI/AnZrW95pb4qJZbH1Ws7F2euyt mTQYixc6NYqbvbcBjKhSoBYSk/fdsVRdJoEx4n1KyQWYJPAA0/XcWqxTUjj27Pg82b05 e4E8hk+vBBAA6y/rffr9iY92gQ3xgPtoEIdK1ihyiu2Ff7igkIgJTQKLrYoUkmMl7TbK qtnIO7FCIyLHXzUQjo7/WV0G/VaaiMcC8nRKsKGu1UpYgV/Zihx6HgfON/WGx1Kra/l3 DI5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/BaHX3pNGruh5ORQ4aas6/NuSMwXnop12mB3qvdYwUk=; b=qo+dXsQuZx1NmJwC6wCGXdkEYO8HN7K7HVOeA6Rqvj6oTJbs0CwxxCg4MMwKztZ9i6 CkM29ud77xnBLFbxDhoFCNkABs+xGunyCoYZO7ZnMbu08v/v2zqIpVmTVwJtOwHJ31qD hsMRQA/0gauVgmsMzrAzjkW9YiS+u54qdUmSoF51XzS6NI+p8UHs7EWhdz4HD//FuozB V81Zvul0YhCJZb2lxuzmtixZ2/knlA3IYmHV/MOrmWKSUvaqg2DXyWH0Jc7eZ7QA6e3U +SQtVazaRWEjOGwpFfRX86EY1uM8V35EFjK7+SweWTnAWPEtHJnoMtb5uor9BAgMt4K4 rJbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="ubLQ/WtW"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w4si1915739edt.123.2021.07.19.11.12.48; Mon, 19 Jul 2021 11:13:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="ubLQ/WtW"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380621AbhGSR3q (ORCPT + 99 others); Mon, 19 Jul 2021 13:29:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:47916 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241527AbhGSPrH (ORCPT ); Mon, 19 Jul 2021 11:47:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6844E613DF; Mon, 19 Jul 2021 16:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626712032; bh=5kAhOn2eRTsba3I5fnZ22AzHtv6emCoac4CtMYcaWvU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ubLQ/WtWntnWd+0Wt+4RSsFCiFzf1S6PC69Sv9pqs+1MjirE7rAWdg/klrL/v1MFy sOVYTQ5yt9A6W8CnyLs5dqgziz5YveLbUUvujsAUcRKyYD9W4e9iDs4Qxn3MMvcxk5 fDBPHpvrktd5FSUru/yiQK3OcFBDAAMLW5TgZing= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Guenter Roeck , Andy Shevchenko , Kris Pan , Shruthi Sanil , Wim Van Sebroeck , Sasha Levin Subject: [PATCH 5.12 191/292] watchdog: keembay: Update pretimeout to zero in the TH ISR Date: Mon, 19 Jul 2021 16:54:13 +0200 Message-Id: <20210719144948.777595487@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144942.514164272@linuxfoundation.org> References: <20210719144942.514164272@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shruthi Sanil [ Upstream commit 75f6c56dfeec92c53e09a72896547888ac9a27d7 ] The pretimeout has to be updated to zero during the ISR of the ThresHold interrupt. Else the TH interrupt would be triggerred for every tick until the timeout. Fixes: fa0f8d51e90d ("watchdog: Add watchdog driver for Intel Keembay Soc") Reviewed-by: Guenter Roeck Reviewed-by: Andy Shevchenko Tested-by: Kris Pan Signed-off-by: Shruthi Sanil Link: https://lore.kernel.org/r/20210517174953.19404-4-shruthi.sanil@intel.com Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck Signed-off-by: Sasha Levin --- drivers/watchdog/keembay_wdt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/watchdog/keembay_wdt.c b/drivers/watchdog/keembay_wdt.c index b2afeb4a60e3..6053416b8d3d 100644 --- a/drivers/watchdog/keembay_wdt.c +++ b/drivers/watchdog/keembay_wdt.c @@ -154,6 +154,8 @@ static irqreturn_t keembay_wdt_th_isr(int irq, void *dev_id) struct keembay_wdt *wdt = dev_id; struct arm_smccc_res res; + keembay_wdt_set_pretimeout(&wdt->wdd, 0x0); + arm_smccc_smc(WDT_ISR_CLEAR, WDT_ISR_MASK, 0, 0, 0, 0, 0, 0, &res); dev_crit(wdt->wdd.parent, "Intel Keem Bay non-sec wdt pre-timeout.\n"); watchdog_notify_pretimeout(&wdt->wdd); -- 2.30.2