Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3900270pxv; Mon, 19 Jul 2021 11:29:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhYfAAYqrhFyqdEky7lWXE1AC1Y0XZxLLJ+oFF0iYc9SpM5cpl0+RSiVZxI4kCbj9ofjuf X-Received: by 2002:a50:fd99:: with SMTP id o25mr36500052edt.285.1626719371570; Mon, 19 Jul 2021 11:29:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626719371; cv=none; d=google.com; s=arc-20160816; b=O3AYUPygA7bXssFKgXek+VrSYjr2DpfAZJKFHfqVmck4AGvLBOYlNomLWRFouKxSEb Z3m1+/VHTTCueFS9xhUthIFarWBrXVnd/jsODpfVApWMlrT74XhMIUVFRavD3DGs4svW 2IAHj2TdYlZM2nWrcFz9QSGDDtr7wJuuUBr1noWRUt7ZVpya8YHp1f3X62WcFlwvRUWW 4Gflm6w0nEFmcxXve5CeZZRLxLmf+9MCRF+d2+SZJO0IXMMah1ADCrjqRNV8XhpTWZoP 0qWHVi4a5gm89DqeYC7OUHfyvkh2s6mvRdhNcwvB+/b2/VeYM31x42Xnk5nMdLLiWm8Q LF6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/VWdscdxudTJrOXJP0y7CBmQ6eCn04Hfh+ro8uvdWb8=; b=mY4t2NmVi0XlZ5651WKOUtnStie+tlYZ1rwRn9S30UfRRnBbWQQtjnaD92LlifT+QR V07Q0Md6uleEsk6CSVyOex8ewJqPdExWYwPiHRbJWOyijWWJ3KEsuwjlczzEGhFpFGQ4 tdk/3e38xejVeZiwjVwpWbv0GCqbiWCR++NPZwb6RgBlU7yQEho589S1GNVKsDuCYO3C b7UcB1MnJFdC7qydRQadg4l38KBLmI4nTYLC523/+GTxU72GaGZOoJxTRpNlVg2Ho1Ib mHKsmEk8bet7gRtHrvmvqAiEGOmzoRMj+sg2FBybDSM7YpES69xUCvdz86OtX8tSfOxN hFow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=p9GejY+R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x13si16858177edq.603.2021.07.19.11.29.08; Mon, 19 Jul 2021 11:29:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=p9GejY+R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381003AbhGSRhR (ORCPT + 99 others); Mon, 19 Jul 2021 13:37:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:50526 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348814AbhGSPty (ORCPT ); Mon, 19 Jul 2021 11:49:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 59E0161876; Mon, 19 Jul 2021 16:28:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626712121; bh=IBFI/NsLvnTDeENW4eAkcR1g8Z5XrQLd0HQjdND6skg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p9GejY+Rf1EUPukwnXRzeq0Jg979YLaVWHzioU+gxM/ei+45NGWHX/m4pIDeP1RWu ozxfV3hYfQzaGJrL3NS0NWf2Yf+mj/4bEGXmdw0u3JW3LOzl5rpXkYJCM0qhVnWd95 y1S6UrviTE+Pd87EbwqM9Hadg520d51gs+ao2egg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stefan Wahren , Pavel Hofman , Nicolas Saenz Julienne , Sasha Levin Subject: [PATCH 5.12 257/292] Revert "ARM: dts: bcm283x: increase dwc2s RX FIFO size" Date: Mon, 19 Jul 2021 16:55:19 +0200 Message-Id: <20210719144951.383393445@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144942.514164272@linuxfoundation.org> References: <20210719144942.514164272@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefan Wahren [ Upstream commit 77daceabedb42482bb6200fa26047c5591716e45 ] This reverts commit 278407a53c3b33fb820332c4d39eb39316c3879a. The original change breaks USB config on Raspberry Pi Zero and Pi 4 B, because it exceeds the total fifo size of 4080. A naive attempt to reduce g-tx-fifo-size doesn't help on Raspberry Pi Zero. So better go back. Fixes: 278407a53c3b ("ARM: dts: bcm283x: increase dwc2's RX FIFO size") Signed-off-by: Stefan Wahren Cc: Pavel Hofman Link: https://lore.kernel.org/r/1622293371-5997-1-git-send-email-stefan.wahren@i2se.com Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Sasha Levin --- arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi | 2 +- arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi b/arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi index 20322de2f8bf..e2fd9610e125 100644 --- a/arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi +++ b/arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 &usb { dr_mode = "otg"; - g-rx-fifo-size = <558>; + g-rx-fifo-size = <256>; g-np-tx-fifo-size = <32>; /* * According to dwc2 the sum of all device EP diff --git a/arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi b/arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi index 1409d1b559c1..0ff0e9e25327 100644 --- a/arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi +++ b/arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 &usb { dr_mode = "peripheral"; - g-rx-fifo-size = <558>; + g-rx-fifo-size = <256>; g-np-tx-fifo-size = <32>; g-tx-fifo-size = <256 256 512 512 512 768 768>; }; -- 2.30.2