Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V3 05/12] ASoC: amd: add ACP5x PCM platform driver
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        broonie@kernel.org, alsa-devel@alsa-project.org
Cc:     Sunil-kumar.Dommati@amd.com,
        open list <linux-kernel@vger.kernel.org>,
        Takashi Iwai <tiwai@suse.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Alexander.Deucher@amd.com,
        krisman@collabora.com
References: <20210719165140.16143-1-vijendar.mukunda@amd.com>
 <20210719165140.16143-6-vijendar.mukunda@amd.com>
 <f476dc4a-8185-77fd-d469-728aebdc6f65@linux.intel.com>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
Message-ID: <6c27b2bd-cd7b-ef0f-a89f-106d3d936580@amd.com>
Date:   Tue, 20 Jul 2021 00:35:57 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <f476dc4a-8185-77fd-d469-728aebdc6f65@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.0.160] (49.206.46.65) by MAXPR0101CA0053.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.23 via Frontend Transport; Mon, 19 Jul 2021 18:48:11 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3706cf3d-8a52-435c-c3bb-08d94ae5c39d
X-MS-TrafficTypeDiagnostic: MWHPR12MB1261:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR12MB12617E99CCD6A46C753D523697E19@MWHPR12MB1261.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:173;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Oh7Yjx9lkUYzcVKKkMzHIw5YvL94zAhFpEhZfTfQHU+mSaBzTli4mxPrKu4du4/u+n57FkaMBHAfZE2oQEx6GdWz6F6GOeZslYQnIDbyPoIcWgT8fIV2r6qjA35fmPnzSrltbZrQSHKbMRWT739H5lMAZDk+HuQZ3P3ifWXHSC0tS+KImaG+QHDmIzrfJLsOw4d3UBf4buIppMwwaRzWRsdzGLZTwIIbuzZlD5ljtwVVSlN8/luxXBsMcJTH0Gp7it3WP8M7q9KQLW6JnzDArEthpxxRMmmkfINZgIDlGD8zK5tp3hf17CCJiu491nkCHIpvLIG7+FEtIw/QKiR/rSLI3dx6nDUR13RjwOHQiRx9MBpgJOFuzPLswrwzi3zGcwNYNpn3gB/2iiZcz5HZxGWyczXvn7jJoBikMEpV+1RmUwZJjMdb2kQxg4alk2UBJD/tnGrMs8aW4Nkt3c3xVIPSOUfnhYiWnQPs9qpju6Ea7ziUpjghagzpc8YMckdbUa/e7tDcg4PSFupkJN17yne3cfcf+YVg+56HucmOf8OcarXddKUY6XGXyd6WXIIdeWkGiZI+Q/tcJFf0tY9WNFBPNac8Ma0k0r1iGZ82VS9fDXzb0DxB9V5ZWe8FanKlI8BoeIVbbvcV1EJJY/d2Im42YeFhniTjtyCk7+zSXNKta3sCLmJU3Bg9yjOD0OrGsfvrpNYUL5WDg85Lg0roJVV2GI3snO9ePxdSJyiOXHLvHHvZ10IiJ2SDbc85/1W9
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1201MB2557.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(346002)(376002)(396003)(39860400002)(54906003)(55236004)(53546011)(2906002)(1006002)(6666004)(956004)(26005)(4326008)(2616005)(186003)(16576012)(316002)(38100700002)(86362001)(6486002)(31696002)(5660300002)(478600001)(8936002)(66476007)(66556008)(8676002)(31686004)(36756003)(66946007)(32563001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aEFmS1V6cThWTk55T2VvMU9WVHljaFdFZU10akd5ZXBQbmoxZWNVUjNISUUv?=
 =?utf-8?B?Y0VUMExGVi9QSWhEMnZOV09YRDJNMlJKQmRWd283MzdUcjlHVWZIR0xWZXlw?=
 =?utf-8?B?eDJNN1hDUElvdXVBdm1NN1FDc1FXSGU5YTY2Yk5XRGFhWFU2S01sTGZZc3lo?=
 =?utf-8?B?WTBocmlVY083dWdaR2N3TGVGenFYSFhjWW1GalFoaS9aSjV3WDZEZGI2L3E1?=
 =?utf-8?B?NW9QalFKY2tLbVZ4d2xkbGt4TkdlS0hvNi8zQktrWXNhUzg5dXQ4dFBBOVZm?=
 =?utf-8?B?VTl2TWJyR3dyWEFYaWlDVjFuWmhWQlBuV3A0VDNRQ0YvYnBHa2h3MDNCME1V?=
 =?utf-8?B?WEErVStzTHJUN2tvTWM2TVZhdGFpYjBERDZJSWk3U21xbG1lSmVVWS9qWlk1?=
 =?utf-8?B?OCtKakJ2VjhNbXg2K1hDaDNWWFVocmxEOWsyTXNjUi96N2U0Q2pRKzN5OHRZ?=
 =?utf-8?B?am44TmJSbGszeS9yMWRLdTRvV1FzWnpNLzB4bkdwNjlSdFlrSnN6YXE4YWZ1?=
 =?utf-8?B?WkRFaEpPbmFzS0diZVhUNEdmN0FaRzM4dUR6a1dYUGNPUzFlbWw5K1FoUHQv?=
 =?utf-8?B?bDZHdGNUblBET2taZFllZCtwck1JNXc0S3I5bUZ4NEJ6MmpaejJhZUFxcGxo?=
 =?utf-8?B?UDU0Yk5hdWpjYjVHLzZqaWVyTS9jQ3hCS2trVmlaK2w0dDZubElSTm82QVAx?=
 =?utf-8?B?NDZVeDdCVWN0UzN6L1NMelJxSW52eGtVVjQzUTRtZnhpdWp0UDhFMWdkZGo3?=
 =?utf-8?B?QU80SG9lREtzVXlrV3Yvdk44RGlTSkp1aW5haGJHRHI3RHRSaVc2dmk1bDFT?=
 =?utf-8?B?UjhkczlmekgzaVdhTGphdXNLWkF2S2hPSzJkNUNMSU1US1NSSElsZ080U1h6?=
 =?utf-8?B?N29yZWlmbVp6UnhIYm1uZjBsYzFVMys5c3NwNkg3bFc4MTV0SnNxYVZmdmlU?=
 =?utf-8?B?NGM5SExyUG1qd1VadkxFdDlIWm9IeFovU045Y2ZoMFdKQ1ZTSTB2T0hyT3R2?=
 =?utf-8?B?N2laWHkvVmhKQy9EYVJEY2Fwd1R0NEFORzg5NWNEZlplMjVNM0lHM3FPckZ1?=
 =?utf-8?B?dHZRVjVrc3p3TDBqRTd2cWxBRldFYXN3MUVTOXEvVlhzUWFEcnRDekNnaWty?=
 =?utf-8?B?dllaT1hja2h1ZVRzbnFYbU1zTVNWT0Q5SWREcnU2MjBTWDNwZGYxOWxrdHZ6?=
 =?utf-8?B?WndSMGZRbWFIRHUyRFVOSzZtb2RHLzY0UDBGbkRoVkpVVkNQYXgrUkU0VC9J?=
 =?utf-8?B?a1JmSzRuZnZNNkIrME9ZdE5peElrUGtGNUZXVjh2Qkw3a0ZOSGFhSEtqM1Rw?=
 =?utf-8?B?Ujhqc3RuZHlNcW9YQTRiVFZsVHd0T0dqZk5udkp4czdtUjRaMTlMcWN1OUhC?=
 =?utf-8?B?SHlHVnJjYkRJdDBEK3RBZEtteHpwVW1FTUc3QmFpYXhoRjdMNU8yV2ptZFpi?=
 =?utf-8?B?NGQ4WFloV1FROWJCSEVrZnljeTNzWDZWYkFZWEs4MS90OEZhRG14Vlljb0l1?=
 =?utf-8?B?a05aRjVJWGdwVk9MeDZGMnRYd0tCeUoySjdETzRuak5ldGE4Q2hWdmlTVGlq?=
 =?utf-8?B?clJJcEVGbEIwSTBIM1QyallYNlUxVG5jKzhSM2xOS2pqUjQ5ZTY5S1Uvd3pl?=
 =?utf-8?B?UVlnM0tNQ2tkaTFYaC82SWZML1h4Vkt0VEN2SnJjV0pta1UwdEhLTG5NVXVM?=
 =?utf-8?B?b3Zrc1dyMkJRUWtpekxWdTRpYXR5U0U1Z1pmanRuZW9wZ1dHTUZGN1FSWEsx?=
 =?utf-8?Q?+33FYbCjPgD3HsPy1zH6QA0JDKPZQs4GPMlPmCZ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3706cf3d-8a52-435c-c3bb-08d94ae5c39d
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1201MB2557.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2021 18:48:14.1667
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yqz+P0eOE/8ZxkttIqBhd82wg54rdU4hmc7nf6dU6N7o7NUEoFXsw4ZHibeGkYCshPPPl0OoFmoEhIROSkW7Pg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1261
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/19/21 11:39 PM, Pierre-Louis Bossart wrote:
> 
>> +static int acp5x_audio_probe(struct platform_device *pdev)
>> +{
>> +	struct resource *res;
>> +	struct i2s_dev_data *adata;
>> +	int status;
>> +
>> +	if (!pdev->dev.platform_data) {
>> +		dev_err(&pdev->dev, "platform_data not retrieved\n");
>> +		return -ENODEV;
>> +	}
>> +	irqflags = *((unsigned int *)(pdev->dev.platform_data));
>> +
>> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> +	if (!res) {
>> +		dev_err(&pdev->dev, "IORESOURCE_MEM FAILED\n");
>> +			return -ENODEV;
>> +	}
>> +
>> +	adata = devm_kzalloc(&pdev->dev, sizeof(*adata), GFP_KERNEL);
>> +	if (!adata)
>> +		return -ENOMEM;
>> +
>> +	adata->acp5x_base = devm_ioremap(&pdev->dev, res->start,
>> +					 resource_size(res));
>> +	if (!adata->acp5x_base)
>> +		return -ENOMEM;
>> +	dev_set_drvdata(&pdev->dev, adata);
>> +	status = devm_snd_soc_register_component(&pdev->dev,
>> +						 &acp5x_i2s_component,
>> +						 NULL, 0);
>> +	if (status) {
>> +		dev_err(&pdev->dev, "Fail to register acp i2s component\n");
>> +		return -ENODEV;
> 
> Unclear why you need to change the error code explicitly to -ENODEV?
> 
> return status?

yes, we can return status rather than forcing error as -ENODEV.
Will fix it and post the new version.
> 
> 
>> +	}
>> +	return 0;
>> +}
>> +