Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [PATCH 0/2] Regex fixes for mips and x86 cross-compile
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <cover.1625734629.git.hns@goldelico.com>
Date:   Mon, 19 Jul 2021 21:04:53 +0200
Cc:     Discussions about the Letux Kernel <letux-kernel@openphoenux.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        linux-mips <linux-mips@vger.kernel.org>,
        linux-kernel@vger.kernel.org, kernel@pyra-handheld.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <4AC1CCE9-CCAF-4D4B-BAD5-CEB9E5155FDF@goldelico.com>
References: <cover.1625734629.git.hns@goldelico.com>
To:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, Jessica Yu <jeyu@kernel.org>,
        Miroslav Benes <mbenes@suse.cz>,
        Emil Velikov <emil.l.velikov@gmail.com>,
        Nick Desaulniers <ndesaulniers@google.com>
Precedence: bulk

Any chance that it gets merged?

> Am 08.07.2021 um 10:57 schrieb H. Nikolaus Schaller =
<hns@goldelico.com>:
>=20
> Trying to run the x86 relocs tool on a BSD based HOSTCC (cross
> compilation environment) leads to errors like
>=20
>  VOFFSET arch/x86/boot/compressed/../voffset.h - due to: vmlinux
>  CC      arch/x86/boot/compressed/misc.o - due to: =
arch/x86/boot/compressed/../voffset.h
>  OBJCOPY arch/x86/boot/compressed/vmlinux.bin - due to: vmlinux
>  RELOCS  arch/x86/boot/compressed/vmlinux.relocs - due to: vmlinux
> empty (sub)expressionarch/x86/boot/compressed/Makefile:118: recipe for =
target 'arch/x86/boot/compressed/vmlinux.relocs' failed
> make[3]: *** [arch/x86/boot/compressed/vmlinux.relocs] Error 1
>=20
> and when cross compiling a MIPS kernel on a BSD based HOSTCC
> we get errors like
>=20
>  SYNC    include/config/auto.conf.cmd - due to: .config
> egrep: empty (sub)expression
>  UPD     include/config/kernel.release
>  HOSTCC  scripts/dtc/dtc.o - due to target missing
>=20
> It turns out that relocs.c on x86 uses patterns like
>=20
> 	"something(|_end)"
>=20
> while MIPS uses egrep with
>=20
> 	(|MINOR_|PATCHLEVEL_)
>=20
> In both cases it is not valid syntax or gives undefined results
> according to POSIX 9.5.3 ERE Grammar
>=20
> 	=
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
>=20
> It seems to be silently accepted by the Linux regcmp() or egrep
> implementation while a BSD host complains.
>=20
> Such patterns can be replaced by a transformation like
>=20
> 	"(|p1|p2)" -> "(p1|p2)?"
>=20
> Test Linux:
>=20
> root@letux:~# echo foo | egrep '^(|foo)$'
> foo
> root@letux:~# echo fool | egrep '^(foo)?$'
> root@letux:~# echo fun | egrep '^(|foo)$'
> root@letux:~# echo f | egrep '^(|foo)$'
> root@letux:~# echo | egrep '^(|foo)$'
>=20
> root@letux:~# echo foo | egrep '^(foo)?$'
> foo
> root@letux:~# echo fool | egrep '^(foo)?$'
> root@letux:~# echo fun | egrep '^(foo)?$'
> root@letux:~# echo f | egrep '^(foo)?$'
> root@letux:~# echo | egrep '^(foo)?$'
>=20
> root@letux:~#=20
>=20
> Test BSD:
>=20
> iMac:master hns$ echo foo | egrep '^(|foo)$'
> egrep: empty (sub)expression
> iMac:master hns$ echo fool | egrep '^(foo)?$'
> egrep: empty (sub)expression
> iMac:master hns$ echo fun | egrep '^(|foo)$'
> egrep: empty (sub)expression
> iMac:master hns$ echo f | egrep '^(|foo)$'
> egrep: empty (sub)expression
> iMac:master hns$ echo | egrep '^(|foo)$'
> egrep: empty (sub)expression
> iMac:master hns$ echo foo | egrep '^(foo)?$'
> foo
> iMac:master hns$ echo fool | egrep '^(foo)?$'
> iMac:master hns$ echo fun | egrep '^(foo)?$'
> iMac:master hns$ echo f | egrep '^(foo)?$'
> iMac:master hns$ echo | egrep '^(foo)?$'
>=20
> iMac:master hns$=20
>=20
>=20
> H. Nikolaus Schaller (2):
>  x86/tools/relocs: Fix non-POSIX regexp
>  arch: mips: Fix non-POSIX regexp
>=20
> arch/mips/Makefile      | 2 +-
> arch/x86/tools/relocs.c | 8 ++++----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>=20
> --=20
> 2.31.1
>=20