Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: qOZlJWHCtCwBrqQhJPfBKDtWvgdrxMzX1junQu1p8vTXRV2gX//0Pnf41IuLyTlxwsld1ZYRFp
 6TjM4vmYzXUbwJHuvbmpWu8vik88GpKUmngLa2E5tTMlnyr7fXMAQz0FY+z6E1du5s15Wx0zK1
 1+IeXT/A0mwGHGbvxjSrGF5cj4TqLAEUj3nsHD28eW+aCmegf9YK45w40Hy/EndzNqPHTiMC4v
 X45ml7+wMg/17y9DTNphknHRBnLAyMViVK0j8sc2XADnbgOvt+1UBSlWNUWLPXWyoj6/UDLBtx
 nZ63hEo3axL+oIFWH7TCZlsI
IronPort-PHdr: A9a23:OLCA7BK59q90U6FLK9mcuLlmWUAX0o4c3iYr45Yqw4hDbr6kt8y7e
 hCFvbM21BSQBtWTq6odzbaP4ua4AS1IyK3CmUhKSIZLWR4BhJdetC0bK+nBN3fGKuX3ZTcxB
 sVIWQwt1Xi6NU9IBJS2PAWK8TW94jEIBxrwKxd+KPjrFY7OlcS30P2594HObwlSizexf69+I
 A+4oAnNucUanIVvJ6UswRfNvndEZv5ayGx1KV+XhRrw+tu88Jt++ClMpvwt8NJNX7/ndKoiV
 7xYCzomM2Ex5ML1sBTIUBWC6HgBXGgIixREGwfK4g30UZf3qSv6q/Fy2DKGMs3sTLA7Qiqt4
 qF2QxL1kigHNjo58GbKisxsia9QvRysqwBjz4PSfYqYL+R1cL/DctwGRGpBRsdRWDJHAoOgd
 IsEEu4NMf9Fo4Xhu1cCqB2zBQytBOP00T9Ih3n23aIn2Oo/CA/NwQIgH9MQv3TQsdr+KaMeX
 O6pwKXNyzjMaO9b1Dnh5ITVaxwtveyAVq90fcbMyUQjEgXIhUiSp4P4JTOYzuQDvXaG4eRuV
 uyhjHUqpx1trjW12sshkJXFip4Tx1vZ9St52oE1JdigRUF5YN6lEZtQtzydN4BrRc4jQ2Bpu
 CYgxb0HpZK3YCYHxY86xxHDcfyLaZaH7Q/+VOuIJzpzmX1qdq6liRmo7Uig1vPzVtOy0FtSo
 SdJjNvBuHAR2xHX6saLVPtw80Sv1zuRyQzd6uBJLEIpmKfaKZMsxr89m5sNvEnfHSL6hFn6g
 a2Lekgr5OSm6+LqaajlqJ+EL4J4lB3yP6A0lsG8Aek0KBYCU3WH9eimybHu+U/0TK1XgvA3l
 qTVqo7WKMobq6KjHQNY0Jwv5wihAzqo1tkTgGMJI0hfeB2diojkI1TOIPflAvihm1msizJrx
 +zePr3mH5XNMmDPkLf/crZ57E5R0A8zwspe55JQE70BOPzzVlLouNzWExM0Nw65z/zoCNV60
 YMeVmaPDbGDPKzOtl+I4/ojI+iKZIALpDbwM+Yp6+LqgHMjmlIQfbOl0YUKZHykBPhqPkGUb
 Hj0jtcEC2gKvw4+TOLwiF2FVD5ef3azXqM85j4hCYKqEZvPS462jbycwCi7BIdaaX5bBVCRC
 XvobZmLW+8QaCKOJc9sijgEVbmnS4882hCirQz6xKR9LurS5CIYsYnu1MZ65+LNjxE+7z90A
 NqH02GLUW50mnkERzgs3KBw8gRT0FCGhJl5kfxFEpQH9uFJWwZibcX00udgTd3+R1SSLZ+yV
 F+6T4D+UnkKRdUrzopLPhsVJg==
IronPort-HdrOrdr: A9a23:cOeCDq3cceP+DhupE01bhAqjBLMkLtp133Aq2lEZdPWaSL38qy
 nApoV96faZskdzZJhfo6HnBEDoexq1nv5ICOEqXItKNzOW3FdAQrsSj7cKAAeMJ8Q9zIRgPG
 tbHJSWcOeAdGSSRPyXjjWFLw==
From:   Yizhuo <yzhai003@ucr.edu>
Cc:     Yizhuo <yzhai003@ucr.edu>, Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Mugilraj Dhavachelvan <dmugil2000@gmail.com>,
        Olivier Moysan <olivier.moysan@st.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Arnaud Pouliquen <arnaud.pouliquen@st.com>,
        linux-iio@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] iio: adc: stm32-dfsdm: Fix the uninitialized use if regmap_read() fails
Date:   Mon, 19 Jul 2021 19:53:11 +0000
Message-Id: <20210719195313.40341-1-yzhai003@ucr.edu>
To:     unlisted-recipients:; (no To-header on input)
Precedence: bulk

Inside function stm32_dfsdm_irq(), the variable "status", "int_en"
could be uninitialized if the regmap_read() fails and returns an error
code.  However, they are directly used in the later context to decide
the control flow, which is potentially unsafe.

Fixes: e2e6771c64625 ("IIO: ADC: add STM32 DFSDM sigma delta ADC support")

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 drivers/iio/adc/stm32-dfsdm-adc.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
index 1cfefb3b5e56..d8b78aead942 100644
--- a/drivers/iio/adc/stm32-dfsdm-adc.c
+++ b/drivers/iio/adc/stm32-dfsdm-adc.c
@@ -1292,9 +1292,11 @@ static irqreturn_t stm32_dfsdm_irq(int irq, void *arg)
 	struct stm32_dfsdm_adc *adc = iio_priv(indio_dev);
 	struct regmap *regmap = adc->dfsdm->regmap;
 	unsigned int status, int_en;
+	int ret;
 
-	regmap_read(regmap, DFSDM_ISR(adc->fl_id), &status);
-	regmap_read(regmap, DFSDM_CR2(adc->fl_id), &int_en);
+	ret = regmap_read(regmap, DFSDM_ISR(adc->fl_id), &status);
+	if (ret)
+		return IRQ_HANDLED;
 
 	if (status & DFSDM_ISR_REOCF_MASK) {
 		/* Read the data register clean the IRQ status */
@@ -1303,6 +1305,9 @@ static irqreturn_t stm32_dfsdm_irq(int irq, void *arg)
 	}
 
 	if (status & DFSDM_ISR_ROVRF_MASK) {
+		ret = regmap_read(regmap, DFSDM_CR2(adc->fl_id), &int_en);
+		if (ret)
+			return IRQ_HANDLED;
 		if (int_en & DFSDM_CR2_ROVRIE_MASK)
 			dev_warn(&indio_dev->dev, "Overrun detected\n");
 		regmap_update_bits(regmap, DFSDM_ICR(adc->fl_id),
-- 
2.17.1