Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <2f26bc3df4851b3af93d51742de99b1c4f197e68.camel@linux.ibm.com>
Subject: Re: [PATCH] ima: Support euid keyword for buffer measurement
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Roberto Sassu <roberto.sassu@huawei.com>,
        Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Cc:     "tusharsu@linux.microsoft.com" <tusharsu@linux.microsoft.com>,
        "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>,
        "linux-security-module@vger.kernel.org" 
        <linux-security-module@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date:   Mon, 19 Jul 2021 17:30:34 -0400
In-Reply-To: <35a1ef50bf534933a10fd350aee9baa2@huawei.com>
References: <20210705115650.3373599-1-roberto.sassu@huawei.com>
         <2996f5ae-d76f-5fc9-bf90-857d4fc6644a@linux.microsoft.com>
         <35a1ef50bf534933a10fd350aee9baa2@huawei.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Precedence: bulk

Hi Roberto,

On Wed, 2021-07-07 at 07:15 +0000, Roberto Sassu wrote:
> > From: Lakshmi Ramasubramanian [mailto:nramas@linux.microsoft.com]
> > Sent: Tuesday, July 6, 2021 9:30 PM
> > On 7/5/2021 4:56 AM, Roberto Sassu wrote:
> > 
> > Hi Roberto,
> > 
> > > This patch makes the 'euid' keyword available for buffer measurement rules,
> > > in the same way as for other rules. Currently, there is only support for
> > > the 'uid' keyword.
> > >
> > > With this change, buffer measurement (or non-measurement) can depend
> > also
> > > on the process effective UID.
> > 
> > Who (kernel component) will be using this?
> 
> Hi Lakshmi
> 
> I'm using it in a (not yet submitted) test for digest lists.
> 
> It is in a dont_measure rule to try to unload a digest list
> without measurement and to check that this is not allowed
> if the digest list was measured at addition time (to ensure
> completeness of information).
> 
> > Maybe you could make this change as part of the patch set in which the
> > above "euid" support will be used.
> 
> I wanted to send the digest lists patch set without anything
> else. I could resend the patch as part of that patch set if it is
> preferred.

Unless there is another usecase, please keep it with the digest list
tests patch set.

Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>

thanks,

Mimi