Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4156674pxv; Mon, 19 Jul 2021 18:44:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoXT3pNxGz8pKW7I0kR34H/ifS0aq51Dso6An4FQnEu52i2MrDS5hdaJ0ncMxbzrlCt49W X-Received: by 2002:a17:906:a2d7:: with SMTP id by23mr29618430ejb.382.1626745459295; Mon, 19 Jul 2021 18:44:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626745459; cv=none; d=google.com; s=arc-20160816; b=biIXIDNrbNVxlLDJya0vfqphS4gwCCpEqJI+AFn7CReCBhfQO1eE8W7gr9k/sggSnR AGOYq+KI2vrhMbEMPp17dIyHpm1QzXBYeaRbs6lGzNJ4llKHe7syCygZDvG9JkVLaMik UYDPSbQ+deOie30hEwyGZupxMcFtftZjE4ZX0hq/0WC4fgDNwyue3pzh7ki9nS+rt7Jp FJyRUCnbgtUkfWXGj23j+oDCSXC+K3V3cPN+IxpivcBcfBc87gITVil17L7a2O5HeUo3 Y8dwSsWMVYbFXLuJsCwU15N1zzD8RVkzu3SLJbe1AnRZjaEK5DoZs5mAKz4TrH3/Hxxo 5N9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Ck70lmwzaS9vH8HU3BtHXVz1LHjFVK5oUXJM3yhNVHY=; b=QO1RokWvFJrohNBkB/EBuFpKR6EZWCJ2ksxZyA1sJI50ovZ6LpUFnfioI1xrrexX+Q NT1sDi1gJxefzOVLJ6dbJqmucGzBUWmJb6l3ZHEN+rEjPKXO+MG+gj4Trj3jljwwgw7z q0V9jHqUC0pRGkxUqVDksJnTZ8ZuiB849+8q80xEI7JovxQnT6gGf7SJiEaijfND4ZEm 6cDdlSHM1MAy32B4jQTGOsAE0iBeEVyLKB4s2Wo5itC03u7ltZNtshsAsTmvGQRbFkLI wiaaVOOYebsBKgKZki2UErPbS8jF5dt1JF/oWs0xpVBsYiofwKnT426HBIAGNpRF770K izxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=x04ffV2f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d5si24129635ejd.487.2021.07.19.18.43.56; Mon, 19 Jul 2021 18:44:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=x04ffV2f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344650AbhGSO7x (ORCPT + 99 others); Mon, 19 Jul 2021 10:59:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:53290 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244560AbhGSOhp (ORCPT ); Mon, 19 Jul 2021 10:37:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 26E6D6120A; Mon, 19 Jul 2021 15:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626707851; bh=9jCJNCia3eUKC2iySVvG5X6hbJWuaZ3NbdUFamvukTc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=x04ffV2fDip229AGLwrjBG0it4TDiO+7GBGO5h11G0tLdZymzsySSnOgBoiOebEXp cAjO14cg04I4TmmJufj+3U9bR6Y65+n0Bi9MtfWRI+WvtG8n1h5KYBqW8IcXl2zsK5 7bHJOawYDEWBDQbzJbZOdgLkB/o4PM69Lcch6v/E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sergey Shtylyov , Jens Axboe , Sasha Levin Subject: [PATCH 4.14 083/315] pata_ep93xx: fix deferred probing Date: Mon, 19 Jul 2021 16:49:32 +0200 Message-Id: <20210719144945.606734732@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144942.861561397@linuxfoundation.org> References: <20210719144942.861561397@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sergey Shtylyov [ Upstream commit 5c8121262484d99bffb598f39a0df445cecd8efb ] The driver overrides the error codes returned by platform_get_irq() to -ENXIO, so if it returns -EPROBE_DEFER, the driver would fail the probe permanently instead of the deferred probing. Propagate the error code upstream, as it should have been done from the start... Fixes: 2fff27512600 ("PATA host controller driver for ep93xx") Signed-off-by: Sergey Shtylyov Link: https://lore.kernel.org/r/509fda88-2e0d-2cc7-f411-695d7e94b136@omprussia.ru Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/ata/pata_ep93xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c index cc6d06c1b2c7..7ce62cdb63a5 100644 --- a/drivers/ata/pata_ep93xx.c +++ b/drivers/ata/pata_ep93xx.c @@ -927,7 +927,7 @@ static int ep93xx_pata_probe(struct platform_device *pdev) /* INT[3] (IRQ_EP93XX_EXT3) line connected as pull down */ irq = platform_get_irq(pdev, 0); if (irq < 0) { - err = -ENXIO; + err = irq; goto err_rel_gpio; } -- 2.30.2