Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030872AbWKULaR (ORCPT ); Tue, 21 Nov 2006 06:30:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S966964AbWKULaR (ORCPT ); Tue, 21 Nov 2006 06:30:17 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:39076 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S966961AbWKULaQ (ORCPT ); Tue, 21 Nov 2006 06:30:16 -0500 Date: Tue, 21 Nov 2006 12:30:05 +0100 From: Pavel Machek To: Komal Shah Cc: Vladimir , Tony Lindgren , kernel list Subject: Re: Siemens sx1: merge framebuffer support Message-ID: <20061121113005.GA1900@elf.ucw.cz> References: <20061118181607.GA15275@elf.ucw.cz> <20061120190404.GD4597@atomide.com> <3a5b1be00611210042p2237a0fbpece68912e3d23f4c@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3a5b1be00611210042p2237a0fbpece68912e3d23f4c@mail.gmail.com> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.11+cvs20060126 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1446 Lines: 36 Hi1 > >> > Framebuffer support for Siemens SX1; this is second big patch. (Third > >> > one will be mixer/sound support). Support is simple / pretty minimal, > >> > but seems to work okay (and is somehow important for a cell phone :-). > >> > >> Pushed to linux-omap. I guess you're planning to send the missing > >> Kconfig + Makefile patch for this? > >> > >> Also, it would be better to use omap_mcbsp_xmit_word() or > >> omap_mcsbsp_spi_master_xmit_word_poll() instead of OMAP_MCBSP_WRITE as > >> it does not do any checking that it worked. The aic23 and tsc2101 > >> audio in linux-omap tree in general has the same problem. > >> > >> Regards, > >> > >> Tony > >> > > > >Hmm. McBSP3 in SX1 is used in "GPIO mode". The only line used is CLKX, > >so I think OMAP_MCBSP_WRITE would be enough. Am I wrong ? > > Please also send defconfig (may be siemens_sx1_defconfig OR > omap_sx1_310_defconfig) patch for this mobile once, your minimum > required patches are pushed to -omap git tree. Thanx. Yes, will do. I was trying to get it compiling first. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/