Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Date:   Tue, 20 Jul 2021 08:16:33 +0300
From:   Eli Cohen <elic@nvidia.com>
To:     Jason Wang <jasowang@redhat.com>
CC:     <mst@redhat.com>, <sgarzare@redhat.com>,
        <virtualization@lists.linux-foundation.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vdpa/vdpa_sim: Use the negotiated features when calling
 vringh_init_iotlb
Message-ID: <20210720051633.GA245424@mtl-vdi-166.wap.labs.mlnx>
References: <20210719134407.175884-1-elic@nvidia.com>
 <970569fc-80bc-b0ef-b163-c59650796515@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <970569fc-80bc-b0ef-b163-c59650796515@redhat.com>
User-Agent: Mutt/1.9.5 (bf161cf53efb) (2018-04-13)
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 05:16:42.5443
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 25fab078-4a04-43fd-46d2-08d94b3d8fca
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT045.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3377
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 20, 2021 at 11:13:00AM +0800, Jason Wang wrote:
> 
> 在 2021/7/19 下午9:44, Eli Cohen 写道:
> > When calling vringh_init_iotlb(), use the negotiated features which
> > might be different than the supported features.
> > 
> > Fixes: 011c35bac5ef ("vdpa_sim: add supported_features field in vdpasim_dev_attr)
> 
> 
> As Stefano said.
> 
> It should be 2c53d0f64c06f ("vdpasim: vDPA device simulator")

Makes sense. Though I haven't got Stefano's message.
I will post another one.

> 
> Other than this
> 
> Acked-by: Jason Wang <jasowang@redhat.com>
> 
> 
> > Signed-off-by: Eli Cohen <elic@nvidia.com>
> > ---
> >   drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> > index 14e024de5cbf..89a474c7a096 100644
> > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
> > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> > @@ -66,7 +66,7 @@ static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx)
> >   {
> >   	struct vdpasim_virtqueue *vq = &vdpasim->vqs[idx];
> > -	vringh_init_iotlb(&vq->vring, vdpasim->dev_attr.supported_features,
> > +	vringh_init_iotlb(&vq->vring, vdpasim->features,
> >   			  VDPASIM_QUEUE_MAX, false,
> >   			  (struct vring_desc *)(uintptr_t)vq->desc_addr,
> >   			  (struct vring_avail *)
> > @@ -86,7 +86,7 @@ static void vdpasim_vq_reset(struct vdpasim *vdpasim,
> >   	vq->device_addr = 0;
> >   	vq->cb = NULL;
> >   	vq->private = NULL;
> > -	vringh_init_iotlb(&vq->vring, vdpasim->dev_attr.supported_features,
> > +	vringh_init_iotlb(&vq->vring, vdpasim->features,
> >   			  VDPASIM_QUEUE_MAX, false, NULL, NULL, NULL);
> >   	vq->vring.notify = NULL;
>